From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8PzCHcl0fl+jaQAA0tVLHw (envelope-from ) for ; Thu, 08 Oct 2020 02:09:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wOK2Gcl0fl8xGwAA1q6Kng (envelope-from ) for ; Thu, 08 Oct 2020 02:09:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B900694023C for ; Thu, 8 Oct 2020 02:09:12 +0000 (UTC) Received: from localhost ([::1]:53544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQLMk-0000U5-CJ for larch@yhetil.org; Wed, 07 Oct 2020 22:09:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQLMc-0000Tq-QC for guix-patches@gnu.org; Wed, 07 Oct 2020 22:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46819) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQLMc-0001lS-Gv for guix-patches@gnu.org; Wed, 07 Oct 2020 22:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQLMc-0002r1-Cb for guix-patches@gnu.org; Wed, 07 Oct 2020 22:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43840] [PATCH] gnu: Add esbuild. Resent-From: Ryan Prior Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Oct 2020 02:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43840 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: "43840@debbugs.gnu.org" <43840@debbugs.gnu.org> Received: via spool by 43840-submit@debbugs.gnu.org id=B43840.160212293410957 (code B ref 43840); Thu, 08 Oct 2020 02:09:02 +0000 Received: (at 43840) by debbugs.gnu.org; 8 Oct 2020 02:08:54 +0000 Received: from localhost ([127.0.0.1]:58365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQLMU-0002qe-IU for submit@debbugs.gnu.org; Wed, 07 Oct 2020 22:08:54 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:20113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQLMS-0002qO-ML for 43840@debbugs.gnu.org; Wed, 07 Oct 2020 22:08:54 -0400 Date: Thu, 08 Oct 2020 02:08:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1602122926; bh=d+UvsI15FJPvYPJwblt37m2OGkOw/KjrowWWAFtKsro=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=UombGSYd2vpqbriP/BVyG1RwiX6bSPzLHQVC4k1RL3UmpGbQBxJYBHfcewVGh0hUe wCx72dHHw5TMCUYVr0CIIZGb1RmmhahGNYAVaHXPhbfh9Ky15I0qh7EXBt6djx86Vr B6LmDr33bGGMc9EVGi/W6CFaQSLh5XwB5Wz6vX44= Message-ID: In-Reply-To: <20201007063431.GH21174@E5400> References: <20201007023119.22495-1-rprior@protonmail.com> <20201007063431.GH21174@E5400> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Ryan Prior , Ryan Prior via Guix-patches From: Ryan Prior via Guix-patches via X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=protonmail.com header.s=protonmail header.b=UombGSYd; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: XCtC4TtsQpQO Hey Efraim, thank you for your comments! On Wednesday, October 7th, 2020 at 6:34 AM, Efraim Flashner wrote: > There is an npm directory which is where the compiled binaries are > placed, there are a couple in the checked out repo. The compiled binaries might be placed there by the gnu-build-system, but th= e go-build-system does not put binaries there by itself. (Note that their m= ake target explicitly specifies output directories.) I think our build totally ignores this directory, so it shouldn't matter wh= ether we delete it, but if you think removing the unneeded directory improv= es the package I'll update the patch with a snippet. > Is it worth trying to run some of the test suite? I see there are a > couple of 'make check' type targets in the Makefile at the root of th= e > repository and currently there are none run during the build. It would be nice to run their tests, but the test system currently assumes = network access to install some various JavaScript dependencies using npm. W= e might patch the test system and vendor in the deps (used only for testing= ,) what do you think? Ryan