From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qOSZEAm41mFuYQEAgWs5BA (envelope-from ) for ; Thu, 06 Jan 2022 10:36:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aNBZCQm41mHxaQEAG6o9tA (envelope-from ) for ; Thu, 06 Jan 2022 10:36:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 83D181B1A3 for ; Thu, 6 Jan 2022 10:36:08 +0100 (CET) Received: from localhost ([::1]:51530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5PBn-0000eX-FB for larch@yhetil.org; Thu, 06 Jan 2022 04:36:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5PAk-0000ad-V4 for guix-patches@gnu.org; Thu, 06 Jan 2022 04:35:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46766) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5PAk-0000hk-H3 for guix-patches@gnu.org; Thu, 06 Jan 2022 04:35:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5PAk-00018m-EJ for guix-patches@gnu.org; Thu, 06 Jan 2022 04:35:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52977] [PATCH 0/6] Update some minetest packages Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 Jan 2022 09:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52977 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 52977@debbugs.gnu.org Received: via spool by 52977-submit@debbugs.gnu.org id=B52977.16414616644338 (code B ref 52977); Thu, 06 Jan 2022 09:35:02 +0000 Received: (at 52977) by debbugs.gnu.org; 6 Jan 2022 09:34:24 +0000 Received: from localhost ([127.0.0.1]:39669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5PA8-00017t-Ck for submit@debbugs.gnu.org; Thu, 06 Jan 2022 04:34:24 -0500 Received: from albert.telenet-ops.be ([195.130.137.90]:45506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5PA6-00017k-1x for 52977@debbugs.gnu.org; Thu, 06 Jan 2022 04:34:23 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id fMaL260074UW6Th06MaLlF; Thu, 06 Jan 2022 10:34:20 +0100 Message-ID: From: Maxime Devos Date: Thu, 06 Jan 2022 09:33:53 +0000 In-Reply-To: <4dcbff837011d55f31b2514364c88e9011760a69.camel@gmail.com> References: <0eceb36ac47fee789ebaa551cc3b041e777bbce1.camel@telenet.be> <87czl5hl2a.fsf@gnu.org> <07bdaad1c688d1cdf0a9f89f315e60cb6b2a084e.camel@telenet.be> <4dcbff837011d55f31b2514364c88e9011760a69.camel@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-fP4NyOsKNr+UwHw4AmG8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1641461660; bh=e/4u9pEG0tomi+DNbs5gSdfv1umIlFeV0t6ahvamDR4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=BogaugpUUd3rcHGak+k4jD23mM6+CHKrZ8z35ptwuS9AAD/z72VZPtvUwxcoGAu8z GA7jgsdRVDDEeK3l9sE+TkFH525LnW84mCFiit180iziWOHLCebxo6y/JnPDiadE3+ TjcnqsCBbksM1KfFf4DklTiA0vNtl7JnGPiO+etpilSgub4eVzMvOFJC9kAZ0Pu7ZL jemtMMGGM0mPsH/zZpzns6RNddNS0wzUZyM+eJVwAyYHUB+IEKi7/hZXUzaFMb27Nn crKzpm0gYO6wrRZjoz3lnObaCisMrVAweI03keI2L4er5zDdokJPZXR1jWlczX83pA bUCuwOSNuawxw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641461768; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=e/4u9pEG0tomi+DNbs5gSdfv1umIlFeV0t6ahvamDR4=; b=lCTrsN9uR0W+4aUfj+rmKsqYEPB0USLK1p34C5LINvHEbw2YDKh241T3G/ewWC8Kt+yU/B ZMwnXW81cECl2QmoEvTL+ea508ptoCmXFhWx250Bb/kQXENGvHFxE64r0qjfexHpjPYaXF uiJp+7L12+/TJCnkkB9mKVUDwiTogU5xU3XyJ++dzoQ2rmkaKCiJ9LiXAeojmX26Gw0I9a KGjMZRKTzU48um3MMAIW5nxt237NdQTcMDEnfbCuYV0rpXGtqzXbrdXBnfn+qjILMuUVkU ZBiknQOju6qWNuzS4iy+ZHKlRyQt1l6nhdKm4mJOAZICNlPHZQ0WBYk4nHh3+Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641461768; a=rsa-sha256; cv=none; b=ONcG3lp8L5OP+QXWD+iEHo7jJ1yFnYLvly8P/juXMJ9Um4SkcVTT2cTkk8n0TEqYdaCVLK fXkuWiCEWj6E4gBQkAjoj6YajtrROh9kGKe9HJwKoXSMfkNaucRAGBVbW/7N7EvltZfsEt CO7jz8SUeaYz7Y0Uu1ICfzvzvv1ZgVTJkUsfBEicXI5AjQcMIy/bsGmjU1gBKWUQhEok97 qgftl5oms2FPUyjtLEYGPyK8iFzwGUImnrUMqMxykdOsYKJ3CwGfp24MN6afIOopjx6kYG D1LIq/wJGOBXqyT+skBxiPNuUlAhQGoVARGxmM8pZFKfhdL27+8B7BfJg+yrLA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=BogaugpU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.70 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=BogaugpU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 83D181B1A3 X-Spam-Score: -4.70 X-Migadu-Scanner: scn0.migadu.com X-TUID: R/dRmY7q5umx --=-fP4NyOsKNr+UwHw4AmG8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Liliana Marie Prikler schreef op do 06-01-2022 om 01:52 [+0100]: > > [...] > If I recall correctly, this was also a point of debate in the initial > series that added the importer.=C2=A0 Can we establish an ordering/heuris= tic > here?=C2=A0 E.g. "if we have git tags use those, otherwise use contentdb"= , > "always use contentdb" or "always use whatever was edited most > recently"? Keep in mind that the minetest importer doesn't know about git tag -- the only interaction it has with git is cloning repositories and checking out commits by the commit id provided by ContentDB. I'm assuming you're referring to the generic-git updater here, or a hypothetical minetest updater that has been modified to interact with git tags. * Problem with using git tags: git tags sometimes disappear. E.g., in minetest-ethereal, there's currently a tag 2021-04-06 and 2021-09-23, but there's no tag for 2021-07-28 (the version currently in guix). This could be resolved by including the commit instead of the tag in the package definition, and still searching for the git tag, but as I understand it, there have been some objections to including the commit in the package definition (https://lists.gnu.org/archive/html/guix-devel/2021-12/msg00259.html). Even then, there's another problem: sometimes releases are made without a corresponding git tag. E.g., on ContentDB there's a version 2022-01-05 but there's no 2022-01-05 tag in the git repository. That could be resolved by =E2=80=98always use contentdb for minetest packages=E2=80=99 or =E2=80=98always use whatever was edited most recentl= y=E2=80=99. * Problem with =E2=80=98whatever was edited most recently=E2=80=99: AFAIK g= it tags don't carry that information. Though the commit time/modification time in the commit it points to might be a decent approximation in practice. ContentDB has some information on when a release was released (release_date, see https://content.minetest.net/help/api/). I suppose this could work, though there's a slight problem: The version scheme in guix would occassionally switch between x.y.z and YYYY-MM-DD, which would confuse the =E2=80=98these packages have been upgraded=E2=80=99 logic. I suppose the best option would be to always use the version from ContentDB (*), because the exact versioning scheme used doesn't matter much, as long as it remains consistent over time, and just using ContentDB is convenient. (*) Unless it isn't on ContentDB of course, though all minetest packages currently in Guix are on ContentDB. Additionally, if the forum versions / git tags / contentdb releases are inconsistent (e.g. the forum and git tags are x.y.z and the releases are YYYY-MM-DD), we could inform upstream that guix uses the release titles because otherwise things become complicated for guix, so if upstream doesn't want that, they need to use x.y.z in their release titles as well Does that seem reasonable to you? I could write a patch to that effect. Greetings, Maxime. --=-fP4NyOsKNr+UwHw4AmG8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYda3gRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hdJAQCiFrOj5FGavfxm8GOGGyHQKZR5 pfhf3B4ppwI6alapFgEAuO4OtrFXF0Zb028ebYp5FbsbARuywx2e3HK47UrscQA= =gZYH -----END PGP SIGNATURE----- --=-fP4NyOsKNr+UwHw4AmG8--