unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Raghav Gururajan <rg@raghavgururajan.name>, 50445@debbugs.gnu.org
Subject: [bug#50445] [PATCHES wip-gnome v1 3/4] gnu: gtksourceview: Enable documentation.
Date: Tue, 07 Sep 2021 16:05:03 +0200	[thread overview]
Message-ID: <e9416b8ac0e7a58ab3de57b9bb94bc17d017718d.camel@telenet.be> (raw)
In-Reply-To: <20210907010217.12746-3-rg@raghavgururajan.name>

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi,

> -    '(#:phases
> +    `(#:configure-flags
> +      (list
> +       ,@(if (%current-target-system)
> +       ;; If true, gtkdoc-scangobj will try to execute a
> +       ;; cross-compiled binary.
> +       '("-Dgtk_doc=false")
> +       '("-Dgtk_doc=true")))

These two lines above need to be indented.

Otherwise, this patch series looks good to me, but I didn't test it.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2021-09-07 14:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07  0:59 [bug#50445] GtkSourceView Raghav Gururajan via Guix-patches via
2021-09-07  1:02 ` [bug#50445] [PATCHES wip-gnome v1 1/4] gnu: gtksourceview: Update to 4.8.1 and change build-system Raghav Gururajan via Guix-patches via
2021-09-07  1:02   ` [bug#50445] [PATCHES wip-gnome v1 2/4] gnu: gtksourceview: Add missing input as per pkg-config file Raghav Gururajan via Guix-patches via
2021-09-07  1:02   ` [bug#50445] [PATCHES wip-gnome v1 3/4] gnu: gtksourceview: Enable documentation Raghav Gururajan via Guix-patches via
2021-09-07 14:05     ` Maxime Devos [this message]
2021-09-07 19:21       ` Raghav Gururajan via Guix-patches via
2021-09-07  1:02   ` [bug#50445] [PATCHES wip-gnome v1 4/4] gnu: gtksourceview@3: Adjust inherited fields and update to 3.24.11 Raghav Gururajan via Guix-patches via
2021-09-07 19:23 ` bug#50445: GtkSourceView Raghav Gururajan via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9416b8ac0e7a58ab3de57b9bb94bc17d017718d.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=50445@debbugs.gnu.org \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).