From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OAJjMEtkwWFvhQAAgWs5BA (envelope-from ) for ; Tue, 21 Dec 2021 06:21:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iDLYK0tkwWHrBwAAbx9fmQ (envelope-from ) for ; Tue, 21 Dec 2021 05:21:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 72364291FA for ; Tue, 21 Dec 2021 06:21:15 +0100 (CET) Received: from localhost ([::1]:37602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzXaM-0003jN-GE for larch@yhetil.org; Tue, 21 Dec 2021 00:21:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzXaA-0003i3-DK for guix-patches@gnu.org; Tue, 21 Dec 2021 00:21:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40582) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzXa9-0008Ei-SF for guix-patches@gnu.org; Tue, 21 Dec 2021 00:21:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mzXa9-0002N0-P3 for guix-patches@gnu.org; Tue, 21 Dec 2021 00:21:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v5 07/45] guix: node-build-system: Add #:absent-dependencies argument. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Dec 2021 05:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , Timothy Sample Cc: 51838@debbugs.gnu.org, Pierre Langlois , Jelle Licht Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.16400640429067 (code B ref 51838); Tue, 21 Dec 2021 05:21:01 +0000 Received: (at 51838) by debbugs.gnu.org; 21 Dec 2021 05:20:42 +0000 Received: from localhost ([127.0.0.1]:52128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzXZq-0002MA-7D for submit@debbugs.gnu.org; Tue, 21 Dec 2021 00:20:42 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:33494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzXZk-0002Lq-8k for 51838@debbugs.gnu.org; Tue, 21 Dec 2021 00:20:40 -0500 Received: by mail-wr1-f68.google.com with SMTP id d9so4913090wrb.0 for <51838@debbugs.gnu.org>; Mon, 20 Dec 2021 21:20:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=fExQKRmlrLz4ycayeDhbnd/b7x7RiiyFAxAwdCkexAg=; b=pG/jnrhIUfQMPZag8kfVAFj7dC1jpu7uC0NIAN8oOWXKKBNSdVV4JD2TpFFnt0CgxI WcizDsSTSl2jCvO6D454fDx3uUTUFpGHmnpqhnxl5M5MnzJJsNJ+kYxVCKmckFZs3fZJ iOOHikDPXwpt9UtNz4N8bJClZQDNXITb+vk6VTU4oGBxvdHsM6wtTwFSIiBESlw6lDW6 po5k+/+rnk8CbedNUDxrR5XL1lVsa/clnmcJ3AaDJrhdw3ZOmdC01AB2syizTo6XVCUr 6RhAlROved6EduiEWKLNAQ0RilKBmb7QNJ3b1Mq3PJ1CFSNrC4hLg0ULVA0hRclU+aKl VpqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=fExQKRmlrLz4ycayeDhbnd/b7x7RiiyFAxAwdCkexAg=; b=6vwzOqP7tb8ZzqMHnQqNJf0jF9nEMlUp8zml2uHTT9H14P/W0XyhfiC2TEIHaWOnx/ /7LFQ6ZFLzdIaSkhoKGeVtKBOezUb/g60r5RadluiOis+JAGinSGu2FrKTlQDbiErRvN MjV2tBRmJ56jtkgKpbRz+SFGrqQR6FNp01iXCltGiihMZ4nKHM+cI9kOZow6PWcg1o0y v/sPInaNwYKwQTzIwXuE5BAgA15CbZXyvO9lE6wicd3xbB54H/HbvvAtS1M6Shd9gElp VEOkpiB2zir21Zmmix3PlWKol1Wl6XsMh23xVRqSbOVyqv7VT36vy/EsVzzWx9EzAwNV fzGg== X-Gm-Message-State: AOAM530n2Yg5WuoHxX/ZHojJr+bJP3gRStZfLu9FI8bZnN8fs5wV+Hzu UjYhr7emK32LJ89ORorcvpA= X-Google-Smtp-Source: ABdhPJzKtwFHg82zhdS+8pqqU+pANT5UfWI2Q3b4UWmdnMdh7HXyUqYUj2Mf1plCK5rBXbSUox3xCA== X-Received: by 2002:a5d:4385:: with SMTP id i5mr1105786wrq.178.1640064030341; Mon, 20 Dec 2021 21:20:30 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d2sm1245948wmb.24.2021.12.20.21.20.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 21:20:29 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Tue, 21 Dec 2021 06:20:28 +0100 In-Reply-To: <41461d4f-5e7d-d9be-51c4-7a58c4f7570f@philipmcgrath.com> References: <20211213060107.129223-1-philip@philipmcgrath.com> <20211217020325.520821-1-philip@philipmcgrath.com> <20211217020325.520821-8-philip@philipmcgrath.com> <87k0g36xp3.fsf@ngyro.com> <871r2a7hme.fsf@ngyro.com> <815f327e36ecd24066179586997947ecd8f31150.camel@gmail.com> <33696592-8a3a-8260-bf27-652cf78727a6@philipmcgrath.com> <2c803ea8f5c5c16c892f5528f63a4c7e98470c5b.camel@gmail.com> <314a0ea4-a851-6642-0a59-d4c61d65c242@philipmcgrath.com> <35164d79ab6ae1c0595d27f023376cf98ab1a39d.camel@gmail.com> <9533cfc8-b822-edc0-67ac-7e2c9aeacb09@philipmcgrath.com> <87r1a7118r.fsf@ngyro.com> <41461d4f-5e7d-d9be-51c4-7a58c4f7570f@philipmcgrath.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640064075; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fExQKRmlrLz4ycayeDhbnd/b7x7RiiyFAxAwdCkexAg=; b=a3RZzaO6UnrneiLeJ2w0a/jzctK/nv/5TNwcrmGjRWCZ41/Y9E9ly/AIUv1PQ6M4LaeYKr ODIly1eNT2wzm1h1XG7q3zSNqD7rllpZe0FyxDgr6jNMpt790sl4BNJv5AiK2cwdNuP5gh M9R8wxA1y5ygAqFoEUQF/1K3isOFketv8GI4wfyUTMool5KNLR7cPhgef+glkd/swIaMX3 km22mOlClaKLOROavmRHVVedaclxNWNcCuwIA9y+cOBCL6XjOg2sht3XHhXGalj8p+YEnh wi1sbY4HyLMnqR8rSE7u26Q49/eaEZ1vpkA2kpIh67yaMXp0lYoumRwYDEEG7g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640064075; a=rsa-sha256; cv=none; b=ad7l19SIduKMAfhBZ/lyP7jxjYl3SqktrYdDU/WPT8jyjHeYNvmSxOm4AjTSwWDxA2EsUe UpSX5C7NksnpYyV918Ibi9ouRH4DCq+McJJCgw2uA+4eaDjezFyeq+tKiVJJnMHbj/ELdO 4unp4rdi9RvV3ThVmUxX85uASTVTW4L18dbUlMM+2ATX8AUuSbztSe2JPmVUh/a7xoMjlz LRvC7lE+YLoitBXxs7D0hp+4ldU04K53OB/F7UuakqwmA5qpF6PCVddqLfg5VuYjCQxKe6 IPVmaAUl5x6znPZrKrlnrxpU4cybgh7bRpX2BTL2D9gzgCcWBwml4M3TrhcntQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="pG/jnrhI"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="pG/jnrhI"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 72364291FA X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: KhPbmLrr/b4C Hi, excuse my brevity, but I'll be off to work soon. Am Montag, dem 20.12.2021 um 22:59 -0500 schrieb Philip McGrath: > My reservation regarding: > > > > > (add-after 'patch-dependencies 'drop-junk > >    (lambda _ > >      (with-atomic-json-replacement "package.json" > >        (lambda (json) (delete-dependencies json '("node-tap")))))) > > > > is that `with-atomic-json-replacement` would make (guix build json)'s > representation a part of node-build-system's API, which it currently > is not. For the reasons I detailed in my last email, I think that > would open up a larger can of worms than it might seem. That might be a valid concern, but I'd point to the "we don't gratuitously change API" shield. Plus if we do, we'd replace our current JSON by Guile-JSON. If that has a different internal representation that would awfully break things, please do tell. > I guess we should do as Jelle suggests: > > On 12/20/21 18:10, Jelle Licht wrote: >  > I believe the best thing to do would be to push the earlier >  > uncontroversial node patches. >  > >  >[...] I did suggest that too, but note that it would only upsteam patches 1-4 of 45, as patch 5 already touches node-build-system. Patch 5 would probably be fine to go as well (can the others confirm that?), but if the goal is to push today, someone else will have to do it, as I'll be only back at night. Cheers