From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sA9oD5teR2A3fwAA0tVLHw (envelope-from ) for ; Tue, 09 Mar 2021 11:40:11 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gG8eC5teR2DRCQAAB5/wlQ (envelope-from ) for ; Tue, 09 Mar 2021 11:40:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id EB8D4268FB for ; Tue, 9 Mar 2021 12:40:10 +0100 (CET) Received: from localhost ([::1]:54068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJaig-0007Fb-4g for larch@yhetil.org; Tue, 09 Mar 2021 06:40:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJaiY-0007FP-Dk for guix-patches@gnu.org; Tue, 09 Mar 2021 06:40:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34257) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJaiY-0004x8-5p for guix-patches@gnu.org; Tue, 09 Mar 2021 06:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJaiY-00089p-2e for guix-patches@gnu.org; Tue, 09 Mar 2021 06:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45889] Nextcloud Client (v16) Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Mar 2021 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45889 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan , 45889@debbugs.gnu.org Received: via spool by 45889-submit@debbugs.gnu.org id=B45889.161528994731271 (code B ref 45889); Tue, 09 Mar 2021 11:40:02 +0000 Received: (at 45889) by debbugs.gnu.org; 9 Mar 2021 11:39:07 +0000 Received: from localhost ([127.0.0.1]:45797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJahf-00088J-2M for submit@debbugs.gnu.org; Tue, 09 Mar 2021 06:39:07 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:12094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJahd-000889-AF for 45889@debbugs.gnu.org; Tue, 09 Mar 2021 06:39:06 -0500 Received: from nijino.local (217-149-164-20.nat.highway.telekom.at [217.149.164.20]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DvtX56697z1LBCm; Tue, 9 Mar 2021 12:39:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4DvtX56697z1LBCm DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1615289942; bh=O7H/2FCQCkBotxrm2WUETTROQhcyX6d/XGL8/66kjKo=; h=Subject:From:To:Date:In-Reply-To:References:From; b=ABTRcUjRPY+YC9gD/YU1H5VpseciVCRr2p5cWfrNium0lU48HYWfr5nypSlKdtg5d E1tioUdtxl0fvGb3nuWN5jk4Mlu/PbuQxxU/etyxdqHE6/L4qlhbyfi2KimOeovzbg przGGfEbA5u+T+/cRLRPnw6wjWp82vhBWTrKgKTs= Message-ID: From: Leo Prikler Date: Tue, 09 Mar 2021 12:39:01 +0100 In-Reply-To: References: <609483b4-c583-cbf0-4b2a-4daf6c4feb98@raghavgururajan.name> <67f2ff73-c6e0-743f-d873-0a488fa05e31@raghavgururajan.name> <29553b60ceb47530cd0bda7f84badb80b8daab74.camel@student.tugraz.at> <7d1a2db6-5da9-80f6-d160-128d2200935b@raghavgururajan.name> <1c216cbfd761c8ce77b2402cf9a88ad8772b2331.camel@student.tugraz.at> <15559ce0-8f6b-1ff7-e5d1-7c3f3f5292f9@raghavgururajan.name> <95a467cd-e1b8-9f68-588e-163a6105e891@raghavgururajan.name> <12599035-d671-b417-d70c-89d694f3ccd9@raghavgururajan.name> <31701971d849e72506ed4105c92b2ad85d3aa6be.camel@student.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx2.migadu.com; none X-Migadu-Queue-Id: EB8D4268FB X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: UuIaGeLsbVqt Hi Raghav, Mostly LGTM. Am Dienstag, den 09.03.2021, 05:50 -0500 schrieb Raghav Gururajan: > > Definitely deserves a comment and perhaps a less broad match? > > Done the comment. > > I think this is perfect match. The mentioned libraries will get > linked > wherever synclib gets linked. Also, this patch is compatible with > current master, which is different from this version. Perhaps the comment should reflect that a little better. You might also want to expand that during the unvendoring in the snippet, so that it's less confusing. > + `(("src" ,(string-append > "include/" solution) > + #:include-regexp ("\\.h$")) I think you should unvendor dependencies between the solutions, so that you can put them in "include/" directly (like putting the solutions in "/lib"). Regards, Leo