From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Raghav Gururajan <rg@raghavgururajan.name>, 45889@debbugs.gnu.org
Subject: [bug#45889] Nextcloud Client (v16)
Date: Tue, 09 Mar 2021 12:39:01 +0100 [thread overview]
Message-ID: <e888578e2a4f0b938040a6d6b6af611e32e72f37.camel@student.tugraz.at> (raw)
In-Reply-To: <f6b923c8-1f26-3d57-602e-83d9488a85e8@raghavgururajan.name>
Hi Raghav,
Mostly LGTM.
Am Dienstag, den 09.03.2021, 05:50 -0500 schrieb Raghav Gururajan:
> > Definitely deserves a comment and perhaps a less broad match?
>
> Done the comment.
>
> I think this is perfect match. The mentioned libraries will get
> linked
> wherever synclib gets linked. Also, this patch is compatible with
> current master, which is different from this version.
Perhaps the comment should reflect that a little better. You might
also want to expand that during the unvendoring in the snippet, so that
it's less confusing.
> + `(("src" ,(string-append
> "include/" solution)
> + #:include-regexp ("\\.h$"))
I think you should unvendor dependencies between the solutions, so that
you can put them in "include/" directly (like putting the solutions in
"/lib").
Regards,
Leo
next prev parent reply other threads:[~2021-03-09 11:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 10:09 [bug#45889] Nextcloud Desktop Raghav Gururajan
2021-01-16 6:40 ` [bug#45889] Nextcloud Desktop (v2) Raghav Gururajan
2021-01-16 8:33 ` [bug#45889] Nextcloud Desktop (v3) Raghav Gururajan
2021-01-16 10:09 ` [bug#45889] Nextcloud Desktop (v4) Raghav Gururajan
2021-01-16 10:48 ` Nicolò Balzarotti
2021-01-16 14:42 ` Raghav Gururajan
2021-01-16 14:34 ` [bug#45889] Nextcloud Desktop (v5) Raghav Gururajan
2021-01-17 14:44 ` [bug#45889] Nextcloud Client (v6) Raghav Gururajan
2021-01-24 18:45 ` david larsson
2021-02-01 15:07 ` Raghav Gururajan
2021-02-01 15:13 ` [bug#45889] Nextcloud Client (v7) Raghav Gururajan
2021-02-09 10:22 ` Leo Prikler
2021-02-13 20:36 ` [bug#45889] Nextcloud Client (v8) Raghav Gururajan
2021-02-13 21:47 ` Leo Prikler
2021-02-13 23:54 ` Raghav Gururajan
2021-02-14 0:47 ` [bug#45889] Nextcloud Client (v9) Raghav Gururajan
2021-02-14 10:53 ` [bug#45889] Nextcloud Client (v8) Leo Prikler
2021-02-18 20:23 ` [bug#45889] Nextcloud Client (v10) Raghav Gururajan via Guix-patches via
2021-02-18 22:26 ` Leo Prikler
2021-02-21 17:04 ` Raghav Gururajan via Guix-patches via
2021-02-21 17:45 ` Leo Prikler
2021-02-21 18:09 ` [bug#45889] Nextcloud Client (v11) Raghav Gururajan via Guix-patches via
2021-02-21 18:22 ` Leo Prikler
2021-02-21 18:50 ` [bug#45889] Nextcloud Client (v12) Raghav Gururajan via Guix-patches via
2021-02-21 19:37 ` Leo Prikler
2021-02-22 17:29 ` [bug#45889] Nextcloud Client (v13) Raghav Gururajan via Guix-patches via
2021-02-23 14:27 ` [bug#45889] Nextcloud Client (v14) Raghav Gururajan via Guix-patches via
2021-02-23 17:58 ` Leo Prikler
2021-03-09 6:00 ` [bug#45889] Nextcloud Client (v15) Raghav Gururajan via Guix-patches via
2021-03-09 7:03 ` Leo Prikler
2021-03-09 10:50 ` [bug#45889] Nextcloud Client (v16) Raghav Gururajan via Guix-patches via
2021-03-09 11:39 ` Leo Prikler [this message]
2021-03-09 12:29 ` Raghav Gururajan via Guix-patches via
2021-03-09 12:43 ` [bug#45889] Nextcloud Client (v17) Leo Prikler
2021-03-09 15:16 ` [bug#45889] Nextcloud Client (v18) Raghav Gururajan via Guix-patches via
2021-03-09 23:24 ` bug#45889: " Leo Prikler
2021-03-10 3:46 ` [bug#45889] " Raghav Gururajan via Guix-patches via
2021-03-11 6:45 ` Raghav Gururajan via Guix-patches via
2021-03-11 6:49 ` Leo Prikler
2021-03-11 7:44 ` Raghav Gururajan via Guix-patches via
2021-03-12 9:25 ` david larsson
2021-03-12 9:47 ` Raghav Gururajan via Guix-patches via
2021-02-21 18:22 ` [bug#45889] Nextcloud Client (v11) Raghav Gururajan via Guix-patches via
2021-02-09 12:53 ` [bug#45889] Nextcloud Client (v7) Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e888578e2a4f0b938040a6d6b6af611e32e72f37.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=45889@debbugs.gnu.org \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).