From: Adam Faiz via Guix-patches via <guix-patches@gnu.org>
To: Hilton Chain <hako@ultrarare.space>
Cc: 60250@debbugs.gnu.org
Subject: [bug#60250] [PATCH] gnu: Add bees.
Date: Fri, 23 Dec 2022 15:57:53 +0800 [thread overview]
Message-ID: <e86d8a06-0418-ebe5-3b63-288bb6b8de9d@disroot.org> (raw)
In-Reply-To: <875ye27i1p.wl-hako@ultrarare.space>
On 12/23/22 14:25, Hilton Chain wrote:
> Hi Adam,
>
> On Fri, 23 Dec 2022 02:52:38 +0800,
> Adam Faiz wrote:
>>
>> Hi,
>>
>> It appears that bees hasn't been built on a non-systemd distribution, because an optional feature
>> hard fails. This fixes it, the systemd unit files are installed conditionally anyways:
>>> (substitute* "Makefile"
>>> (("pkg-config systemd --variable=systemdsystemunitdir" all)
>>> (string-append all " || true")))
> Thank you for the snippet and explanation!
>
> I've made a pull request (of the beesd part) to the upstream:
> <https://github.com/Zygo/bees/pull/241>
>
> (And it's merged before I send the mail XDDD)
>
> However I'm not sure about the systemd part, could you explain more about which optional feature
> hard fails? And I get same binaries whether-ever this part is used.
I had a problem earlier, but I can't reproduce it now. You can remove
this one.
> As pkg-config is only used for systemd, and markdown for documentations that won't be installed,
> I'd rather remove them from native-inputs, WDYT?
I agree that it should be done, but it's a shame that there's no
install_docs rule in the Makefile. That should be a feature request/patch.
I already have a bees-remove-bundled-cityhash.patch and
bees-add-cityhash-to-install.md.patch to send upstream. Should I email
them to you?
next prev parent reply other threads:[~2022-12-23 7:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 8:19 [bug#60250] [PATCH] gnu: Add bees Hilton Chain via Guix-patches via
2022-12-22 18:52 ` Adam Faiz via Guix-patches via
2022-12-23 6:25 ` Hilton Chain via Guix-patches via
2022-12-23 6:35 ` [bug#60250] [PATCH v2] " Hilton Chain via Guix-patches via
2023-01-17 15:02 ` bug#60250: [PATCH] " Ludovic Courtès
2022-12-23 7:57 ` Adam Faiz via Guix-patches via [this message]
2022-12-24 11:34 ` [bug#60250] " Hilton Chain via Guix-patches via
2022-12-24 16:31 ` Adam Faiz via Guix-patches via
2022-12-22 19:22 ` Adam Faiz via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e86d8a06-0418-ebe5-3b63-288bb6b8de9d@disroot.org \
--to=guix-patches@gnu.org \
--cc=60250@debbugs.gnu.org \
--cc=adam.faiz@disroot.org \
--cc=hako@ultrarare.space \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).