unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ivan Vilata i Balaguer via Guix-patches via <guix-patches@gnu.org>
To: 73963@debbugs.gnu.org
Subject: [bug#73963] [PATCH] gnu: povray: Fix test run requiring interaction.
Date: Wed, 23 Oct 2024 14:00:30 +0200	[thread overview]
Message-ID: <e860d52e0b0cf62a3f4727ded93109676e47dc00.1729684454.git.ivan@selidor.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]

The test render required pressing a key after it was done, which caused the
package build to get stuck.  Also disable the render display window, which
did not cause issues but was pointless.

* gnu/packages/graphics.scm (povray)[args]: Patch test render not to pause nor
display a window.

Change-Id: Ia9527b3a67896972b399464b97dda464365d41ea
---
 gnu/packages/graphics.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index c12516383b..8d309cac33 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -37,6 +37,7 @@
 ;;; Copyright © 2023 David Thompson <dthompson2@worcester.edu>
 ;;; Copyright © 2023 Eric Bavier <bavier@posteo.net>
 ;;; Copyright © 2023, 2024 Artyom V. Poptsov <poptsov.artyom@gmail.com>
+;;; Copyright © 2024 Ivan Vilata-i-Balaguer <ivan@selidor.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1656,7 +1657,9 @@ (define-public povray
               (setenv "HOME" (getcwd))
               (with-directory-excursion "unix"
                 (substitute* "prebuild.sh"
-                  (("/bin/sh") (which "sh")))
+                  (("/bin/sh") (which "sh"))
+                  ;; Make test run non-interactive.
+                  (("biscuit.pov -f \\+d \\+p \\+v") "biscuit.pov -f +v"))
                 (invoke "sh" "prebuild.sh"))))
           ;; The bootstrap script is run by the prebuild script in the
           ;; "run-prebuild" phase.

base-commit: b8f8699a1f6e23fec46be7e086abde1270331ac9
-- 
2.46.0


-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2024-10-23 12:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 12:00 Ivan Vilata i Balaguer via Guix-patches via [this message]
2024-12-02 21:10 ` bug#73963: [PATCH] gnu: povray: Fix test run requiring interaction Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e860d52e0b0cf62a3f4727ded93109676e47dc00.1729684454.git.ivan@selidor.net \
    --to=guix-patches@gnu.org \
    --cc=73963@debbugs.gnu.org \
    --cc=ivan@selidor.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).