From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CCMIO5kNGmD2JgAA0tVLHw (envelope-from ) for ; Wed, 03 Feb 2021 02:42:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aLHcNpkNGmAzZwAA1q6Kng (envelope-from ) for ; Wed, 03 Feb 2021 02:42:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B4539403A6 for ; Wed, 3 Feb 2021 02:42:33 +0000 (UTC) Received: from localhost ([::1]:58278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l787k-00013q-6a for larch@yhetil.org; Tue, 02 Feb 2021 21:42:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l787F-00012q-TM for guix-patches@gnu.org; Tue, 02 Feb 2021 21:42:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53157) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l787F-0001Gk-MK for guix-patches@gnu.org; Tue, 02 Feb 2021 21:42:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l787F-00032y-Kr for guix-patches@gnu.org; Tue, 02 Feb 2021 21:42:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45954] Telegram-CLI (v7/v8) Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Feb 2021 02:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45954 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Leo Prikler , 45954@debbugs.gnu.org Received: via spool by 45954-submit@debbugs.gnu.org id=B45954.161232008711670 (code B ref 45954); Wed, 03 Feb 2021 02:42:01 +0000 Received: (at 45954) by debbugs.gnu.org; 3 Feb 2021 02:41:27 +0000 Received: from localhost ([127.0.0.1]:36470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l786h-00032A-91 for submit@debbugs.gnu.org; Tue, 02 Feb 2021 21:41:27 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:37849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l786e-00031v-NH for 45954@debbugs.gnu.org; Tue, 02 Feb 2021 21:41:25 -0500 X-Originating-IP: 76.68.120.100 Received: from [192.168.5.10] (bras-vprn-toroon474rw-lp130-08-76-68-120-100.dsl.bell.ca [76.68.120.100]) (Authenticated sender: rg@raghavgururajan.name) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id AED3C20003; Wed, 3 Feb 2021 02:41:16 +0000 (UTC) References: <515542411e38fa921ef936fe116bd3e0fb2a44d1.camel@student.tugraz.at> <596596fa-35d4-a7db-d890-153f51728780@raghavgururajan.name> From: Raghav Gururajan Message-ID: Date: Tue, 2 Feb 2021 21:41:14 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KqY2bthp4SyfLloI8SpNA1zJ1iDEO98s9" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.46 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5B4539403A6 X-Spam-Score: -4.46 X-Migadu-Scanner: scn1.migadu.com X-TUID: HeSTcmnA/AAG This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KqY2bthp4SyfLloI8SpNA1zJ1iDEO98s9 Content-Type: multipart/mixed; boundary="pnZAm4p5OAeuxTOO4Tyt5rGSEqibVJApf"; protected-headers="v1" From: Raghav Gururajan To: Leo Prikler , 45954@debbugs.gnu.org Cc: Jonathan Brielmaier Message-ID: Subject: Re: Telegram-CLI (v7/v8) References: <515542411e38fa921ef936fe116bd3e0fb2a44d1.camel@student.tugraz.at> <596596fa-35d4-a7db-d890-153f51728780@raghavgururajan.name> In-Reply-To: --pnZAm4p5OAeuxTOO4Tyt5rGSEqibVJApf Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Leo! > Anything particularly worth noting? Not sure. But based on commit messages, it seems lot of bug fixes. >>> Please stop trying to use this as a snippet to mean "the root of >>> the >>> source and build directory". It is extremely obscure and people >>> are >>> already using "../source" just fine. (Just do an rgrep if you >>> aren't >>> convinced.) >> >> Fixed in v8. > "Fixed". While it is true, that you're no longer using getenv, binding= > source for string-append later on is not a particularly elegant > solution either. >=20 >>>> Hmm. I tried but couldn't come up with a way to do it like that. >>>> :( >>> You can still try harder for v8 ;) >> >> I tried different ways but the arguments key-words between gnu and >> copy >> differ a lot. I am unable use key-words from both build systems at >> the >> same time. Like using #:configure-flags (from gnu) and #:install >> (from >> copy). > Use something along the lines of > (replace 'install > (lambda args > (apply (assoc-ref copy:%standard-phases 'install) > #:install-plan > args))) > Phases should be written in a way, that gratuitous arguments will not > be read, but passing it in arguments through the package-arguments > fields remains tricky. Though even if it were possible, the snippet > above has better locality. >=20 >> Also, I spent significant amount time to come up the phase I have. So >> if >> there are no critical issues, I would like to keep it as-is. :-) > I personally regard readability as a severe issue in this case. Of > course there would be ways of doing this without invoking copy-build- > system, but in my personal opinion an install plan would likely be the > most concise here. >=20 > For instance instead of using string-append source everywhere, you > could just use a directory excursion. But more importantly, why is it,= > that all of the stuff you're installing is located in the source > directory? Do you even build anything that ends up in the > installation? Would it make more sense to have #:out-of-source? #f? >=20 > In tgl, you use several directory excursions when arguably only one > would be needed. Try to simplify your install process, so that you > need to bind as few variables as possible. Agreed. I have updated the pack-def in v9. :-) Regards, RG. --pnZAm4p5OAeuxTOO4Tyt5rGSEqibVJApf-- --KqY2bthp4SyfLloI8SpNA1zJ1iDEO98s9 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTNLV6qqYzLN9qR1rBfWBZkf4vlUQUCYBoNSgUDAAAAAAAKCRBfWBZkf4vlUYes AP9HXvPRgcA75CZmLIl2cp+5pvtX1xFhip97TTbD8VQgyQEAwNAmyfBSLp+3kJeB/hYGPQEGWxZ4 gr5fuBDOsha5JwI= =Y71/ -----END PGP SIGNATURE----- --KqY2bthp4SyfLloI8SpNA1zJ1iDEO98s9--