From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:38655) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLovo-0006rF-TO for guix-patches@gnu.org; Sat, 19 Oct 2019 09:38:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLovk-00052F-Vi for guix-patches@gnu.org; Sat, 19 Oct 2019 09:38:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43293) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLovi-00050O-Gt for guix-patches@gnu.org; Sat, 19 Oct 2019 09:38:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iLovi-0005xo-Cx for guix-patches@gnu.org; Sat, 19 Oct 2019 09:38:02 -0400 Subject: [bug#37793] [PATCH] gnu: Add gens-gs. References: <20191017144238.23959-1-mail@ambrevar.xyz> In-Reply-To: <20191017144238.23959-1-mail@ambrevar.xyz> Resent-Message-ID: Mime-Version: 1.0 Message-Id: Date: Sat, 19 Oct 2019 06:36:50 -0700 From: "David Wilson" Content-Type: multipart/mixed; boundary=3364727baf11468fbd901d86fa95bf10 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 37793@debbugs.gnu.org --3364727baf11468fbd901d86fa95bf10 Content-Type: text/plain Hi all! I was able to get the gens-gs build working with the attached patch on top of Pierre's original. Tested the output by loading up a "Chakan: The Forever Man" ROM, seemed to work fine :) The key was this line of the Nix package definition: https://github.com/NixOS/nixpkgs/blob/master/pkgs/misc/emulators/gens-gs/default.nix#L16 Apparently gens-gs' code is so old that it's using some deprecated GTK APIs, so we have to remove the GTK_DISABLE_DEPRECATED define, etc, from GTK_CFLAGS so that the build will complete successfully. David --3364727baf11468fbd901d86fa95bf10 Content-Disposition: attachment;filename="gens-fix.patch" Content-Type: text/x-patch; name="gens-fix.patch" Content-Transfer-Encoding: BASE64 ZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9lbXVsYXRvcnMuc2NtIGIvZ251L3BhY2thZ2Vz L2VtdWxhdG9ycy5zY20KaW5kZXggYzFkMWQ1NDA1Mi4uZDYxNmY3ZmQyMSAxMDA2NDQKLS0t IGEvZ251L3BhY2thZ2VzL2VtdWxhdG9ycy5zY20KKysrIGIvZ251L3BhY2thZ2VzL2VtdWxh dG9ycy5zY20KQEAgLTgyLDYgKzgyLDcgQEAKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgeG9yZykKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgd2ViKQogICAjOnVzZS1t b2R1bGUgKGd1aXggYnVpbGQtc3lzdGVtIGNtYWtlKQorICAjOnVzZS1tb2R1bGUgKGd1aXgg YnVpbGQtc3lzdGVtIGdsaWItb3ItZ3RrKQogICAjOnVzZS1tb2R1bGUgKGd1aXggYnVpbGQt c3lzdGVtIGdudSkpCiAKIChkZWZpbmUtcHVibGljIGRlc211bWUKQEAgLTEzNzksOSArMTM4 MCwxOCBAQCBmdW5jdGlvbnMuICBUaGUgc291cmNlIGNvZGUgdG8gTUFNRSBzZXJ2ZXMgYXMg dGhpcyBkb2N1bWVudGF0aW9uLiIpCiAgICAgICAgKHNoYTI1NgogICAgICAgICAoYmFzZTMy CiAgICAgICAgICAiMWhhNXM2ZDN5N3M5YXE5ZjR6bW45cDg4MTA5YzNtcmozNnoydzY4amhp dzV4cnh3czgzMyIpKSkpCi0gICAgKGJ1aWxkLXN5c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQor ICAgIChidWlsZC1zeXN0ZW0gZ2xpYi1vci1ndGstYnVpbGQtc3lzdGVtKQorICAgIChzdXBw b3J0ZWQtc3lzdGVtcyAnKCJpNjg2LWxpbnV4IiAieDg2XzY0LWxpbnV4IikpCiAgICAgKGFy Z3VtZW50cwotICAgICBgKCM6c3lzdGVtICJpNjg2LWxpbnV4IikpCisgICAgIGAoIzpzeXN0 ZW0gImk2ODYtbGludXgiCisgICAgICAgIzpwaGFzZXMKKyAgICAgICAobW9kaWZ5LXBoYXNl cyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAoYWRkLWFmdGVyICd1bnBhY2sgJ2ZpeC1D RkxBR1MKKyAgICAgICAgICAgKGxhbWJkYSogXworICAgICAgICAgICAgIDs7IFJlbW92ZSBH VEsgQVBJIGRlcHJlY2F0aW9uIGZsYWdzIHRoYXQgY2F1c2UgYnVpbGQgZXJyb3JzCisgICAg ICAgICAgICAgKHN1YnN0aXR1dGUqICJjb25maWd1cmUiCisgICAgICAgICAgICAgICAoKCJH VEtfQ0ZMQUdTPVwiXFwkR1RLX0NGTEFHUyAuKlwiIikgIiIpKQorICAgICAgICAgICAgICN0 KSkpKSkKICAgICAobmF0aXZlLWlucHV0cwogICAgICBgKCgicGtnLWNvbmZpZyIgLHBrZy1j b25maWcpCiAgICAgICAgKCJuYXNtIiAsbmFzbSkpKQo= --3364727baf11468fbd901d86fa95bf10--