From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gBAZCycQTWNncwAAbAwnHQ (envelope-from ) for ; Mon, 17 Oct 2022 10:19:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MNUxCicQTWMOFQAAG6o9tA (envelope-from ) for ; Mon, 17 Oct 2022 10:19:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CFA943CD5B for ; Mon, 17 Oct 2022 10:19:50 +0200 (CEST) Received: from localhost ([::1]:42778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okLLh-0006zr-ST for larch@yhetil.org; Mon, 17 Oct 2022 04:19:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okLL0-0006wt-U6 for guix-patches@gnu.org; Mon, 17 Oct 2022 04:19:13 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48094) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okLKw-0000ZB-HG for guix-patches@gnu.org; Mon, 17 Oct 2022 04:19:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1okLKw-0003rc-CL for guix-patches@gnu.org; Mon, 17 Oct 2022 04:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58569] [PATCH] gnu packages gnome-console: Remove nautilus extension Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 17 Oct 2022 08:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58569 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?M=C3=A1ja_?= =?UTF-8?Q?Tom=C3=A1=C5=A1ek?= , 58569@debbugs.gnu.org Received: via spool by 58569-submit@debbugs.gnu.org id=B58569.166599469714785 (code B ref 58569); Mon, 17 Oct 2022 08:19:02 +0000 Received: (at 58569) by debbugs.gnu.org; 17 Oct 2022 08:18:17 +0000 Received: from localhost ([127.0.0.1]:47172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okLKC-0003qP-NR for submit@debbugs.gnu.org; Mon, 17 Oct 2022 04:18:16 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:50165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okLKA-0003q9-Ap for 58569@debbugs.gnu.org; Mon, 17 Oct 2022 04:18:15 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4MrVHP4Dfmz3wVf; Mon, 17 Oct 2022 10:18:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1665994689; bh=tiuE8RaVrFxpTl0UQQg6ou9/K4JI4vPNvQQc/N5CwJg=; h=Subject:From:To:Date:In-Reply-To:References; b=NRLk/OLq2NOwfNwg7yiWNtzqyQkhq5Xql+gASHMUSvhvshrYQKfLKHruDX/iQRO2J doE3pLHRONGM66zYjd4ra3sT66mv/qbx7fJmGKI400kxuOsH5I5nGviUYoy/EMvMwg h91YsMYYjFSD9dBS2+VE69bZzbpNP7d5ygg0KNNA= Message-ID: From: Liliana Marie Prikler Date: Mon, 17 Oct 2022 10:18:08 +0200 In-Reply-To: <87sfjnad0i.fsf@disroot.org> References: <87sfjnad0i.fsf@disroot.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665994790; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tiuE8RaVrFxpTl0UQQg6ou9/K4JI4vPNvQQc/N5CwJg=; b=FJxh1V5Nnt4859cgh+WqGcIroDxe0+bi33T1TxyzBkS4lagnyKK4jEFThiSOs0w2kgRdUa gtXYgwfEjp/saDJoCOqV93H/06WhlxRJ7GGioZtvlws4xtmiBmXP99yQ5uMOMFlu+OtTg1 eh6oLnhHvAdq7+Fs5B9ukmKGJZCdpiNmfMalHJajx6Qz2CQc4/kGzKPe2ltd6dk6ePJLhY p6LtZQL17axBnZ8TkOqH/VCgcF/pc8owVjBYFsFoZj89EhLnj5TVevtvEy2dxzexCjhh8x bqNhXe7hHIdQ6wB3W2+ioRwY5a6G+wdqe0b3v223/UT80jmD/QVvTplY1Md4zw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665994790; a=rsa-sha256; cv=none; b=PrhmLcmxIS1yRkyRO+cZSzMUcfuxT+L4upQ6cXi6jSe7EAdaKB/1SptZmJJCbX1D9JRDAc BNGb2gKTNGdBn9s9qIYotP8+7kUHk1cTJMaAKQtKG4vEkiTRDfYYNq7L0vFbprt5F1arxR QGymLIwkC7aOFjzsukO6JeNuXUFFb/7Oy25xARvwzWrabQQBVC6oOoMCNNdf0wNUVgoVd9 K8VUnMGDMzBxeq/rI6IOJqg4J1jsoxz/H3BKRd5b6MBCYQXmmZkiddlauZhZOwQteHYKSE c5DNsAdJU6uHYmiJzEUJp7KrgQoa75IbMQR+sIYFO3BiHiR/suG0xgrJ6RKvcg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="NRLk/OLq"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.78 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="NRLk/OLq"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CFA943CD5B X-Spam-Score: 4.78 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4/47adO/bn4m Am Sonntag, dem 16.10.2022 um 19:34 +0200 schrieb M=C3=A1ja Tom=C3=A1=C5=A1= ek: >=20 > Hi, >=20 > this patch removes the gnome-console nautilus extension as it crashes > nautilus (at least on my machine). I can confirm it working as intended on at least two separate machines, both configured=20 > In my opinion it is safe to remove it, as this > feature is implemented directly into nautilus-43 and the original > code is purged from the gnome-console repo. (see > https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/911=C2=A0and > https://gitlab.gnome.org/GNOME/console/-/commit/c4bd2312f4b432a33810a8dcd= f3cadabae5169d7 > ) >=20 > This sadly means, that in nautilus-42 there will be no "Open in > Console", but the issue is on some code that is already deprecated in > the Console repo. (I have studied gdb info and it appears that > kgx_nautilus_get_background_items() returns a GList* that is { .next > =3D NULL, .prev =3D NULL, .data =3D NULL } but nautilus does only perform= a > check that GList* is NULL, otherwise it expects a valid list) >=20 > I can maybe supply a patch to gnome-console, but I don't see a reason > to. In my opinion, it'd be better to find out why it crashes in the first place. See [1] for the breaking code. My suspicion is that item ends up NULL, which would be big if true. Cheers [1] https://gitlab.gnome.org/GNOME/console/-/blob/42.2/nautilus/kgx-nautilus.c#= L48