unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: la snesne <lasnesne@lagunposprasihopre.org>, 47333@debbugs.gnu.org
Subject: [bug#47333] [PATCH 2/2] Enable test of minetest
Date: Tue, 23 Mar 2021 08:31:36 +0100	[thread overview]
Message-ID: <e65eaefaadc42490202fe74c2a185d9c9599ff23.camel@telenet.be> (raw)
In-Reply-To: <20210323000634.2337-2-lasnesne@lagunposprasihopre.org>

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

On Tue, 2021-03-23 at 09:06 +0900, la snesne wrote:
> -       #:tests? #f))                    ;no check target
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _
> +             (setenv "HOME" "/tmp")
> +             (invoke (string-append "../" ,name "-" ,version
> +                                    "-checkout/bin/minetest")
> +                     "--run-unittests")
> +             #t)))))

For most packages, this is unlikely to work when cross-compiling.
I suggest replacing it with something like

> +           (unless ,(%current-target-system)
> +             (invoke (string-append "../" ,name "-" ,version
> +                                    "-checkout/bin/minetest")
> +                     "--run-unittests"))
> +           #t

Well, cross-compiling minetest won't work anyway as a dependency is not
cross-compilable:

$ guix build minetest --target=aarch64-linux-gnu
$ guix build: error: gnu/packages/gl.scm:236:2: mesa@20.2.4: build system `meson' does not support cross builds

(and I see little reason to cross-compilable minetest)
... but it still seems a good idea to avoid introducing new
cross-compilation issues when we can avoid it.

Greetings,
Maxime

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2021-03-23  7:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  0:06 [bug#47332] [PATCH 1/2] Update minetest and minetest-data to 5.4.0 la snesne
2021-03-23  0:06 ` [bug#47333] [PATCH 2/2] Enable test of minetest la snesne
2021-03-23  0:22   ` bug#47333: oops la snesne
2021-03-23  7:31   ` Maxime Devos [this message]
2021-03-23  0:28 ` [bug#47332] [PATCH 2/2] Enable test of minetest la snesne
2021-03-23 10:53   ` bug#47332: " Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e65eaefaadc42490202fe74c2a185d9c9599ff23.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=47333@debbugs.gnu.org \
    --cc=lasnesne@lagunposprasihopre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).