From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ME1ZFfiFYWKvKgEAbAwnHQ (envelope-from ) for ; Thu, 21 Apr 2022 18:27:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uJZQFfiFYWImUgAAauVa8A (envelope-from ) for ; Thu, 21 Apr 2022 18:27:36 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB1CB32D5E for ; Thu, 21 Apr 2022 18:27:35 +0200 (CEST) Received: from localhost ([::1]:51710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhZeY-0004ow-A5 for larch@yhetil.org; Thu, 21 Apr 2022 12:27:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhYcA-0003mw-TF for guix-patches@gnu.org; Thu, 21 Apr 2022 11:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhYcA-0006w8-Je for guix-patches@gnu.org; Thu, 21 Apr 2022 11:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nhYcA-0000sG-G8 for guix-patches@gnu.org; Thu, 21 Apr 2022 11:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53389] [PATCH v2 0/25] Replace some mocking with with-http-server*, avoid harcoding ports. References: <6b1c1d98514b2547907a81a04c1241d9b865d6fa.camel@telenet.be> In-Reply-To: <6b1c1d98514b2547907a81a04c1241d9b865d6fa.camel@telenet.be> Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 21 Apr 2022 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53389 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53389@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 53389-submit@debbugs.gnu.org id=B53389.16505544353291 (code B ref 53389); Thu, 21 Apr 2022 15:21:02 +0000 Received: (at 53389) by debbugs.gnu.org; 21 Apr 2022 15:20:35 +0000 Received: from localhost ([127.0.0.1]:50765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhYbj-0000r0-Bg for submit@debbugs.gnu.org; Thu, 21 Apr 2022 11:20:35 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:44258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhYbh-0000qq-03 for 53389@debbugs.gnu.org; Thu, 21 Apr 2022 11:20:33 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id MTLX2700A4UW6Th06TLXNU; Thu, 21 Apr 2022 17:20:31 +0200 Message-ID: From: Maxime Devos Date: Thu, 21 Apr 2022 17:20:25 +0200 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-nb+0Zunks4Cjo5g6uyF1" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1650554431; bh=wY9gepbTO+Jlj519E1HglWq3hDubICsvh/GOdqwwZa0=; h=Subject:From:To:Cc:Date; b=SH/yhPz0Bx9iiOLlCHxHTVVCbsfmHQ3gyXcsVCCFvCYEhwwIh5Mws7mvx8eolIEl1 PRm5xx5qIYtmATf+R7+0/QNPFY6y0/56WW7yAU/7nHeAU9IT41t5bQ4gSNwMHpPrik z1/Fvbbyg8ZrWGajVdZgLNpQRVlxRwGaplIZZ2pKYxCDBiiqq9rpqROgdFfSKcIS3b vyqdIjeDtExd/WsNoHHN4lQDkEpKvrBJBFcBXJ6NzEzGYxpV/FP0n9EnBWMfIaX4OP 15yb2S1ZcDeA+L0lXoVf4sxUXEYuvVSpzp35PmohpOKBbauiPDeaMO8NK9FXn2ZW9s jK+LRCk2z3hTQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650558456; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=wY9gepbTO+Jlj519E1HglWq3hDubICsvh/GOdqwwZa0=; b=OL5lgshQp7njRxUICTbaIKqb3LzFyC7OT/jBy8GxWxoKuNbtLfgm4qAh5moc4kmhp/z/Xf vXnbKu15vNsRJMuIYv/IOfiV6tZhavwk79IBN2YzrrQTC5/oJGXx8aGPMgiP9575DmIpp8 q17QjMx35sg0gAwqH24aKq+ERLKEaFC1YdVBVJs14rfitYtLDqKYBLR1OcNAT6C9D/4YzE 5kSU/9XOeSQm9eq8nsTcDeTrQYEl+9LuPGLZyGTxq5LSlmjEBIlCGZJUbmeEEpSFvVMZok fIgljUsY2u3GDSAiVVO27m+RwzQnEUzZ25zZ7HnE+f2LVj3ClllIOhbE8t9J4w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650558456; a=rsa-sha256; cv=none; b=b7ecHjas3O6TTpXFIiGmkXJ9hBptR/XvQbSFnK4TluJLIbnF1q6WK6EpPctuJTk4pIm6B6 oY615/ycJhivYt6Qnwq7bWJ3OzQ/w7ruTlXu5vyvxW0kF2BesKym5icOc8z5u4SSDgzyu2 D9ac6Ik9sU0F536gdNUDXt/6skC8V0cJjSci1krMiXarPbtbh/bNguaaqhxdzjOCi/K/zA i+Gj5P1Z42SSziNf4GxPNGEs4Gwk9XEuXjEl5Snx9/tEpztsemJA3RdUQVS5h6f0cV2bvw b7pB4tDArtyonVxwMAWUw95J8jYSVbOoAOeTMQeGnDH24jRiT20vukBdv4wE0g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="SH/yhPz0"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="SH/yhPz0"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DB1CB32D5E X-Spam-Score: 2.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: uV1isRu4P2sm --=-nb+0Zunks4Cjo5g6uyF1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Changes since the v1: * Simplification: keep-lingering? has been removed. For tests/challenge, I have taken the proposed with-http-server*, renamed it to with-http-server/monadic to avoid confusion and removed its hardcoding of ports. * Simplification:=C2=A0the semantics of with-http-server*/with-http-server are now a bit simpler: it _always_ chooses a fresh port, regardless of whether %http-server-port was already set. * Simplification: %local-url and %local-url* have=C2=A0been unified to a single one-optional-argument procedure. * Simplification: no tests use %http-server-port anymore. Instead, they directly use %local-url. =20 * YMMV: %http-server-port is now a lexical variable instead of a dynamic parameter, using syntax parameters. * The =E2=80=98home-page: Connection refused=E2=80=99 test does not hardco= de 9999 anymore. Instead, 'with-unreachable-http-server' binds a fresh port (claiming it) but does not listen to it (causing connections to be refused). * Simplification: with-http-server only supports a single form now: a list of (uri response-code response) triples. The URI must now always be set! Existing tests have been adjusted appropriately. What would be preferred: * The 2827e9f8a5834be65f8709a595ec2d870fd39271 commit from https://notabug= .org/maximed/scheme-gnunet/ (https://notabug.org/maximed/guix-gnunet/commit/2827e9f8a5834be65f8709a5= 95ec2d870fd39271) * or a bunch of v2 mails sent with "git send-email? Greetings, Maxime. --=-nb+0Zunks4Cjo5g6uyF1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmF2ORccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7uhUAP4uFHWZLEsKMI+YJArIBYUVWxU1 AsHIZzv9Nov1CefqzAD+OD/f4UKiI2aCnyp/JZ69WYyoCV8KpCT1HLZCageM4gM= =cjah -----END PGP SIGNATURE----- --=-nb+0Zunks4Cjo5g6uyF1--