From: Maxime Devos <maximedevos@telenet.be>
To: Attila Lendvai <attila@lendvai.name>, 50217@debbugs.gnu.org
Subject: [bug#50217] [PATCH v4] gnu: Add c2ffi.
Date: Mon, 14 Feb 2022 16:34:14 +0100 [thread overview]
Message-ID: <e5e6361ba4ee0c936c243541886af75b17912b56.camel@telenet.be> (raw)
In-Reply-To: <20220214123112.20135-1-attila@lendvai.name>
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
Attila Lendvai schreef op ma 14-02-2022 om 13:31 [+0100]:
> + (let ((git-tag "12.0.0.0"))
> + (package
> + (name "c2ffi")
> + (home-page "https://github.com/rpav/c2ffi")
> + (version (string-append "v" git-tag))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url home-page)
> + (commit version)))
Isn't it the other way around? Looking at the git repo, the git tag is
v12.0.0.0, not 12.0.0.0, and Guix strips version prefixes like "v", "V"
and "version-". Also, IIUC, the current consensus is that home pages
and source git repos are separate things, even if sometimes their URL
coincides, so the URL may need to be copied into the 'url' field.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-02-14 15:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 21:07 [bug#50217] [PATCH] gnu: Add c2ffi-11.0.0 muradm
2021-08-27 0:12 ` [bug#50217] [PATCH v2] " muradm
2021-09-07 14:06 ` [bug#50217] [PATCH] " Ludovic Courtès
2021-10-25 15:14 ` [bug#50217] [PATCH v2] gnu: Add c2ffi Attila Lendvai
2022-01-12 17:13 ` [bug#50217] [PATCH v3] " Attila Lendvai
2022-02-14 12:31 ` [bug#50217] [PATCH v4] " Attila Lendvai
2022-02-14 15:30 ` Maxime Devos
2022-02-14 15:34 ` Maxime Devos [this message]
2022-02-14 15:41 ` Maxime Devos
2022-02-15 18:43 ` [bug#50217] [PATCH v5] " Attila Lendvai
2022-02-15 19:51 ` [bug#50217] [PATCH v6] " Attila Lendvai
2022-03-01 9:17 ` [bug#50217] [PATCH v7] " Attila Lendvai
2022-03-01 9:21 ` [bug#50217] [PATCH v8] " Attila Lendvai
2022-03-03 18:36 ` [bug#50217] [PATCH v9] " Attila Lendvai
2022-03-03 20:34 ` bug#50217: " Guillaume Le Vaillant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5e6361ba4ee0c936c243541886af75b17912b56.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=50217@debbugs.gnu.org \
--cc=attila@lendvai.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).