From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 73216@debbugs.gnu.org,
"Katherine Cox-Buday" <cox.katherine.e+guix@gmail.com>,
"Ludovic Courtès" <ludo@gnu.org>,
"Andrew Tropin" <andrew@trop.in>
Subject: [bug#73216] [PATCH 1/2] gnu: Add emacs-org-texlive-collection.
Date: Fri, 13 Sep 2024 16:30:08 +0200 [thread overview]
Message-ID: <e5be39c86f8026baeb4437f3f179326b95486e0c.camel@gmail.com> (raw)
In-Reply-To: <87bk0ry6y2.fsf@gmail.com>
Am Freitag, dem 13.09.2024 um 23:16 +0900 schrieb Maxim Cournoyer:
> Hi Liliana,
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
> [...]
>
> > > +(define-public emacs-org-texlive-collection
> > > + (package
> > > + (inherit emacs-org)
> > > + (name "emacs-org-texlive-collection")
> > > + (source #f)
> > > + (build-system trivial-build-system)
> > > + (arguments (list #:builder #~(mkdir #$output)))
> > > + (native-inputs '())
> > > + (inputs '())
> > > + (propagated-inputs
> > > + (list texlive-amsmath
> > > + texlive-capt-of
> > > + texlive-graphics ;for graphicx, rotating
> > > + texlive-hyperref
> > > + texlive-titling
> > > + texlive-tools ;for longtable
> > > + texlive-ulem
> > > + texlive-wrapfig
> > > + texlive-scheme-small)) ;for amsfonts, fontspec,
> > > inputenc, etc.
> > Nitpick: these comments are not aligned.
>
> This is actually how Emacs aligns them automatically, which I tend to
> stick to to avoid noise in diffs.
You might want to press M-; on that last one – I don't think it's
aligned as per Emacs.
> > As a personal thing, I also suggest using a space between ; and
> > for, but I see both styles used in Guix.
>
> A space following ';' for inline comments is actually what seems to
> be our adopted convention (see "Riastradh's Lisp Style Rules",
> https://mumble.net/~campbell/scheme/style.txt referenced from (info
> '(guix) Formatting Code')).
>
> I must have dreamt Ludo suggestion to drop the space at some point in
> the distant past. I'll try to go back to '; comment' in my code, I
> guess!
Oh, good to know!
Cheers
next prev parent reply other threads:[~2024-09-13 14:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 2:23 [bug#73216] [PATCH 1/2] gnu: Add emacs-org-texlive-collection Maxim Cournoyer
2024-09-13 2:29 ` [bug#73216] [PATCH 2/2] gnu: emacs-org: Mention the emacs-org-texlive-collection in description Maxim Cournoyer
2024-09-13 6:26 ` Liliana Marie Prikler
2024-09-13 16:08 ` bug#73216: " Maxim Cournoyer
2024-09-13 17:02 ` [bug#73216] " Nicolas Goaziou via Guix-patches via
2024-09-13 6:26 ` [bug#73216] [PATCH 1/2] gnu: Add emacs-org-texlive-collection Liliana Marie Prikler
2024-09-13 14:16 ` Maxim Cournoyer
2024-09-13 14:30 ` Liliana Marie Prikler [this message]
2024-09-13 14:28 ` Maxim Cournoyer
2024-09-13 14:42 ` Liliana Marie Prikler
2024-09-13 17:00 ` Nicolas Goaziou via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5be39c86f8026baeb4437f3f179326b95486e0c.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=73216@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=cox.katherine.e+guix@gmail.com \
--cc=ludo@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).