unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Brandon Lucas <br@ndon.dk>, 53456@debbugs.gnu.org
Subject: [bug#53456] [PATCH] gnu: Add fnlfmt.
Date: Sat, 22 Jan 2022 22:39:54 +0100	[thread overview]
Message-ID: <e544e9bbab3302a531536a87642786a9caefa7cc.camel@telenet.be> (raw)
In-Reply-To: <20220122212723.396566-1-br@ndon.dk>

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

Brandon Lucas schreef op za 22-01-2022 om 21:28 [+0000]:
> +           ;; Use input fennel instead of bundled fennel.
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* "Makefile"
> +               (("./fennel") (search-input-file inputs "/bin/fennel")))))

'fennel' is in native-inputs, not inputs.  For historical reasons,
the 'inputs' in the phase contains both the native-inputs and native-
inputs in the phase is #false when compiling natively, which can be
confusing (maybe that can be addressed someday).

I suggest:

   (lambda* (#:key native-inputs inputs #:allow-other-keys)
     (substitute* "Makefile"
       (("./fennel")
        (search-input-file (or native-inputs inputs) "/bin/fennel")))))

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2022-01-22 21:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-22 21:28 [bug#53456] [PATCH] gnu: Add fnlfmt Brandon Lucas
2022-01-22 21:33 ` Maxime Devos
2022-01-22 21:39 ` Maxime Devos [this message]
2022-01-22 21:41 ` Maxime Devos
2022-01-22 21:43 ` Maxime Devos
2022-01-22 21:46 ` Maxime Devos
2022-01-22 21:53 ` Maxime Devos
2022-01-23 20:50   ` Brandon
2022-01-23  0:16 ` [bug#53456] [PATCH v2 1/2] " Brandon Lucas
2022-01-23  0:19   ` [bug#53456] [PATCH v2 2/2] gnu: fennel: Update to 03c1c95 Brandon Lucas
2022-01-23 11:05   ` [bug#53456] [PATCH v2 1/2] gnu: Add fnlfmt Maxime Devos
2022-01-23 11:11   ` Maxime Devos
2022-01-23 12:14 ` [bug#53456] [PATCH v3 " Brandon Lucas
2022-01-23 12:14   ` [bug#53456] [PATCH v3 2/2] gnu: fennel: Update to 03c1c95 Brandon Lucas
2022-01-26 15:52   ` bug#53456: [PATCH] gnu: Add fnlfmt Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e544e9bbab3302a531536a87642786a9caefa7cc.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=53456@debbugs.gnu.org \
    --cc=br@ndon.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).