unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#56139] [PATCH 0/4] Make window managers use libinput-minimal instead of libinput
@ 2022-06-22 12:14 Josselin Poiret via Guix-patches via
  2022-06-22 12:17 ` [bug#56139] [PATCH 1/4] gnu: wlroots: Replace input libinput by libinput-minimal Josselin Poiret via Guix-patches via
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2022-06-22 12:14 UTC (permalink / raw)
  To: 56139; +Cc: Josselin Poiret

This reduces their total closure, since libinput pulls in gtk+ which
adds roughly 400MiB.

Josselin Poiret (4):
  gnu: wlroots: Replace input libinput by libinput-minimal.
  gnu: sway: Replace input libinput by libinput-minimal.
  gnu: waybar: Replace input libinput by libinput-minimal.
  gnu: hikari: Replace input libinput by libinput-minimal.

 gnu/packages/wm.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


base-commit: e74fa406e1043547242a8b67ab9907fea7aae6b9
-- 
2.36.1





^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#56139] [PATCH 1/4] gnu: wlroots: Replace input libinput by libinput-minimal.
  2022-06-22 12:14 [bug#56139] [PATCH 0/4] Make window managers use libinput-minimal instead of libinput Josselin Poiret via Guix-patches via
@ 2022-06-22 12:17 ` Josselin Poiret via Guix-patches via
  2022-06-22 12:17 ` [bug#56139] [PATCH 2/4] gnu: sway: " Josselin Poiret via Guix-patches via
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2022-06-22 12:17 UTC (permalink / raw)
  To: 56139; +Cc: Josselin Poiret

* gnu/packages/wm.scm (wlroots)[propagated-inputs]: Replace libinput
by libinput-minimal to reduce closure.
---
 gnu/packages/wm.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index ecc79f73b9..fb5a6bc5b3 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1538,7 +1538,7 @@ (define-public wlroots
     (propagated-inputs
      (list ;; As required by wlroots.pc.
            eudev
-           libinput
+           libinput-minimal
            libxkbcommon
            mesa
            pixman
-- 
2.36.1





^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#56139] [PATCH 2/4] gnu: sway: Replace input libinput by libinput-minimal.
  2022-06-22 12:14 [bug#56139] [PATCH 0/4] Make window managers use libinput-minimal instead of libinput Josselin Poiret via Guix-patches via
  2022-06-22 12:17 ` [bug#56139] [PATCH 1/4] gnu: wlroots: Replace input libinput by libinput-minimal Josselin Poiret via Guix-patches via
@ 2022-06-22 12:17 ` Josselin Poiret via Guix-patches via
  2022-06-22 12:17 ` [bug#56139] [PATCH 3/4] gnu: waybar: " Josselin Poiret via Guix-patches via
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2022-06-22 12:17 UTC (permalink / raw)
  To: 56139; +Cc: Josselin Poiret

* gnu/packages/wm.scm (sway)[propagated-inputs]: Replace libinput
by libinput-minimal to reduce closure.
---
 gnu/packages/wm.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index fb5a6bc5b3..3fd4ed6ca4 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1592,7 +1592,7 @@ (define-public sway
                   gdk-pixbuf
                   json-c
                   libevdev
-                  libinput
+                  libinput-minimal
                   libxkbcommon
                   pango
                   swaybg
-- 
2.36.1





^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#56139] [PATCH 3/4] gnu: waybar: Replace input libinput by libinput-minimal.
  2022-06-22 12:14 [bug#56139] [PATCH 0/4] Make window managers use libinput-minimal instead of libinput Josselin Poiret via Guix-patches via
  2022-06-22 12:17 ` [bug#56139] [PATCH 1/4] gnu: wlroots: Replace input libinput by libinput-minimal Josselin Poiret via Guix-patches via
  2022-06-22 12:17 ` [bug#56139] [PATCH 2/4] gnu: sway: " Josselin Poiret via Guix-patches via
@ 2022-06-22 12:17 ` Josselin Poiret via Guix-patches via
  2022-06-22 12:17 ` [bug#56139] [PATCH 4/4] gnu: hikari: " Josselin Poiret via Guix-patches via
  2022-06-23 20:20 ` bug#56139: [PATCH 0/4] Make window managers use libinput-minimal instead of libinput Ludovic Courtès
  4 siblings, 0 replies; 9+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2022-06-22 12:17 UTC (permalink / raw)
  To: 56139; +Cc: Josselin Poiret

* gnu/packages/wm.scm (waybar)[propagated-inputs]: Replace libinput
by libinput-minimal to reduce closure.
---
 gnu/packages/wm.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 3fd4ed6ca4..8c312e5115 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1724,7 +1724,7 @@ (define-public waybar
                   gtkmm-3
                   jsoncpp
                   libdbusmenu
-                  libinput
+                  libinput-minimal
                   libmpdclient
                   libnl
                   libxml2
-- 
2.36.1





^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#56139] [PATCH 4/4] gnu: hikari: Replace input libinput by libinput-minimal.
  2022-06-22 12:14 [bug#56139] [PATCH 0/4] Make window managers use libinput-minimal instead of libinput Josselin Poiret via Guix-patches via
                   ` (2 preceding siblings ...)
  2022-06-22 12:17 ` [bug#56139] [PATCH 3/4] gnu: waybar: " Josselin Poiret via Guix-patches via
@ 2022-06-22 12:17 ` Josselin Poiret via Guix-patches via
  2022-06-23 20:20 ` bug#56139: [PATCH 0/4] Make window managers use libinput-minimal instead of libinput Ludovic Courtès
  4 siblings, 0 replies; 9+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2022-06-22 12:17 UTC (permalink / raw)
  To: 56139; +Cc: Josselin Poiret

* gnu/packages/wm.scm (hikari)[propagated-inputs]: Replace libinput
by libinput-minimal to reduce closure.
---
 gnu/packages/wm.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 8c312e5115..a23acfd3f8 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -2561,7 +2561,7 @@ (define-public hikari
      (list bmake pkg-config wayland-protocols))
     (inputs
      `(("cairo" ,cairo)
-       ("libinput" ,libinput)
+       ("libinput" ,libinput-minimal)
        ("libucl" ,libucl)
        ("libxkbcommon" ,libxkbcommon)
        ("pam" ,linux-pam)
-- 
2.36.1





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#56139: [PATCH 0/4] Make window managers use libinput-minimal instead of libinput
  2022-06-22 12:14 [bug#56139] [PATCH 0/4] Make window managers use libinput-minimal instead of libinput Josselin Poiret via Guix-patches via
                   ` (3 preceding siblings ...)
  2022-06-22 12:17 ` [bug#56139] [PATCH 4/4] gnu: hikari: " Josselin Poiret via Guix-patches via
@ 2022-06-23 20:20 ` Ludovic Courtès
  2022-06-23 20:34   ` [bug#56139] " Maxime Devos
  4 siblings, 1 reply; 9+ messages in thread
From: Ludovic Courtès @ 2022-06-23 20:20 UTC (permalink / raw)
  To: Josselin Poiret; +Cc: 56139-done

Hi,

Josselin Poiret <dev@jpoiret.xyz> skribis:

> This reduces their total closure, since libinput pulls in gtk+ which
> adds roughly 400MiB.

Good catch; applied, thanks!

It never occurred to me that it could depend on GTK+; apparently that’s
for some debugging GUI, but it’s not clear how it’s supposed to get
invoked:

--8<---------------cut here---------------start------------->8---
$ grep -r 2i4ykhraljp7jhhs76v44c51kkz31f01 $(guix build libinput)
grep: /gnu/store/brbdvjj4k9g80c2vdv8cfkckwd1q9dsk-libinput-1.19.2/libexec/libinput/libinput-debug-gui: binary file matches
grep: /gnu/store/brbdvjj4k9g80c2vdv8cfkckwd1q9dsk-libinput-1.19.2/etc/ld.so.cache: binary file matches
$ grep -r libinput-debug-gui $(guix build libinput)
$ echo $?
1
--8<---------------cut here---------------end--------------->8---

What’s is it used for?

Ludo’.




^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#56139] [PATCH 0/4] Make window managers use libinput-minimal instead of libinput
  2022-06-23 20:20 ` bug#56139: [PATCH 0/4] Make window managers use libinput-minimal instead of libinput Ludovic Courtès
@ 2022-06-23 20:34   ` Maxime Devos
  2022-06-24 15:10     ` Ludovic Courtès
  0 siblings, 1 reply; 9+ messages in thread
From: Maxime Devos @ 2022-06-23 20:34 UTC (permalink / raw)
  To: Ludovic Courtès, Josselin Poiret; +Cc: 56139-done

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

Ludovic Courtès schreef op do 23-06-2022 om 22:20 [+0200]:
> Hi,
> 
> Josselin Poiret <dev@jpoiret.xyz> skribis:
> 
> > This reduces their total closure, since libinput pulls in gtk+ which
> > adds roughly 400MiB.
> 
> Good catch; applied, thanks!
> 
> It never occurred to me that it could depend on GTK+; apparently that’s
> for some debugging GUI, but it’s not clear how it’s supposed to get
> invoked:
> 
> [...]
> 
> What’s is it used for?

FWIW, it has a man page:
<https://man.archlinux.org/man/extra/libinput/libinput-debug-gui.1.en>?

I did some quick searches for 'libinput-debug-gui' on the Web but
didn't find any uses in the wild, so maybe we don't really lose
anything by disabling it?

Also, having multiple library variants is a bit messy (there was some
bug involving multiple versions of cairo used by a single app?), so I'd
prefer to eliminate the libinput / libinput-minimal distinction (maybe
with a separate libinput-debug-gui package if desired?).

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#56139] [PATCH 0/4] Make window managers use libinput-minimal instead of libinput
  2022-06-23 20:34   ` [bug#56139] " Maxime Devos
@ 2022-06-24 15:10     ` Ludovic Courtès
  2022-06-26 10:14       ` Josselin Poiret via Guix-patches via
  0 siblings, 1 reply; 9+ messages in thread
From: Ludovic Courtès @ 2022-06-24 15:10 UTC (permalink / raw)
  To: Maxime Devos; +Cc: Josselin Poiret, 56139-done

Hi,

Maxime Devos <maximedevos@telenet.be> skribis:

> FWIW, it has a man page:
> <https://man.archlinux.org/man/extra/libinput/libinput-debug-gui.1.en>?

Since it’s under libexec/, I’d assume that it’s not meant to be invoked
directly, but the man page suggests otherwise?…

> I did some quick searches for 'libinput-debug-gui' on the Web but
> didn't find any uses in the wild, so maybe we don't really lose
> anything by disabling it?

Looks like it.

> Also, having multiple library variants is a bit messy (there was some
> bug involving multiple versions of cairo used by a single app?), so I'd
> prefer to eliminate the libinput / libinput-minimal distinction (maybe
> with a separate libinput-debug-gui package if desired?).

Yeah, maybe we can do that (with a comment), and apparently that’s even
an OK change for master.

If you provide a patch, I’ll happily apply it.  :-)

Ludo’.




^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#56139] [PATCH 0/4] Make window managers use libinput-minimal instead of libinput
  2022-06-24 15:10     ` Ludovic Courtès
@ 2022-06-26 10:14       ` Josselin Poiret via Guix-patches via
  0 siblings, 0 replies; 9+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2022-06-26 10:14 UTC (permalink / raw)
  To: Ludovic Courtès, Maxime Devos; +Cc: 56139-done

Hi Ludo and Maxime, 

Ludovic Courtès <ludo@gnu.org> writes:
> Since it’s under libexec/, I’d assume that it’s not meant to be invoked
> directly, but the man page suggests otherwise?…

Just as a heads-up, the debug GUI is supposed to be launched through
`libinput debug-gui`.  I'm not sure there's anything there that cannot
be debugged through `libinput debug-envents` though.

Cheers,
-- 
Josselin Poiret




^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-06-26 10:16 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-22 12:14 [bug#56139] [PATCH 0/4] Make window managers use libinput-minimal instead of libinput Josselin Poiret via Guix-patches via
2022-06-22 12:17 ` [bug#56139] [PATCH 1/4] gnu: wlroots: Replace input libinput by libinput-minimal Josselin Poiret via Guix-patches via
2022-06-22 12:17 ` [bug#56139] [PATCH 2/4] gnu: sway: " Josselin Poiret via Guix-patches via
2022-06-22 12:17 ` [bug#56139] [PATCH 3/4] gnu: waybar: " Josselin Poiret via Guix-patches via
2022-06-22 12:17 ` [bug#56139] [PATCH 4/4] gnu: hikari: " Josselin Poiret via Guix-patches via
2022-06-23 20:20 ` bug#56139: [PATCH 0/4] Make window managers use libinput-minimal instead of libinput Ludovic Courtès
2022-06-23 20:34   ` [bug#56139] " Maxime Devos
2022-06-24 15:10     ` Ludovic Courtès
2022-06-26 10:14       ` Josselin Poiret via Guix-patches via

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).