From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YGHjGZRuvWJYwAAAbAwnHQ (envelope-from ) for ; Thu, 30 Jun 2022 11:36:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qBntGZRuvWLjVQEAauVa8A (envelope-from ) for ; Thu, 30 Jun 2022 11:36:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 02BD835BB for ; Thu, 30 Jun 2022 11:36:20 +0200 (CEST) Received: from localhost ([::1]:45028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6qax-0002mm-2R for larch@yhetil.org; Thu, 30 Jun 2022 05:36:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6qah-0002kQ-La for guix-patches@gnu.org; Thu, 30 Jun 2022 05:36:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6qah-0002OW-Cy for guix-patches@gnu.org; Thu, 30 Jun 2022 05:36:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o6qag-0001zq-9w for guix-patches@gnu.org; Thu, 30 Jun 2022 05:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53163] [PATCH] doc: Document some reasons for/against git tags/commits. References: <5623ec2b15bf60a51587b0592ad178b2bec3ef37.camel@telenet.be> In-Reply-To: <5623ec2b15bf60a51587b0592ad178b2bec3ef37.camel@telenet.be> Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 30 Jun 2022 09:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53163 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53163@debbugs.gnu.org Received: via spool by 53163-submit@debbugs.gnu.org id=B53163.16565817567661 (code B ref 53163); Thu, 30 Jun 2022 09:36:02 +0000 Received: (at 53163) by debbugs.gnu.org; 30 Jun 2022 09:35:56 +0000 Received: from localhost ([127.0.0.1]:32901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6qaa-0001zV-9a for submit@debbugs.gnu.org; Thu, 30 Jun 2022 05:35:56 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:46208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6qaV-0001zG-KD for 53163@debbugs.gnu.org; Thu, 30 Jun 2022 05:35:54 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by andre.telenet-ops.be with bizsmtp id pMbp2700H4UW6Th01MbpqU; Thu, 30 Jun 2022 11:35:50 +0200 Message-ID: From: Maxime Devos Date: Thu, 30 Jun 2022 11:35:44 +0200 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-OtfN53BsQXXVuktctijO" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1656581750; bh=lXNX6aSKLJi0Vtw2U6DAgDYwP2XxIL9PYh0c7QQC8hc=; h=Subject:From:To:Date; b=RetpEyN9YhYWeeKVGg4ajTFZ9z9YIfdVyzrIg0BckZ3hzG3TjiIdxKIzh4E3B0mo6 08IfQSXjlQBahTIVdWSTat6fexG6SIebG80RLMQ4yzoKQ09fQJszxzxXxEK+6JiWYi Pqqlx09PtT5/mg86J1HizxyUViRmhwJixZ3By3Es+o2PbJtIH9fgkHQP1tYrSA7Ctc pCI9CHilCHWGwvmEDEKAXBT7BZhNgHnV67sc6xJxqQojP1mvErVvr84bilpJYrtH94 ByU/6HGRTFLoXgaIELlwRHq0XqE+Ra7eAA7JlmbX6X7DmxPBreSr/oSvOdNkT/jowY cGRzUc7gJOGPg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656581780; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=lXNX6aSKLJi0Vtw2U6DAgDYwP2XxIL9PYh0c7QQC8hc=; b=kUqhLa+1eVIsE/FUDXscn6E44BKVBTnjz4dqGpI+uhIHl426RNNvkTAmvuc+zOUFDT68ia wMAGAbsIirscX6eQZh7eoxdan+iISefAJxkcf7ZSen9EJyZxv0KYB+aggdWVeUJlWsX16k njyVz5xSAdrxcdoDrMuV+qvLdy+cu/4bwrkWEezlY6SbR3tU/Lht/XdRu3zgXPJ4lYrg/V YJoH9qGOT0CQKsdBbKEV18Cb5TQ5Lr8vCYpkj7n69qvrmBJnFrQLMSU8rhb7cJIE25eFto de6vN+ZCgF11u8zkZfryDHzAu5QyUM33IPwXkNEJT51OVJ3IJeIyEzaUJCEFpA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656581780; a=rsa-sha256; cv=none; b=fVyRmQQ1txVU1OgkATpEC1OBOKq42MI5ZZfHz3++7zik/PwUSCB79dWV44sJl6/+ypjrTo uUmxO+ninmVlWVHZIkTQvHf/y6DWH+CP0Ajb+8DWZ7nJcObOQmZgIsPNTv8qh0Y5LGbpcY eywhcgTmQ7HoZO6KYFGONe3Bm4A1m41I1/UJk/+hyMpH3vPCbUHYXL9PxL5BPxzqrc8LrC vT9Mpmf/chG1/ZpCntvAJkCRfr+H8AFwRZzaE61S831J0kJ2M1cGxaP8/GPGI1D0aEDDbI CT7QQlPwbpc/qr7jyhWmYr+e5ozDGts/q55zTYqQXMPt93A8UtdnXbIhiaNh5g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=RetpEyN9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.95 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=RetpEyN9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 02BD835BB X-Spam-Score: 3.95 X-Migadu-Scanner: scn1.migadu.com X-TUID: 3BWZJNt4o+Lk --=-OtfN53BsQXXVuktctijO Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > I think we should separate reference material from guidelines.=20 > Perhaps this should rather go under =E2=80=9CPackaging Guidelines=E2=80= =9D, next to > =E2=80=9CVersion Numbers=E2=80=9D? I suppose for consistency with the =E2=80=98Packaging Guidelines=E2=80=99 c= hapter, I could move it there, though I'd like to add a cross-reference to the description of =E2=80=98commit=E2=80=99 in git-reference for convenience, e= .g. maybe: =E2=80=98commit=E2=80=99 This string denotes either the commit to fetch (a hexadecimal string), or the tag to fetch. You can also use a =E2=80=9Cshort= =E2=80=9D commit ID or a =E2=80=98git describe=E2=80=99 style identifier su= ch as =E2=80=98v1.0.1-10-g58d7909c97=E2=80=99. =C2=A0**To decide betwee= n choosing a commit or a tag, the guidelines in [cross-reference] may be useful.** ? (At first I'd have preferred to not separate reference material to keep all information on commits together, but on second thought separating them would be more orderly and it's not like we don't have cross- references, so maybe it would be better to split ...) > Toggle quote (4 lines) > > +Commits make reviewing somewhat trickier, because the reviewer has > > +to > > +verify that that the commit actually corresponds to the package > > version. > I'd also add a line regarding the difficulty to verify that a commit > did once belong to a tag as a future reader, but I'm not sure what > exactly to advise here and how. In the particular case of minetest, > we have an external map of "tags" to commits that can be queried, but > for most repos I fear the tags would simply be lost to time. FWIW, the same holds (though maybe to a lesser degree in practice?) for hashes and tarballs), not specific to git. Anyway, SWH keeps this historical information, e.g. here are two lists of tags->commits of the Minetest repo at two different points in time: * https://archive.softwareheritage.org/browse/snapshot/d063751724753b97de41= a34aa3d1779186530bb4/releases/?origin_url=3Dhttps://github.com/minetest/min= etest×tamp=3D2020-01-18T00:07:33Z * https://archive.softwareheritage.org/browse/snapshot/81e0233dbaf285922bef= 2281f4e5cbbe5fbc7ea0/releases/?origin_url=3Dhttps://github.com/minetest/min= etest×tamp=3D2022-06-25T04:01:20Z That assumes trusting SWH to be correct of course (and a bit of a SPOF though I don't expect problems), but with some work, things can be verified even for repos that delete tags. Anyway, any remaining comments or a second opinion? (Would like more than three people for something like this?) Greetings, Maxime. --=-OtfN53BsQXXVuktctijO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYr1ucBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hWbAQDTLe699nkJEK3/jpG9+6Fe0YTn b1uoxTGZaCm3y8xIiwD/auEMUcbq/Vqvl5zuRRrB136WW/52cYg/EFHLedVZkQ8= =P2bS -----END PGP SIGNATURE----- --=-OtfN53BsQXXVuktctijO--