From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oOMEMZ9CqWF+WwEAgWs5BA (envelope-from ) for ; Thu, 02 Dec 2021 23:03:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CLPHLJ9CqWHlHgAAbx9fmQ (envelope-from ) for ; Thu, 02 Dec 2021 22:03:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 48AA32BF0B for ; Thu, 2 Dec 2021 23:03:11 +0100 (CET) Received: from localhost ([::1]:53158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msuAY-0002st-Cu for larch@yhetil.org; Thu, 02 Dec 2021 17:03:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msuAQ-0002sl-8K for guix-patches@gnu.org; Thu, 02 Dec 2021 17:03:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37953) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1msuAQ-0004Jd-0m for guix-patches@gnu.org; Thu, 02 Dec 2021 17:03:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1msuAP-0007U8-Pt for guix-patches@gnu.org; Thu, 02 Dec 2021 17:03:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Dec 2021 22:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timothy Sample Cc: 51838@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163848254828729 (code B ref 51838); Thu, 02 Dec 2021 22:03:01 +0000 Received: (at 51838) by debbugs.gnu.org; 2 Dec 2021 22:02:28 +0000 Received: from localhost ([127.0.0.1]:49499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msu9s-0007TJ-Et for submit@debbugs.gnu.org; Thu, 02 Dec 2021 17:02:28 -0500 Received: from mail-ua1-f43.google.com ([209.85.222.43]:38907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msu9o-0007T2-Ci for 51838@debbugs.gnu.org; Thu, 02 Dec 2021 17:02:27 -0500 Received: by mail-ua1-f43.google.com with SMTP id w23so1832489uao.5 for <51838@debbugs.gnu.org>; Thu, 02 Dec 2021 14:02:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=3ghnhVVg5hchPUILyD6kF2bhce9DBxRISQHCFlt4wEE=; b=BF20jCRMMKlhjM0kPZn3WFjwSBb6tRKaDsA4sjg0vPI25ijx0hax5Stja+5tz3Zggi 98lLd8yI4ThSZhCEjt1jMbvoawm62Yy8yETG3GGXt6FRkLhf8UN7BitqqoHakX38noNE dV5QBcoAdlzsq9D7STHFspSf+MjH506OFjjNLZsr9dd+6M58dx9wNG+2O6fOPicRjEm2 LNPi8uHj+uoW3JO8A8y5gaHLqulzsiPiWPk49pOObgwWzAmCQYSwmGi/0R1ypN2ZYrUv QMaOLY1V8lQGAGl2TSKtCc4tkY0Atwx5YK9SEVw38INGuROktT85fWBTsFx2Ibwb2ylK 3yTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3ghnhVVg5hchPUILyD6kF2bhce9DBxRISQHCFlt4wEE=; b=02IsT93cf6+huFcDP+IlCc0Z/qcTXnlARzeTeZ4zYxKf25Q6EPP9NkHuTxpNUJeIF9 cgWHbKL+6e9RQpbtGVX4RmsWGLh/zse952FbNY8gC9kjPpqB52Fh1mXaSLC7VTYpzaVa WB0jKNGfgcYZwK51+WYDWr5hQ00nmQJjWorM9JtfOm1UiVjd0/wnvf+XiB7VUcRbry28 Y7NbjVRdOYNCOYQJvy7ibEmNCPn6uZ023cgT2J4pt9IF6wvNCspC//8HViiKO36hSD3B 7Jd/VdYNDb6D2MjuncOfzGUB1VARkqXsYXvaBcdef/+GAfNStvyADDk4inEVaHrl1Lre syiw== X-Gm-Message-State: AOAM530joV6zfPyKVKkn3bZ7Mv6Xfo+fXSh4y8gNcrVXV2gJ9idXLUDd NXWGvk9+jeHR174/NboTl7NPLQ== X-Google-Smtp-Source: ABdhPJxJkGpOwG2dJ6NfZRCc4NJMR6vcM4g8+xLEOtlGd3oUm78JWzBGYJOPl5srbmPc1m8AKCQaSA== X-Received: by 2002:a05:6102:2910:: with SMTP id cz16mr18191876vsb.9.1638482538616; Thu, 02 Dec 2021 14:02:18 -0800 (PST) Received: from [192.168.45.36] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id bj50sm198098vkb.7.2021.12.02.14.02.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 14:02:18 -0800 (PST) Message-ID: Date: Thu, 2 Dec 2021 17:02:17 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Content-Language: en-US References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> <20211120043406.952350-1-philip@philipmcgrath.com> <20211120043406.952350-5-philip@philipmcgrath.com> <8c07272b588fc059f3c445fe1f33c63cce8f31f1.camel@gmail.com> <37768a63-5a4a-b604-2542-e8890fd68a16@philipmcgrath.com> <87o86ebnee.fsf@ngyro.com> From: Philip McGrath In-Reply-To: <87o86ebnee.fsf@ngyro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638482591; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3ghnhVVg5hchPUILyD6kF2bhce9DBxRISQHCFlt4wEE=; b=HJVGF5YfQq1mkM0/etvtKkL9UIMbYG/me7wkADVt7N9qTBodPPJeaRBCn9xYjsHlclO9PS AfAgsh0hMrQSiWLrkHojj9X6ClOx4xWjXHtnXaFH3nFni5BmV1yrnBZXAiG//7tRT2MQIk mpw/NajiBwOHV1s8FHPhnHlUIxgNRh4tui5AltHTe08wXfljTf66fc3drCuDDeX6ZisM7J XmguTNw/kXuMwFPsoTebS/zSJAf302RwKAzDNn2Gtyka3DWUxIYGJfMF6pe7R6PVOZVIUc cPAqB3dBHtDfdxVTbnhccwMf3hJdtDUEWOce2tk5jv8QnF0SJdEFYDgEQwBoYg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638482591; a=rsa-sha256; cv=none; b=IQ093WxdfJ3LCp3jaMy38Jq0/PG+k9r0XARp4E3W846bR4V4TemcjjHiDkryzB6jEonpqX eKqXnmq2Odxm80imbYf7evkA2DnB9rtZ0NDtX+Z80NJZ1caScmPvttyYzoAIik9K9FRi5+ twF1dcpg1ZaHnTOAa2mnGTf48v//ZZDclc3QHzCmfAtxmxypGjcKXw4w6DNzgR+TNHJ10w yj7F1mmnWCpP+1n/9julXmzZS0bO7vvZ38lvKzTT7RWmv+OeDQ4l+X8Tuy4R0JBzwawKRm 25GpH5Ev1Sp/wdmIaKRnEOdhbSayqhNLD4KLLM7Q356RSh5LxYF79XC+3F0r8A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=BF20jCRM; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=BF20jCRM; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 48AA32BF0B X-Spam-Score: -1.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: RQP0FUZK3lDS Hi, On 11/20/21 15:04, Timothy Sample wrote: > Hello, > > Philip McGrath writes: > >> On 11/20/21 02:41, Liliana Marie Prikler wrote: >> >>> In the resolve-dependencies subprocedure, we could check whether we >>> have a matching input somewhere and only include the dependency if we >>> do. WDYT? >> >> [...] >> >> The other issue is that deleting packages with no matching input by >> default would replicate some of the drawbacks of the current `(delete >> 'configure)` approach. I think it's better to have an explicit list of >> dependencies that Guix is deleting. If eventually we package all of >> the missing dependencies for Guix, it would be much easier to find the >> packages that ought to use it. And, in the highly dynamic JavaScript >> world, I'm reluctant to give up one of the few static checks we >> have. If a missing package that really was required were automatically >> deleted from "package.json", it seems the failure mode would by a >> mysterious runtime error, potentially many steps down a dependency >> chain. > > This is well put. I actually experimented with a similar approach when > we updated the Node.js build system. This is a big improvement over > deleting the configure phase, which would never scale to more than a > handful of packages. Having a build-time check that ensures all the > developer-declared dependencies are available (save the “absent” ones) > will be very helpful when we are maintaining hundreds of JavaScript > packages. :) It's probably also worth noting that many (most?) of our Node.js packages currently don't run tests: an unfortunate number don't have any tests, and then there's the issue that we haven't packaged JavaScript test frameworks for Guix yet. > For the patch itself, it would be better to move a lot of your commit > message into a comment somewhere in the build system code. If we had a > section in the manual for Node packages, it would go there, but alas.... > I think most people would be happy to see a comment in the build system > code and be saved from having to poke around with ‘git blame’. Yes, I'll add comments. -Philip