unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: 58365@debbugs.gnu.org
Subject: [bug#58365] [PATCH 0/6] Support #:tests? in guile-build-system
Date: Fri, 7 Oct 2022 22:47:49 +0200	[thread overview]
Message-ID: <e39412d9-edf3-25c7-1e86-5442ecc0a1fd@telenet.be> (raw)


[-- Attachment #1.1.1: Type: text/plain, Size: 1589 bytes --]

Fixes: <https://issues.guix.gnu.org/58337>

guile-build-system can't guess where the tests are located, so currently 
it's opt-in, via #:test-script.  After this patch series, it is 
currently only used by guile-ffi-fftw, but other guile-build-system 
packages that use SRFI-64 could potentially use it too (e.g. 
guile-srfi-117, which is not packages or even released yet).

* First commit: package a test driver, for nicer output and for proper 
exit status.  I copied test-driver.scm to aux-files such that 
test-driver.scm can be changed without worrying about rebuilds.  OTOH, 
it isn't modified that often, so that could be left out.

Also, copying test-driver.scm causes the following:

guix build: warning: failed to load '(gnu packages aux-files test-driver)':
no code for module (gnu packages aux-files test-driver)
hint: File 
`/home/antipode/source-code/guix-master/gnu/packages/aux-files/test-driver.scm' 
should probably start with:

      (define-module (gnu packages aux-files test-driver))

Whatever code does this loading, should probably be modified to not load 
things under aux-files.

Going by "git log", the upstream of this test driver is Guix itself.

* Second commit: add support for #:tests?, using the test driver.
* Third commit: use it in guile-ffi-fftw.
* Fourth and fifth commit: cleanup of guile-ffi-fftw.
* Sixth commit: adjust guile-ac-d-bus to new 'check' phase

Only the initial commit is required for adding support for tests.

I'll leave building dependencies to <https://qa.guix.gnu.org/>.

Greetings,
Maxime.

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

             reply	other threads:[~2022-10-07 20:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 20:47 Maxime Devos [this message]
2022-10-07 20:53 ` [bug#58365] [PATCH 1/6] gnu: Add guile-test-driver Maxime Devos
2022-10-07 20:53   ` [bug#58365] [PATCH 2/6] build-system/guile: Run SRFI-64 tests Maxime Devos
2022-10-07 20:53   ` [bug#58365] [PATCH 3/6] guile-ffi-fftw: Respect #:tests? Maxime Devos
2022-10-07 20:53   ` [bug#58365] [PATCH 4/6] guile-ffi-fftw: Modernise style Maxime Devos
2022-10-07 20:53   ` [bug#58365] [PATCH 5/6] guile-ffi-fftw: Update to new Guile version Maxime Devos
2022-10-07 20:53   ` [bug#58365] [PATCH 6/6] guile-ac-d-bus: Don't duplicate 'check' phase Maxime Devos
2022-10-18 12:36   ` [bug#58365] [PATCH 0/6] Support #:tests? in guile-build-system Ludovic Courtès
2022-10-18 13:30     ` Maxime Devos
2022-10-18 15:44       ` Ludovic Courtès
2023-11-20  0:34         ` Maxime Devos
2023-11-20  0:41           ` Maxime Devos
2023-12-03  9:17           ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e39412d9-edf3-25c7-1e86-5442ecc0a1fd@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=58365@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).