From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wEWYEYFAlWGVsgAAgWs5BA (envelope-from ) for ; Wed, 17 Nov 2021 18:48:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kKckDYFAlWGsHwAAbx9fmQ (envelope-from ) for ; Wed, 17 Nov 2021 17:48:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 043052DCA8 for ; Wed, 17 Nov 2021 18:48:49 +0100 (CET) Received: from localhost ([::1]:53760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnP3A-0000hw-8a for larch@yhetil.org; Wed, 17 Nov 2021 12:48:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnP2Q-00086Y-S1 for guix-patches@gnu.org; Wed, 17 Nov 2021 12:48:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnP2Q-0002Or-JW for guix-patches@gnu.org; Wed, 17 Nov 2021 12:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnP2Q-0008TJ-IW for guix-patches@gnu.org; Wed, 17 Nov 2021 12:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51923] [PATCH] gnu: Add megapixels. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 Nov 2021 17:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51923 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina Cc: 51923@debbugs.gnu.org Received: via spool by 51923-submit@debbugs.gnu.org id=B51923.163717124332382 (code B ref 51923); Wed, 17 Nov 2021 17:48:02 +0000 Received: (at 51923) by debbugs.gnu.org; 17 Nov 2021 17:47:23 +0000 Received: from localhost ([127.0.0.1]:33853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnP1m-0008QD-Vq for submit@debbugs.gnu.org; Wed, 17 Nov 2021 12:47:23 -0500 Received: from tobias.gr ([80.241.217.52]:44282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnP1i-0008Py-P6 for 51923@debbugs.gnu.org; Wed, 17 Nov 2021 12:47:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=cAS4JJLxxf4V9 EsIoMAG4sq/2dwEbdAbJeA4CcCityQ=; h=references:in-reply-to:subject:cc: to:from:date; d=tobias.gr; b=WYwvmPVDKDFSrgpL05KMyj7uFcPj1BWZmb370paTr lQBAoeDl7lKKx3dcIaMleNXLB6onjlS+DIHhW99NnNyvi/C51Ffh8a5WwCaJ3OOyGRYszs CH1/LDCYyn55BWNG6DZ61zswFvQuuWtfc4n/p+RCI5SZoVgEXSWpC/BFM/WBouCqHANm4K 4aVHtkZYNPIGyeryyCQcP5JAfeBXJ1htFmIMKX8Nn//LvhTvNbsQBrdexHeMRU3pRNYLxr wuzi5blRhYJYjuoW1or50qO8rqk7RATI6bdlvw1rMB1qX5FDaW5kDjthskVJg/KalEqMjm xho/ZtUY4KZkXg8w1iiug== Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id a4d31437; Wed, 17 Nov 2021 17:47:15 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 17 Nov 2021 18:47:15 +0100 In-Reply-To: <1vMgyrQNafwkMS0fIpN4mfDx99qF7xXbrXm_sCn6ysww4GrF4zowVOX2LzUzvgC33fu6zlCrPKQTpas0kymx5ME2BmRRNON5m0cmlh9Lrbs=@protonmail.com> References: <1vMgyrQNafwkMS0fIpN4mfDx99qF7xXbrXm_sCn6ysww4GrF4zowVOX2LzUzvgC33fu6zlCrPKQTpas0kymx5ME2BmRRNON5m0cmlh9Lrbs=@protonmail.com> Message-ID: Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637171329; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cAS4JJLxxf4V9EsIoMAG4sq/2dwEbdAbJeA4CcCityQ=; b=JMDoGArgoI5haEGKW6KTDjjgZQjF+VD+XEFNJaDWBfV2FwrZc6hG6qqQrBFj/U2ln097px NMTQ/JwIjfd0zSuoMdMuUGnanFM0ufs6zXNbA9Rjxi+IWSCNt15X+QG1aAyzUz+SSJ7QL7 GsHurFspMeunWYASZNsKOkCizgEAkx131lrgV6jth1XMn4PV2IMAVJJ+GL087TZPGjB8Gu iTbce+knnkAHib3dwGD9B3khfx2uPeZhDLc1v4W0kn42MizWUE70DNHUefqrujdYF8hE35 ZZCRsvC6O5n/mgWnz0ZoOrccfEDiz46EYRjTwmCXXeBu4W1J2Eue7XVcfdpnwQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637171329; a=rsa-sha256; cv=none; b=HQFOePNVhIRtGBd3anu3mIpisZJi2p5x6Uuof/EvLaZdiqYX0B39G7rTi9aBcXNx3Pd7f+ Tx7dNj8BtQexQHfkroVkV4jqaPSEIhuMFTNZtsmYOiK861LOyv8Aa1hkvocq0V0Sn2du5d hxS5jB9QRM1Y1fevVkXcRIT3ZyDHe4znP+fEgRZuMXKdSGhgRTGWkPojYAECON6rfQp+4s 7tSCjlyGqlZVyFMxilPfZoUlf9IlfBZx7xyku6cuWgqVQQTGGvb2ayoiEpD/ztR1RpXweC lKlfSDI/ENbIcXipY9XAQFptbzaPGGN3C1ZPQdHF/06Q+qbQLPz05inWAqsHQA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=WYwvmPVD; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=WYwvmPVD; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 043052DCA8 X-Spam-Score: -1.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: MnFYHgV85l3n Petr, 'Nother quickie. On 2021-11-17 17:07, phodina via Guix-patches via wrote: > The problem is in the updater not handling the url > https://git.sr.ht/~martijnbraam/megapixels. Good thing 'he development and maintainership of Megapixels has been moved to gitlab.com/postmarketos/megapixels' then :-) Could you update the URL and try again? If you want you can report and/or investigate Guix's apparent failure to deal with sr.ht separately. > + (file-name (string-append name "-" version ".tar.gz")) ^^^^^^^^^ Use git-file-name here for convenience and to reduce the chances of such paste-os. > + (native-inputs `(("pkg-config" ,pkg-config) > + ("gtk:bin" > + ,gtk "bin") ; for gtk-update-icon-cache > + ("glib:bin" > + ,glib "bin") ; glib-compile-schemas, etc. > + ("desktop-file-utils" > + ,desktop-file-utils) ; for > update-desktop-database > + ("zbar" ,zbar) > + ("libtiff" ,libtiff) > + ("cmake" ,cmake))) Please add a newline after native-inputs so you don't have to split inputs over 2 lines like this. Since we're here anyway, order these alphabetically. > + (inputs `(("libhandy" ,libhandy) > + ("perl-image-exiftool" ,perl-image-exiftool) > + ("imagemagick" ,imagemagick) > + ("libraw" ,libraw) > + ("gtk" ,gtk))) Same newline. > + (synopsis "Camera application") So... ignoring the redundant 'application', this is a one-word synopsis. This seems to be for mobile devices, so 'Camera applications for mobile devices', I guess. > + (description "This package provides camera application that knows > +how to deal with the media request api.") Whose obscure 'media request API'? Why does that matter? Etc. This seems (more?) pertinent: - Megapixels only captures raw frames and stores .dng files. - It captures a 5 frame burst and saves it to a temporary location. - It runs a (customisable? dunno) postprocessing script to generate the final JPEG file and saves it to the Pictures directory. - It uses OpenGL to debayer the raw sensor data for the preview. Etc. Descriptions should not be 1-2 lines long. > + (home-page "https://git.sr.ht/~martijnbraam/megapixels") Also update to GitLab? I'll build this later today, but I don't expect to find any issues with the package :-) Kind regards, T G-R Sent from a Web browser. Excuse or enjoy my brevity.