unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Wil deBeest <bovid-19@4tii.de>
Cc: 54974@debbugs.gnu.org, Greg Hogan <code@greghogan.com>
Subject: [bug#54974] [PATCH] added btop
Date: Fri, 29 Apr 2022 11:37:25 +0200	[thread overview]
Message-ID: <e15b639fb4533dbd5a50e26317ca5736c820c785.camel@telenet.be> (raw)
In-Reply-To: <32AB7591-1B34-4AA9-B503-5CAFBCE10D60@4tii.de>

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

Wil deBeest schreef op vr 29-04-2022 om 01:17 [+0200]:
> Hi Maxime,
> 
> > Long term, %outputs, %build-inputs, ... are being phased out, so I'd go
> > with, so I'd go with
> > 
> >    (arguments (list #:make-flags #~(string-append "PREFIX=" #$output)))
> > 
> > here instead.
> 
> I haven't been able to integrate your snippet into the package.   Could you
> show me how to do so or tell me which part of the handbook would be
> relevant?

For a good example, see the 'stress-ng' package definition 'guix edit
stress-ng'.  #:make-flags is documented in the manual (search for
#:make-flags or go to (guix)Build Systems).  #$output is documented in
‘(guix)G-Expressions’.

Very concretely:

  (package
    [...]
    (arguments (list #:tests? #false ; some comment
                     #:make-flags #~(...)
                     #:phases
                     ;; [Stuff for replacing the install phase and
                     ;; removing the configure phase]
                     #~(modify-phases %standard-phases ...))))

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2022-04-29  9:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-16 15:37 [bug#54974] [PATCH] added btop Wil deBeest
2022-04-18 13:40 ` Greg Hogan
2022-04-18 18:47   ` Maxime Devos
2022-04-18 18:02 ` Wil deBeest
2022-04-18 18:53 ` Maxime Devos
2022-04-18 18:55 ` Maxime Devos
2022-04-28 23:17 ` Wil deBeest
2022-04-29  9:37   ` Maxime Devos [this message]
2022-05-28 11:21 ` Wil deBeest

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e15b639fb4533dbd5a50e26317ca5736c820c785.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=54974@debbugs.gnu.org \
    --cc=bovid-19@4tii.de \
    --cc=code@greghogan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).