From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNGGE-0005aE-7s for guix-patches@gnu.org; Fri, 08 Dec 2017 05:52:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNGGA-00080P-At for guix-patches@gnu.org; Fri, 08 Dec 2017 05:52:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:42734) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eNGGA-000809-5z for guix-patches@gnu.org; Fri, 08 Dec 2017 05:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eNGG9-0001YD-W0 for guix-patches@gnu.org; Fri, 08 Dec 2017 05:52:02 -0500 Subject: [bug#29602] [PATCH] gnu: keepassxc: Always install libraries to /lib. Resent-Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_727f60bd86ea74896796891f539c7240" Date: Fri, 08 Dec 2017 11:51:13 +0100 From: Rutger Helling In-Reply-To: <87lgid1rf5.fsf@gnu.org> References: <728d0ba3ea817020fd00c71581ab9513@mykolab.com> <87lgid1rf5.fsf@gnu.org> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ludo@gnu.org Cc: 29602-done@debbugs.gnu.org --=_727f60bd86ea74896796891f539c7240 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII I agree, it makes more sense to set CMAKE_INSTALL_LIBDIR by default in 'cmake-build-system. On 2017-12-08 10:48, ludo@gnu.org wrote: > Rutger Helling skribis: > >> From fdfc9dec4761d4868ee20be2efa5cb6175eb745a Mon Sep 17 00:00:00 2001 >> From: Rutger Helling >> Date: Thu, 7 Dec 2017 09:21:22 +0100 >> Subject: [PATCH] gnu: keepassxc: Always install libraries to /lib. >> >> * gnu/packages/password-utils.scm (keepassxc)[arguments]: Add #:configure-flags >> argument to force installing libraries to /lib. > > Applied, thanks. > >> + (arguments >> + `(#:configure-flags >> + (list (string-append "-DCMAKE_INSTALL_LIBDIR=" >> + (assoc-ref %outputs "out") "/lib")))) > > At some point we should probably fix 'cmake-build-system'. Thoughts? > > Ludo'. --=_727f60bd86ea74896796891f539c7240 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8

I agree, it makes more sense to set CMAKE_INSTALL_LIBDIR by default in '= cmake-build-system.

On 2017-12-08 10:48, ludo@gnu.org wrote:

= Rutger Helling <rhelling@mykolab= =2Ecom> skribis:

From fdfc9dec4761d4868ee20be2efa5cb6175eb745a Mon Sep = 17 00:00:00 2001
From: Rutger Helling <rhelling@mykolab.com>
Date: Thu, 7 Dec 2017 09:21= :22 +0100
Subject: [PATCH] gnu: keepassxc: Always install libraries t= o /lib.

* gnu/packages/password-utils.scm (keepassxc)[argument= s]: Add #:configure-flags
argument to force installing libraries to /= lib.

Applied, thanks.

+    (arguments
+   &nb= sp; `(#:configure-flags
+       (l= ist (string-append "-DCMAKE_INSTALL_LIBDIR=3D"
+    &n= bsp;            = ;           (assoc-r= ef %outputs "out") "/lib"))))

At some point we should probably fix 'cmake-build-system'.  Tho= ughts?

Ludo'.


--=_727f60bd86ea74896796891f539c7240--