unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Sughosha <Sughosha@proton.me>, 57944@debbugs.gnu.org
Subject: [bug#57944] [PATCH 1/2] gnu: Add gnome-text-editor
Date: Tue, 20 Sep 2022 07:14:11 +0200	[thread overview]
Message-ID: <dfd58a79181ddc57c4c08ac80c7146925f307015.camel@gmail.com> (raw)
In-Reply-To: <wJKYD-IQATtDutQWaSGzGOKGqFl7ysgr8pIQxANvY5uflScFnmR9jvI5owL_WRkKO0tEbrs780OUM37ipdXIc2BGG3cRcoCKU8KyHyzBkJo=@proton.me>

Hi,

Am Dienstag, dem 20.09.2022 um 04:13 +0000 schrieb Sughosha:

> +              (uri (string-append "mirror://gnome/sources/gnome-
> text-editor/"
> +                                  (version-major version)
> +                                  "/"
> +                                  "gnome-text-editor-"
> +                                  version
> +                                  ".tar.xz"))
The format provided by the pretty-printer is, like, a suggestion.

> +    (build-system meson-build-system)
> +    (native-inputs (list pkg-config
You're missing arguments here.  At the very least #:glib-or-gtk? #t

> +     "Text Editor is a simple text editor that focuses on session
> management.
> +It works hard to keep track of changes and state even if you quit
> the
> +application.  You can come back to your work even if you've never
> saved it to a
> +file."
You should probably call it GNOME Text Editor.  The description is
fairly light on advertisments as far as copypasta descriptions go, so I
won't fault you for that here.

> +    (license license:gpl3)))
Should probably be gpl3+.

> +    (synopsis "Simple user-friendly terminal emulator for the GNOME
> desktop")
> +    (description
> +     "Console is supposed to be a simple terminal emulator for the
> average user
> +to carry out simple cli tasks and aims to be a ‘core’ app for
> GNOME/Phosh")
Ehhhhhh... I do want you to cut down on the ads here.

> +    (build-system meson-build-system)
> +    (native-inputs (list desktop-file-utils
Missing arguments.

> +    (home-page "https://gitlab.gnome.org/GNOME/gnome-console")
Dead link is dead.

> +    (license license:gpl3)))
Also probably gpl3+.

Cheers




  reply	other threads:[~2022-09-20  5:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20  4:13 [bug#57944] [PATCH 1/2] gnu: Add gnome-text-editor Sughosha via Guix-patches via
2022-09-20  5:14 ` Liliana Marie Prikler [this message]
2022-09-20  9:12   ` Sughosha via Guix-patches via
2022-09-20 11:21     ` Sughosha via Guix-patches via
2022-09-21 18:22       ` bug#57944: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfd58a79181ddc57c4c08ac80c7146925f307015.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=57944@debbugs.gnu.org \
    --cc=Sughosha@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).