unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Raghav Gururajan <rg@raghavgururajan.name>, 45889@debbugs.gnu.org
Subject: [bug#45889] Nextcloud Client (v14)
Date: Tue, 23 Feb 2021 18:58:48 +0100	[thread overview]
Message-ID: <df1c11b05a7a2920efe4859a9cf8ad66ee4dbf93.camel@student.tugraz.at> (raw)
In-Reply-To: <f6b95086-a9db-4bea-7b4d-9bb418b717e2@raghavgururajan.name>

Hi Raghav,

Am Dienstag, den 23.02.2021, 09:27 -0500 schrieb Raghav Gururajan:
> +             (let* ((qtsolutions (assoc-ref inputs "qtsolutions")))
> +               (for-each
> +                (lambda (dir)
> +                  (copy-recursively
> +                   (string-append qtsolutions "/" dir "/src")
> +                   (string-append "src/3rdparty/" dir)))
> +                '("qtlockedfile" "qtsingleapplication")))
> +             (with-directory-excursion "src/gui"
> +               (substitute* `("application.h" "application.cpp")
> +                 (("SharedTools::QtSingleApplication")
> "QtSingleApplication")
> +                 (("slotParseMessage\\(const QString &(msg)?.*\\)")
> +                  "slotParseMessage(const QString &msg)")))
Being the one who helped review this, I of course know, what it does,
but others might not, so this probably deserves a (short) comment.

> +       ("qtsolutions"
> +        ,(origin
> +           (method git-fetch)
> +           (uri
> +            (git-reference
> +             (url "https://github.com/qtproject/qt-solutions")
> +             (commit "9568abd142d581b67b86a5f63d823a34b0612702")))
> +           (file-name
> +            (git-file-name "qtsolutions" "9568abd"))
> +           (sha256
> +            (base32
> "17fnmassflm3vxi0krpr6fff368jy38cby31a48rban4nqqmgx7n"))))
I'm still not convinced, that this can't be made a package or perhaps
multiple packages, one per "solution".  Each of the folder seems to
contain a project file, which to be fair do have some non-Unix-related
install declarations, but it should at least install a statically
linked package *somewhere*.  We can go from there.

Alternatively, as I see this as a source, that will get copied around
in the same way I copied libgd from gedit, you can at least extract the
origin into a function in qt.scm, potentially named qt-solutions.

Regards,
Leo





  reply	other threads:[~2021-02-23 17:59 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 10:09 [bug#45889] Nextcloud Desktop Raghav Gururajan
2021-01-16  6:40 ` [bug#45889] Nextcloud Desktop (v2) Raghav Gururajan
2021-01-16  8:33 ` [bug#45889] Nextcloud Desktop (v3) Raghav Gururajan
2021-01-16 10:09 ` [bug#45889] Nextcloud Desktop (v4) Raghav Gururajan
2021-01-16 10:48   ` Nicolò Balzarotti
2021-01-16 14:42     ` Raghav Gururajan
2021-01-16 14:34 ` [bug#45889] Nextcloud Desktop (v5) Raghav Gururajan
2021-01-17 14:44 ` [bug#45889] Nextcloud Client (v6) Raghav Gururajan
2021-01-24 18:45   ` david larsson
2021-02-01 15:07     ` Raghav Gururajan
2021-02-01 15:13 ` [bug#45889] Nextcloud Client (v7) Raghav Gururajan
2021-02-09 10:22   ` Leo Prikler
2021-02-13 20:36     ` [bug#45889] Nextcloud Client (v8) Raghav Gururajan
2021-02-13 21:47       ` Leo Prikler
2021-02-13 23:54         ` Raghav Gururajan
2021-02-14  0:47           ` [bug#45889] Nextcloud Client (v9) Raghav Gururajan
2021-02-14 10:53           ` [bug#45889] Nextcloud Client (v8) Leo Prikler
2021-02-18 20:23             ` [bug#45889] Nextcloud Client (v10) Raghav Gururajan via Guix-patches via
2021-02-18 22:26               ` Leo Prikler
2021-02-21 17:04                 ` Raghav Gururajan via Guix-patches via
2021-02-21 17:45                   ` Leo Prikler
2021-02-21 18:09                     ` [bug#45889] Nextcloud Client (v11) Raghav Gururajan via Guix-patches via
2021-02-21 18:22                       ` Leo Prikler
2021-02-21 18:50                         ` [bug#45889] Nextcloud Client (v12) Raghav Gururajan via Guix-patches via
2021-02-21 19:37                           ` Leo Prikler
2021-02-22 17:29                             ` [bug#45889] Nextcloud Client (v13) Raghav Gururajan via Guix-patches via
2021-02-23 14:27                               ` [bug#45889] Nextcloud Client (v14) Raghav Gururajan via Guix-patches via
2021-02-23 17:58                                 ` Leo Prikler [this message]
2021-03-09  6:00                                   ` [bug#45889] Nextcloud Client (v15) Raghav Gururajan via Guix-patches via
2021-03-09  7:03                                     ` Leo Prikler
2021-03-09 10:50                                       ` [bug#45889] Nextcloud Client (v16) Raghav Gururajan via Guix-patches via
2021-03-09 11:39                                         ` Leo Prikler
2021-03-09 12:29                                           ` Raghav Gururajan via Guix-patches via
2021-03-09 12:43                                             ` [bug#45889] Nextcloud Client (v17) Leo Prikler
2021-03-09 15:16                                               ` [bug#45889] Nextcloud Client (v18) Raghav Gururajan via Guix-patches via
2021-03-09 23:24                                                 ` bug#45889: " Leo Prikler
2021-03-10  3:46                                                   ` [bug#45889] " Raghav Gururajan via Guix-patches via
2021-03-11  6:45                                                     ` Raghav Gururajan via Guix-patches via
2021-03-11  6:49                                                       ` Leo Prikler
2021-03-11  7:44                                                         ` Raghav Gururajan via Guix-patches via
2021-03-12  9:25                                                   ` david larsson
2021-03-12  9:47                                                     ` Raghav Gururajan via Guix-patches via
2021-02-21 18:22                       ` [bug#45889] Nextcloud Client (v11) Raghav Gururajan via Guix-patches via
2021-02-09 12:53   ` [bug#45889] Nextcloud Client (v7) Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df1c11b05a7a2920efe4859a9cf8ad66ee4dbf93.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=45889@debbugs.gnu.org \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).