unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#64224] [PATCH] gnu: Add python-cloup.
@ 2023-06-22 11:36 Daniel Meißner via Guix-patches via
  2023-06-22 14:24 ` [bug#64224] [PATCH v2] " jgart via Guix-patches via
  2023-07-12  6:28 ` bug#64224: [PATCH] " jgart via Guix-patches via
  0 siblings, 2 replies; 6+ messages in thread
From: Daniel Meißner via Guix-patches via @ 2023-06-22 11:36 UTC (permalink / raw)
  To: 64224; +Cc: Daniel Meißner, Lars-Dominik Braun, jgart

From: Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>

* gnu/packages/python-xyz.scm (python-cloup): New variable.
---
 gnu/packages/python-xyz.scm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index af9dd45d6e..151f608adf 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -106,7 +106,7 @@
 ;;; Copyright © 2021 Franck Pérignon <franck.perignon@univ-grenoble-alpes.fr>
 ;;; Copyright © 2021, 2022 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 Simon Streit <simon@netpanic.org>
-;;; Copyright © 2021 Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>
+;;; Copyright © 2021, 2022, 2023 Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>
 ;;; Copyright © 2021, 2022 Pradana Aumars <paumars@courrier.dev>
 ;;; Copyright © 2021, 2022 Felix Gruber <felgru@posteo.net>
 ;;; Copyright © 2021 Sébastien Lerique <sl@eauchat.org>
@@ -4578,6 +4578,28 @@ (define-public python-cligj
 well-tested and interoperable CLIs for handling GeoJSON.")
     (license license:bsd-3)))
 
+(define-public python-cloup
+  (package
+    (name "python-cloup")
+    (version "2.1.1")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "cloup" version))
+              (sha256
+               (base32
+                "05c6cjpnf9s72gyn5dckxbmd8rf2kgdzfsl7pqzrnc1lcdl13zmv"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-click))
+    (native-inputs (list python-setuptools python-pytest))
+    (home-page "https://github.com/janLuke/cloup")
+    (synopsis "Extension library for python-click")
+    (description
+     "Cloup — originally from ``Click + option groups'' — enriches Click with
+several features that make it more expressive and configurable: option groups,
+constraints, subcommand aliases, subcommands sections and a themeable
+HelpFormatter.")
+    (license license:bsd-3)))
+
 (define-public python-vcversioner
   (package
     (name "python-vcversioner")

base-commit: bb09f3ac002a4f34177d42fd3ea0332f4b7fe7a6
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#64224] [PATCH v2] gnu: Add python-cloup.
  2023-06-22 11:36 [bug#64224] [PATCH] gnu: Add python-cloup Daniel Meißner via Guix-patches via
@ 2023-06-22 14:24 ` jgart via Guix-patches via
  2023-06-22 19:32   ` Lars-Dominik Braun
                     ` (2 more replies)
  2023-07-12  6:28 ` bug#64224: [PATCH] " jgart via Guix-patches via
  1 sibling, 3 replies; 6+ messages in thread
From: jgart via Guix-patches via @ 2023-06-22 14:24 UTC (permalink / raw)
  To: 64224; +Cc: Daniel Meißner, jgart, Lars-Dominik Braun, jgart

From: Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>

* gnu/packages/python-xyz.scm (python-cloup): New variable.

Co-authored-by: jgart <jgart@dismail.de>
---

Hi,

Thanks for the patch. Here is a v2 that simplifies the home-page
description a bit and removes the native-input of setuptools, since it
is not needed.

Lars,

Do you happen to know why pytest is still required here even though we
are using pyproject-build-system? Is there a thread you can point me to
that explains that? Not sure I understand why this is the case yet from
reading the code for that build-system.

all best,

jgart

 gnu/packages/python-xyz.scm | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index b650b71f3b..5dcd6b9138 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -106,7 +106,7 @@
 ;;; Copyright © 2021 Franck Pérignon <franck.perignon@univ-grenoble-alpes.fr>
 ;;; Copyright © 2021, 2022 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 Simon Streit <simon@netpanic.org>
-;;; Copyright © 2021 Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>
+;;; Copyright © 2021, 2022, 2023 Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>
 ;;; Copyright © 2021, 2022 Pradana Aumars <paumars@courrier.dev>
 ;;; Copyright © 2021, 2022 Felix Gruber <felgru@posteo.net>
 ;;; Copyright © 2021 Sébastien Lerique <sl@eauchat.org>
@@ -4578,6 +4578,27 @@ (define-public python-cligj
 well-tested and interoperable CLIs for handling GeoJSON.")
     (license license:bsd-3)))
 
+(define-public python-cloup
+  (package
+    (name "python-cloup")
+    (version "2.1.1")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "cloup" version))
+              (sha256
+               (base32
+                "05c6cjpnf9s72gyn5dckxbmd8rf2kgdzfsl7pqzrnc1lcdl13zmv"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-click))
+    (native-inputs (list python-pytest))
+    (home-page "https://github.com/janLuke/cloup")
+    (synopsis "Extension library for python-click")
+    (description
+     "Cloup enriches Click with several features that make it more expressive
+and configurable such as option groups, constraints, subcommand aliases,
+subcommands sections and a themeable HelpFormatter.")
+    (license license:bsd-3)))
+
 (define-public python-vcversioner
   (package
     (name "python-vcversioner")

base-commit: 8b6bc4b2aa579193306cdc7a28f788c9afb4e039
prerequisite-patch-id: b40ddb3f1c2f780c18f34b826b1229bb10358ec7
prerequisite-patch-id: 35ea140df746960cf9b020cb8abb74e6889b056c
-- 
2.40.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#64224] [PATCH v2] gnu: Add python-cloup.
  2023-06-22 14:24 ` [bug#64224] [PATCH v2] " jgart via Guix-patches via
@ 2023-06-22 19:32   ` Lars-Dominik Braun
  2023-06-23  7:41   ` Daniel Meißner via Guix-patches via
  2023-06-23 14:20   ` jgart via Guix-patches via
  2 siblings, 0 replies; 6+ messages in thread
From: Lars-Dominik Braun @ 2023-06-22 19:32 UTC (permalink / raw)
  To: jgart; +Cc: Daniel Meißner, 64224

Hi jgart,

> Do you happen to know why pytest is still required here even though we
> are using pyproject-build-system? Is there a thread you can point me to
> that explains that? Not sure I understand why this is the case yet from
> reading the code for that build-system.

pytest is always required as an input when used for testing. It is never
pulled in automatically, but its presence decides which testing framework
will be used (i.e. pytest is present → use pytest).

Lars





^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#64224] [PATCH v2] gnu: Add python-cloup.
  2023-06-22 14:24 ` [bug#64224] [PATCH v2] " jgart via Guix-patches via
  2023-06-22 19:32   ` Lars-Dominik Braun
@ 2023-06-23  7:41   ` Daniel Meißner via Guix-patches via
  2023-06-23 14:20   ` jgart via Guix-patches via
  2 siblings, 0 replies; 6+ messages in thread
From: Daniel Meißner via Guix-patches via @ 2023-06-23  7:41 UTC (permalink / raw)
  To: jgart, 64224; +Cc: Daniel Meißner, jgart

Hi jgart,

jgart <jgart@dismail.de> writes:

> From: Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>
>
> * gnu/packages/python-xyz.scm (python-cloup): New variable.
>
> Co-authored-by: jgart <jgart@dismail.de>
> ---
>
> Hi,
>
> Thanks for the patch. Here is a v2 that simplifies the home-page
> description a bit and removes the native-input of setuptools, since it
> is not needed.

Thanks for your v2.  Weirdly enough, I thought I had tested it without
setuptools and it did not work.  However, I tested it again and now it
works for me also.  Thanks for your improvements.  LGTM.

Best

-- 
Daniel




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#64224] [PATCH v2] gnu: Add python-cloup.
  2023-06-22 14:24 ` [bug#64224] [PATCH v2] " jgart via Guix-patches via
  2023-06-22 19:32   ` Lars-Dominik Braun
  2023-06-23  7:41   ` Daniel Meißner via Guix-patches via
@ 2023-06-23 14:20   ` jgart via Guix-patches via
  2 siblings, 0 replies; 6+ messages in thread
From: jgart via Guix-patches via @ 2023-06-23 14:20 UTC (permalink / raw)
  To: Daniel Meißner, 64224; +Cc: Daniel Meißner

Cool, I'll push this later today after I finish work. I'd like to review it one more time.

all best,

jgart




^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#64224: [PATCH] gnu: Add python-cloup.
  2023-06-22 11:36 [bug#64224] [PATCH] gnu: Add python-cloup Daniel Meißner via Guix-patches via
  2023-06-22 14:24 ` [bug#64224] [PATCH v2] " jgart via Guix-patches via
@ 2023-07-12  6:28 ` jgart via Guix-patches via
  1 sibling, 0 replies; 6+ messages in thread
From: jgart via Guix-patches via @ 2023-07-12  6:28 UTC (permalink / raw)
  To: Daniel Meißner, 64224-done; +Cc: control

Hi Daniel,

Thanks for the patch. APPLIED.

all best,

jgart




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-07-12  6:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-22 11:36 [bug#64224] [PATCH] gnu: Add python-cloup Daniel Meißner via Guix-patches via
2023-06-22 14:24 ` [bug#64224] [PATCH v2] " jgart via Guix-patches via
2023-06-22 19:32   ` Lars-Dominik Braun
2023-06-23  7:41   ` Daniel Meißner via Guix-patches via
2023-06-23 14:20   ` jgart via Guix-patches via
2023-07-12  6:28 ` bug#64224: [PATCH] " jgart via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).