From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8Hc6JpfyIGKBJAEAgWs5BA (envelope-from ) for ; Thu, 03 Mar 2022 17:53:43 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +EkmH5fyIGJZcAEAG6o9tA (envelope-from ) for ; Thu, 03 Mar 2022 17:53:43 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 96436199B8 for ; Thu, 3 Mar 2022 17:53:42 +0100 (CET) Received: from localhost ([::1]:46976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPohx-0002WJ-1E for larch@yhetil.org; Thu, 03 Mar 2022 11:53:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPohK-00022A-C6 for guix-patches@gnu.org; Thu, 03 Mar 2022 11:53:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPohJ-0000un-Jt for guix-patches@gnu.org; Thu, 03 Mar 2022 11:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nPohJ-0001dI-Ih for guix-patches@gnu.org; Thu, 03 Mar 2022 11:53:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54221] [PATCH 3/4] gnu: vim: Update package style. Resent-From: SeerLite Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 03 Mar 2022 16:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54221 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 54221@debbugs.gnu.org Received: via spool by 54221-submit@debbugs.gnu.org id=B54221.16463263406211 (code B ref 54221); Thu, 03 Mar 2022 16:53:01 +0000 Received: (at 54221) by debbugs.gnu.org; 3 Mar 2022 16:52:20 +0000 Received: from localhost ([127.0.0.1]:43555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPogS-0001bq-8N for submit@debbugs.gnu.org; Thu, 03 Mar 2022 11:52:20 -0500 Received: from mx.nixnet.email ([94.16.121.167]:40372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPogQ-0001bg-4B for 54221@debbugs.gnu.org; Thu, 03 Mar 2022 11:52:06 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mx.nixnet.email (Postfix) with ESMTPSA id E6257200232; Thu, 3 Mar 2022 11:52:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nixnet.email; s=202002021149; t=1646326322; h=from:from:reply-to:subject:subject:to:to:cc; bh=cAvDFXCAKhr6minD9t/JDWUp0u6tRBJ6zxzq2yF/fyA=; b=fNHkzmOkw9jIf38PWmdzEzBvMpECAA/ZCdg7W6clRkWTh+pR5wnIMAJZB2qxshMcXx6OL0 rE0jfD2f9XIh19jyKNDwxbGTjht10tyVtmUl8YszD90nWfiwt4Kczvv8DhT+2B9dRT+uiI C++d9tbv2devxq+awk2pMZSUTNGis8g= Message-ID: Date: Thu, 3 Mar 2022 13:49:44 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US References: <6002b969ed2f353fef0e8fa87d4fc7d01d3344fa.camel@telenet.be> In-Reply-To: <6002b969ed2f353fef0e8fa87d4fc7d01d3344fa.camel@telenet.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: SeerLite X-ACL-Warn: , SeerLite via Guix-patches From: SeerLite via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646326423; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cAvDFXCAKhr6minD9t/JDWUp0u6tRBJ6zxzq2yF/fyA=; b=cGOfiaaUF0AZEJMyxcgb413D34MzNiNgPilefLz+uoBpwX5DXjlSb5fI4oSkM+ywksYy+a WNIXO2ud3x5HE4gIR1Oje3Ul0AcJa1JmTkjmFNE/NztRbrOzcVeOTytCIzcH2qiWdR5FKS RZN8jH9I3s8Wms0JB/KFAiJa6FNtbXxx+QN/xHgPbhBHmVAw0BJMhka1zeqre0i3vHrGJz h3xLAvMdUhEsNo7jI2j1+mtLP475FzEUOxEQ8WxhxVCvBuVKSCK4B6p5Zd2+k9ASBTJiCm 5AuOIAaUEx6NYVNEVakCk2gBwz89969UtnpwnVCBZoey8Dwuj9WjQW+X/1aa3g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646326423; a=rsa-sha256; cv=none; b=htm2fJXIY3Ms13jF1BDvBceQ3VLrzZLWM5E1jEYlikCVXFRZTyZp2aLGUm1FlNETqn3bQn HOqpRNGTWn47KIIWhm8bKiGYYJQG198NKyWRAyXjdQD6fVnUIwtkEwYrnUIULGKCPvmO1e HTHIX6YhCVahQeu65Ct9k4xprsNRC0SPioEvdTXIg3VOv2MwI2GQ/mVfhLV3cmVuoUZ8eV vnZHF2i35gCZ6tBHVC14XoglYFPaIn24gNjhgORbIIPWStw0dhUy+KzK4lcKCDsPDFC9yh /oMuBjtsecjwuyf2WZ6/TOMxSun4gkSX1/+pa9JxEqrhbcWP7qRk6EFfqkvT4w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nixnet.email header.s=202002021149 header.b=fNHkzmOk; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.06 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nixnet.email header.s=202002021149 header.b=fNHkzmOk; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 96436199B8 X-Spam-Score: -4.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: Ylzg+3NolWOZ Hi, thanks for the review! On 3/2/22 14:29, Maxime Devos wrote: > This is test stuff, and these binaries do not seem to be present in > 'inputs', they would be in the implicit 'native-inputs', so these would > need to search in '(or native-inputs inputs)' instead of 'inputs' to > avoid &search-path exceptions when cross-compiling: > > (substitute* '("src/testdir/...") > (("/bin/sh") (search-input-file (or native-inputs inputs) "bin/sh"))) > > Or simpler, there's a procedure for looking for 'bin/TOOL' in native- > inputs: 'which'! > > ;; the original code! > (substitute* '("src/testdir/...") > (("/bin/sh") (which "sh"))) Whoops, I forgot I made this change. > Why the change from 'which' to 'search-input-file'? The blog post that introduces label-less inputs also introduces 'search-input-file', which made me think they were both part of the "package definition modernization process". I asked on IRC if that was the case, and although I didn't get a clear answer for that, someone told me they preferred using 'search-input-file' because it raises an exception when no file is found. What do you think about that? Should I stick with 'search-input-file' or is 'which' alright? It makes sense that I'd have to use native-inputs though. My bad!