* [bug#73210] [PATCH] gnu: smalltalk: Fix tests.
@ 2024-09-12 19:38 Greg Hogan
2024-09-13 9:59 ` Guillaume Le Vaillant
0 siblings, 1 reply; 6+ messages in thread
From: Greg Hogan @ 2024-09-12 19:38 UTC (permalink / raw)
To: 73210; +Cc: Greg Hogan
* gnu/packages/smalltalk.scm (smalltalk)[native-inputs]: Add
'(libc-utf8-locales-for-target)'.
Change-Id: Idf49394e5c4dbd3398a6774319184339ed18585c
---
gnu/packages/smalltalk.scm | 1 +
1 file changed, 1 insertion(+)
diff --git a/gnu/packages/smalltalk.scm b/gnu/packages/smalltalk.scm
index 64146813d1f..988410d93d9 100644
--- a/gnu/packages/smalltalk.scm
+++ b/gnu/packages/smalltalk.scm
@@ -62,6 +62,7 @@ (define-public smalltalk
(build-system gnu-build-system)
(native-inputs
(list pkg-config
+ (libc-utf8-locales-for-target)
;; XXX: To be removed with the next release of Smalltalk.
autoconf
automake
base-commit: d4869b7e43d823bccc8f6d81dd9f5d2c13cb8f25
--
2.46.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#73210] [PATCH] gnu: smalltalk: Fix tests.
2024-09-12 19:38 [bug#73210] [PATCH] gnu: smalltalk: Fix tests Greg Hogan
@ 2024-09-13 9:59 ` Guillaume Le Vaillant
2024-09-13 12:18 ` Greg Hogan
0 siblings, 1 reply; 6+ messages in thread
From: Guillaume Le Vaillant @ 2024-09-13 9:59 UTC (permalink / raw)
To: Greg Hogan; +Cc: 73210
[-- Attachment #1: Type: text/plain, Size: 2700 bytes --]
Hi.
I tried your patch, but some tests are still failing for me.
More specifically, the "ANSI compliancy tests" are all failing with the
same error:
--8<---------------cut here---------------start------------->8---
--- ./tests/testsuite.dir/046/testsuite.log ---------------------------------
# -*- compilation -*-
46. testsuite.at:82: testing ArrayANSITest ...
{ (cd /tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91 && timeout 600s gst -I /tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/tests/gst.im -f /tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91
/tests/AnsiRun.st ArrayANSITest); echo exit 0 > retcode; } | tr -d '\r' | tee stdout; . ./retcode
./testsuite.at:82: { (cd $abs_top_builddir && $TIMEOUT gst $image_path -f $abs_srcdir/AnsiRun.st ArrayANSITest); echo exit $? > retcode; } | tr -d '\r' | tee stdout; . ./retcode
--- /dev/null 2024-09-13 06:57:13.374888392 +0000
+++ /tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/tests/testsuite.dir/at-groups/46/stderr 2024-09-13 09:48:39.319595098 +0000
@@ -0,0 +1,13 @@
+gst: Aborted
+gst: Error occurred while not in byte code interpreter!!
+/tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/libgst/.libs/libgst.so.7(+0x728f7)[0x7ffff7f568f7]
+/gnu/store/zvlp3n8iwa1svxmwv4q22pv1pb1c9pjq-glibc-2.39/lib/libc.so.6(+0x3e560)[0x7ffff7b87560]
+/gnu/store/zvlp3n8iwa1svxmwv4q22pv1pb1c9pjq-glibc-2.39/lib/libc.so.6(+0x883fc)[0x7ffff7bd13fc]
+/gnu/store/zvlp3n8iwa1svxmwv4q22pv1pb1c9pjq-glibc-2.39/lib/libc.so.6(gsignal+0x12)[0x7ffff7b874c2]
+/gnu/store/zvlp3n8iwa1svxmwv4q22pv1pb1c9pjq-glibc-2.39/lib/libc.so.6(abort+0xc9)[0x7ffff7b714a3]
+/tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/libgst/.libs/libgst.so.7(+0x10c19)[0x7ffff7ef4c19]
+/gnu/store/q46ljxrs7jh0r7qniqdcjvz3kny9226f-libsigsegv-2.14/lib/libsigsegv.so.2(+0x1288)[0x7ffff7edf288]
+/gnu/store/zvlp3n8iwa1svxmwv4q22pv1pb1c9pjq-glibc-2.39/lib/libc.so.6(+0x3e560)[0x7ffff7b87560]
+/tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/libgst/.libs/libgst.so.7(+0x56e48)[0x7ffff7f3ae48]
+/tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/libgst/.libs/libgst.so.7(+0x72469)[0x7ffff7f56469]
+/tmp/guix-build-smalltalk-3.2.91.drv-0/smalltalk-3.2.91/tests/testsuite.dir/at-groups/46/test-source: line 20: 22611 Aborted $TIMEOUT gst $image_path -f $abs_srcdir/AnsiRun.st ArrayANSITest
stdout:
./testsuite.at:82: exit code was 134, expected 0
46. testsuite.at:82: 46. ArrayANSITest (testsuite.at:82): FAILED (testsuite.at:82)
--8<---------------cut here---------------end--------------->8---
Does the build work for you every time?
What architecture are you using? I'm on x86-64 Guix system.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#73210] [PATCH] gnu: smalltalk: Fix tests.
2024-09-13 9:59 ` Guillaume Le Vaillant
@ 2024-09-13 12:18 ` Greg Hogan
2024-09-13 17:23 ` Guillaume Le Vaillant
0 siblings, 1 reply; 6+ messages in thread
From: Greg Hogan @ 2024-09-13 12:18 UTC (permalink / raw)
To: Guillaume Le Vaillant; +Cc: 73210
On Fri, Sep 13, 2024 at 5:59 AM Guillaume Le Vaillant <glv@posteo.net> wrote:
>
> Hi.
> I tried your patch, but some tests are still failing for me.
> More specifically, the "ANSI compliancy tests" are all failing with the
> same error:
>
> [...]
>
> Does the build work for you every time?
> What architecture are you using? I'm on x86-64 Guix system.
I have built the package two more times without errors (though the
output is non-deterministic). The only error I have seen was the I18N
test failure before adding this locales patch.
My system is x86-64 on a foreign distro.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#73210] [PATCH] gnu: smalltalk: Fix tests.
2024-09-13 12:18 ` Greg Hogan
@ 2024-09-13 17:23 ` Guillaume Le Vaillant
2024-09-13 19:56 ` Greg Hogan
0 siblings, 1 reply; 6+ messages in thread
From: Guillaume Le Vaillant @ 2024-09-13 17:23 UTC (permalink / raw)
To: Greg Hogan; +Cc: 73210
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
Greg Hogan <code@greghogan.com> skribis:
> On Fri, Sep 13, 2024 at 5:59 AM Guillaume Le Vaillant <glv@posteo.net> wrote:
>>
>> Hi.
>> I tried your patch, but some tests are still failing for me.
>> More specifically, the "ANSI compliancy tests" are all failing with the
>> same error:
>>
>> [...]
>>
>> Does the build work for you every time?
>> What architecture are you using? I'm on x86-64 Guix system.
>
> I have built the package two more times without errors (though the
> output is non-deterministic). The only error I have seen was the I18N
> test failure before adding this locales patch.
>
> My system is x86-64 on a foreign distro.
Given that the patch is correct (adding a missing input), I applied it
as 22a34ea792ef0df15fd30d46f557b572c61d5404.
The build farm built it fine for i686, but on x86-64 it got the same
error as me (https://ci.guix.gnu.org/build/5765437/details).
A strange thing is that if I keep the files of the failed build (with
"guix build -K") and then run the tests by hand, they all succeed.
I wonder where the difference with what you get could come from...
What CPU does your machine have? And how much RAM?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#73210] [PATCH] gnu: smalltalk: Fix tests.
2024-09-13 17:23 ` Guillaume Le Vaillant
@ 2024-09-13 19:56 ` Greg Hogan
2024-09-14 9:12 ` bug#73210: " Guillaume Le Vaillant
0 siblings, 1 reply; 6+ messages in thread
From: Greg Hogan @ 2024-09-13 19:56 UTC (permalink / raw)
To: Guillaume Le Vaillant; +Cc: 73210
On Fri, Sep 13, 2024 at 1:23 PM Guillaume Le Vaillant <glv@posteo.net> wrote:
>
> A strange thing is that if I keep the files of the failed build (with
> "guix build -K") and then run the tests by hand, they all succeed.
>
> I wonder where the difference with what you get could come from...
> What CPU does your machine have? And how much RAM?
It's an AWS r7a (AMD EPYC 9R14), typically the smallest variant (2 CPU
threads, 16 GiB RAM).
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#73210: [PATCH] gnu: smalltalk: Fix tests.
2024-09-13 19:56 ` Greg Hogan
@ 2024-09-14 9:12 ` Guillaume Le Vaillant
0 siblings, 0 replies; 6+ messages in thread
From: Guillaume Le Vaillant @ 2024-09-14 9:12 UTC (permalink / raw)
To: Greg Hogan; +Cc: 73210-done
[-- Attachment #1: Type: text/plain, Size: 84 bytes --]
For now I disabled the tests on x86-64 in
607280fa8fe26b500ad76a3769da8e4f917cae16.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-09-14 9:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-12 19:38 [bug#73210] [PATCH] gnu: smalltalk: Fix tests Greg Hogan
2024-09-13 9:59 ` Guillaume Le Vaillant
2024-09-13 12:18 ` Greg Hogan
2024-09-13 17:23 ` Guillaume Le Vaillant
2024-09-13 19:56 ` Greg Hogan
2024-09-14 9:12 ` bug#73210: " Guillaume Le Vaillant
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).