unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: phodina <phodina@protonmail.com>, 51774@debbugs.gnu.org
Subject: [bug#51774] [PATCH] gnu: Add font-source-code-pro.
Date: Mon, 15 Nov 2021 20:56:21 +0100	[thread overview]
Message-ID: <dc9954eff77ad2058f1e4734f3871200b3e5ee1b.camel@gmail.com> (raw)
In-Reply-To: <yaiXSsoCVrMLglAyuuVFr8pFMnywqiYWZObBrjY-CIRWOHGVgCjkXe3BmjXpDFbBzYzuBbpBYu9WSbCgUKGMqLUEv4zPPRgSHPHdz74ayRs=@protonmail.com>

Hi,

Am Donnerstag, den 11.11.2021, 19:22 +0000 schrieb phodina:
> * gnu/packages/fonts.scm (font-source-code-pro): New variable.
> 
> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
> index 3f36a71bdd..9ac7e9e127 100644
> --- a/gnu/packages/fonts.scm
> +++ b/gnu/packages/fonts.scm
> @@ -1470,6 +1470,26 @@ (define-public font-sarasa-gothic
>       "Sarasa Gothic is a programming font based on Iosevka and
> Source Han Sans,
>  most CJK characters are same height, and double width as ASCII
> characters.")))
> 
> +(define-public font-source-code-pro
> +  (package
> +    (name "font-source-code-pro")
> +    (version "2.038")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "
> https://github.com/adobe-fonts/source-code-pro")
> +                    (commit (string-append version "R-ro/1.058R-
> it/1.018R-VAR"))))
Am I allowed to ask WTF this versioning scheme is?  Should we just pin
a hash instead?
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "00h4v3rmxyyaxni6nywacxvjnji2g2pi0b4js1yx0g67fvrv2ga
> g"))))
> +    (build-system font-build-system)
> +    (synopsis "Font for coding environments")
> +    (description "Font Source Code Pro is sedigned as a companion to
> Source
> +Sans.")
This scrediption is not very scrediptive ;)  Jokes aside, I'd add "[It]
preserves the design features and vertical proportions of Source Sans,
but alters the glyph widths so that they are uniform across all glyphs
and weights." so that Adobe bois know what they're getting.
> +    (home-page "https://fonts.google.com/specimen/Source+Code+Pro")
I'm not sure whether linking to Google fonts of all places is good
praxis.  Might want to link to Github instead.  FWIW the repo
advertises this: https://adobe-fonts.github.io/source-code-pro/

Cheers





  reply	other threads:[~2021-11-15 19:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 19:22 [bug#51774] [PATCH] gnu: Add font-source-code-pro phodina via Guix-patches via
2021-11-15 19:56 ` Liliana Marie Prikler [this message]
2021-11-15 22:12   ` phodina via Guix-patches via
2021-11-16 19:07 ` [bug#51774] [PATCH v2] gnu: font-adobe-source-code-pro: Update to 2.032R-ro-1.052R-it-1.012R-VAR phodina via Guix-patches via
2021-11-16 20:29   ` Liliana Marie Prikler
2021-11-17 12:25     ` phodina via Guix-patches via
2021-11-17 17:17       ` bug#51774: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc9954eff77ad2058f1e4734f3871200b3e5ee1b.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=51774@debbugs.gnu.org \
    --cc=phodina@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).