From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oFNxDtm6XmFzCgEAgWs5BA (envelope-from ) for ; Thu, 07 Oct 2021 11:16:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YB37Cdm6XmH+FQAAbx9fmQ (envelope-from ) for ; Thu, 07 Oct 2021 09:16:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C07672EB59 for ; Thu, 7 Oct 2021 11:16:08 +0200 (CEST) Received: from localhost ([::1]:55362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYPVX-0004cE-QL for larch@yhetil.org; Thu, 07 Oct 2021 05:16:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYPVT-0004bo-51 for guix-patches@gnu.org; Thu, 07 Oct 2021 05:16:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34509) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYPVS-0000gy-I6 for guix-patches@gnu.org; Thu, 07 Oct 2021 05:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYPVS-0007qm-7s for guix-patches@gnu.org; Thu, 07 Oct 2021 05:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50960] [PATCH 00/10] Add 'guix shell' to subsume 'guix environment' Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 07 Oct 2021 09:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50960 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Konrad Hinsen Cc: 50960@debbugs.gnu.org Received: via spool by 50960-submit@debbugs.gnu.org id=B50960.163359812730128 (code B ref 50960); Thu, 07 Oct 2021 09:16:02 +0000 Received: (at 50960) by debbugs.gnu.org; 7 Oct 2021 09:15:27 +0000 Received: from localhost ([127.0.0.1]:46055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYPUt-0007ps-0I for submit@debbugs.gnu.org; Thu, 07 Oct 2021 05:15:27 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYPUq-0007pe-Vq for 50960@debbugs.gnu.org; Thu, 07 Oct 2021 05:15:25 -0400 Received: by mail-wr1-f67.google.com with SMTP id i12so4317386wrb.7 for <50960@debbugs.gnu.org>; Thu, 07 Oct 2021 02:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=lR4kBv1Z4qYy5xVwzl+pwfwN0ApsXbNpi1YQaUWNQh8=; b=OopKjuEgTuXGqXNlZoMA3ioDYh9qYfp1g6jUaeemy3Eba9mEFHOJWiY76dw1/LHygj 2ScORdUdivmdWBBDmAp6ZF5URq+A7GOfQxKGmcx6owJcsLQGcMfaXXI6lqPZgYloTMFV ojmsn4GhmOyaNVYP4JZDaCgzrdzrf0jRx0shap9PBewqMr5l48rFx81xD97PgwZBQzOY lBsAiNb2Xj/lmoNBSwClYK/ylmRhI2zcSRx/3Hk7vai4YT/XL/KjSfL09/cRbP9OClmM lHaUeOAjO5bnHqV9GTAazHcK4bfqt6RRcE0UVBgc+tlxnPlbzm3L2E5LV2/r93YD1XcN +VLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=lR4kBv1Z4qYy5xVwzl+pwfwN0ApsXbNpi1YQaUWNQh8=; b=SC5UBOxyRRZOj5ANDv5DbY1ttmqnie9HDxOzlh1jp94UzvreHxgqQtQTHtAMDldEkl EdT9p+hxozDP4cgdNCJzEPd0iR7W76wsliASzCU9gJsLHS2uPy082lt/BP0+Bnz9ru3q YjhdtPsvxV+80WiMJvyacu1II04m3h+9aNNVcInAKlpmqwYm9vjHBME8ZRIezmoke/n4 6Hx/ZcagJ9EpAgihrM54iDEhoW7pO+Iul22KynDQ4cNnw6t/06ZqGOV+xEUoaWpV7EM5 apZUpMBfh1ktzuzRiaxod7aS2AMYLh4C+KM5FI0r9adHJGhrisDA3ftYEoqaFQ+0HEdW BcUQ== X-Gm-Message-State: AOAM533NUDVhXDJG+CKAFHAlVkzt5JUiP3AhSfx2cOk/9P7V2v8WZqPW 7r01yf3Uyyw2md9askPwMtE= X-Google-Smtp-Source: ABdhPJwPAZwcHVZvncaIwzDwFrkKxrRM6lazRQmvr8PzcsvjVHUazf6l0DhX0wwcM1g/PXvbcfFeAQ== X-Received: by 2002:a05:600c:1c93:: with SMTP id k19mr15098736wms.80.1633598119146; Thu, 07 Oct 2021 02:15:19 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id v191sm8255405wme.36.2021.10.07.02.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Oct 2021 02:15:18 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Thu, 07 Oct 2021 11:15:16 +0200 In-Reply-To: <87mtnlfd2n.fsf_-_@gnu.org> References: <20211002102116.27726-1-ludo@gnu.org> <87mtnlfd2n.fsf_-_@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633598168; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lR4kBv1Z4qYy5xVwzl+pwfwN0ApsXbNpi1YQaUWNQh8=; b=BSkb1hTPa0JEoXVZFsdKzxPrpISRmR4dS/W11u0JyJguxx5WOKVzx2Y5iS9NSDqlSt9IN3 GeKSHLFi+NfvtNNieqsNQDJaJ/k5gx/G/OZPlCJ6NgRmiYCLBV/ei+Nqn1YUWV5fPo6ex3 s7+DuM3IV4s8fOY3vRBNNMt8HDQr4Q8r4QUM7g+4Nd9CAtNBNzvb4z9uLbTrvRppSjE1Mf g/L6mAhvLymeVNcvNh+1cGunAqJHwwXK6f7dWliQSTxMR7lB+1iMIwfz9cB7w8iDYILQ2M TkXK6Cvr0ZCVD+x3zXEczsyX5qduQvpGLGyOUmXhmDVr0tVAicBXAHVRKLcxrQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633598168; a=rsa-sha256; cv=none; b=PtKEp3RIlUv0XaNMM/VjxowyQN/cs4paOyKlaQUGKLNaBXYOrZrs6glL/0+vUNArIX9HGm 4SIasmQd5Hl364kf+dOEYwLc4RI8nqXWMl2JLeBWC9FLSu3TOEm0DK9440cCouuoY3unHK Y3MrMsSDwg3Vy878ZeJ130mTA+5DS2viw0Y1Z/ih72yDH2IjX/j0TFptAI99Mo+4Yeyi95 Z3hVj5EpFwqaztdjv2tCv0A4riWkikS5I6Itg3cd3gp1kHL2X3pY5/BHmndK5IZ8yCImO3 P57TNQafaEZx3onn9zedt/AzJLoVQ1Yxk8KJhaf/DJGKXgpkf9e5tmi2GNUZlA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=OopKjuEg; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.22 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=OopKjuEg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C07672EB59 X-Spam-Score: -0.22 X-Migadu-Scanner: scn1.migadu.com X-TUID: +Dgvpf8PY0OY Hi Ludo, Am Donnerstag, den 07.10.2021, 10:34 +0200 schrieb Ludovic Courtès: > > The behavior of "guix shell" with and without arguments is > > sufficiently different, which will make it a challenge to document, > > and then a challenge for users to understand. And part of the > > criticism related to the tacit execution of files is about the > > convenience for 1) vs. the risk in 2). > > ‘guix shell’ without arguments is equivalent to ‘guix environment -f > guix.scm’ or ‘guix environment -m manifest.scm’. > > > So... how about making this two different commands? They could of > > course share most of the implementation. > > > > I'd use "guix shell" for the scenario that actually starts a shell, > > and something different, perhaps "guix process", for the > > infrastructure command for use in scripts. > > I don’t think there’s enough to warrant two different commands (and > perhaps we could leave out the auto-detection of ‘guix.scm’ or > ‘manifest.scm’ is that proves to be too controversial). Leaving out the auto-detection of ‘guix.scm’ and ‘manifest.scm’ for now is a good idea, given that Guix itself would be an edge-case for that. Perhaps to avoid this trouble, guix shell could read a file that simply specifies which arguments to add one line at a time e.g. ;; .guix-shell-rc --manifest=manifest.scm or ;; .guix-shell-rc --load=guix.scm Similar behaviour is used in other (GNU) tools with lots of available arguments, which operate on a directory basis, e.g. stow. > Maybe you’re hinting at the name and the fact that it suggests it’s > starting a shell. I’m not fond of it, notably for that reason. For > the record, it came out as the only proposal that seemed viable to > me: > > https://issues.guix.gnu.org/38529#17 > > Thoughts? I think “guix shell” is fine as-is. People typically don't complain that “sh somefile.sh” doesn't launch a shell, so the same reasoning can be applied to Guix tools in my opinion. We would still have the always non-intuitive naming choices of “do”, “start” and “run” at our disposal if we ever need to discard the shell. Regards, Liliana