From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id sJTuMGJYy2UDlQAA62LTzQ:P1 (envelope-from ) for ; Tue, 13 Feb 2024 12:54:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id sJTuMGJYy2UDlQAA62LTzQ (envelope-from ) for ; Tue, 13 Feb 2024 12:54:10 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=troyfigiel.com header.s=MBO0001 header.b=zdrqskJw; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=troyfigiel.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707825250; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature:autocrypt:autocrypt; bh=R2+vuS+mS0l7QvY9tkLTKtvSMrRHq4CERZBZU0lyqmQ=; b=njHw+hN2vGoU83w4qPW/Uz3u0ew5O3RElAIgc2rM0mrOc8ZYKUZXQZ4VG/lCLapu4OSX9R oLYF3oKVE8if1fex2Kwlxg1U0KIcqf9/4lgxbdfGOsmoO/8Yd/Ggt/d6B+l8fA9zvEcFxu wK0ixxP29RiViJmuD3jbz1X7oi2T5KM5ni1wzCvwdMuxMKS6UYilnHWIrja7O806JUUqJ7 861cRViQ2fBnnbfBJcpgCcXP26VuCJNpP1l75UjghG6kaXufwJh+q39mJZuAKVGhyHH98l kuViItjud7Ejv+pqMkxLSUu8PsAgfmA5tCAywiZnBvrLv+7hiY1Ycwv1+XxdyQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=troyfigiel.com header.s=MBO0001 header.b=zdrqskJw; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=troyfigiel.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707825250; a=rsa-sha256; cv=none; b=p1g5sgJgeIAVqclJLGLW9hcbUoLiuNl11c5uU+NB4zh4rpaz/ObDqne/Py8POj9FkTj9e6 beOVCBqco7bfGemKFvnQsknX9CS7kpyxPK9uRQZKPqAM8i+YjRs2qE1B9E3TeCQVD//crL x2r7rvRTUdH8bkW3twp0Lr57tNrgAlKoMpEsnMw6I913Zwnk5TrJNLY4yepUswHiUwsqNE Zd6WtuA/e8F5+yKEMLDL+bMui5xfph8LpYmzKWB67F3fSv9zO7ryf9WbLXOykqGjafHt2J v6Oz+D5Y8Cj8fWboZlzdaAyQI/NQnFHTQjA5BPgsQjWtVP64HSSd1GqUsWQRKw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 489D043EE8 for ; Tue, 13 Feb 2024 12:54:10 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZrMB-00066Z-M1; Tue, 13 Feb 2024 06:53:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZrM9-00066B-Cj for guix-patches@gnu.org; Tue, 13 Feb 2024 06:53:45 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZrM9-0007Pn-52 for guix-patches@gnu.org; Tue, 13 Feb 2024 06:53:45 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZrMQ-0000B0-Af for guix-patches@gnu.org; Tue, 13 Feb 2024 06:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69074] [PATCH] Add python-angr. Resent-From: Troy Figiel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Feb 2024 11:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69074 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69074@debbugs.gnu.org Received: via spool by 69074-submit@debbugs.gnu.org id=B69074.1707825190555 (code B ref 69074); Tue, 13 Feb 2024 11:54:02 +0000 Received: (at 69074) by debbugs.gnu.org; 13 Feb 2024 11:53:10 +0000 Received: from localhost ([127.0.0.1]:42364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZrLa-00008s-6u for submit@debbugs.gnu.org; Tue, 13 Feb 2024 06:53:10 -0500 Received: from mout-p-201.mailbox.org ([80.241.56.171]:47202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZrLX-00008V-Uw for 69074@debbugs.gnu.org; Tue, 13 Feb 2024 06:53:09 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4TZ07Z49y1z9sZH for <69074@debbugs.gnu.org>; Tue, 13 Feb 2024 12:52:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=troyfigiel.com; s=MBO0001; t=1707825162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=R2+vuS+mS0l7QvY9tkLTKtvSMrRHq4CERZBZU0lyqmQ=; b=zdrqskJwGaa1VptQyMQRhOciOebWigfeTN0D4aM2h3O7v8HVACkvPfDKlciTrUOgs7YX2f F3UElNerVwXZWUnegwaBZ4Xmwo2NCF6IAX49usE3eSaKaO2OXMOD2h2q6B7CP7HW0y3yi7 vmn5bqFY905gKiWKlsidEE1efKrwx0CYNZJ7gxg3NWLyQ1B6TmzlVpTk9vmVOU3BF/jftf MVjMttNrV5Jk+apQsgjeaRIPlu0rqLX9iDrjwUJ/gZ6nVBCb45Hsc+FfYOGCzYoNUWDeuN bkLzeRg5LzkwHqCtCSI7s4w1KvSg8L6GePvG2cky2kMEyXz6O7WhL6pNMj01Tw== Message-ID: Date: Tue, 13 Feb 2024 12:52:41 +0100 MIME-Version: 1.0 Content-Language: en-US, de-DE References: <2T2LBWR63TVNP.3NFUJ8AHKFC01@8pit.net> From: Troy Figiel Autocrypt: addr=troy@troyfigiel.com; keydata= xsFNBGKp71YBEADDmh9HMTg0Z8/xxf4yT6UX2wO8u0Q2nbOAhzROSabUVyBp8Gz6jLcoFN8x rg8XxxBWTCENBWqKkYG6Z/GgPmeKuacAeZIW7dGYaGu4bZHgLsTqk04J/dM63aVveJJY4M4r KNx0Mew+SYTGrh3NnoSF0+ZIskGGh4NJpXOGUSUihjdddn8ouFDDy01GJ9N2ZWprfWo3ynMA xEHhD6CWniQMkmd+TVKjQt+BC8d+nHlOt6vFoDGH9PehXmmBLyOJAVMAlPMyrN8ZjmbRp91s 4Sz2rqjD2GXFGvKClhyxcr2qEUJmCg/Vp8PiZWOwxA/6BCWuNmrl1d1FhXjMMIzz2y92MOlD 5kQm7/261cuXTJvKZOLmHelY0m7gReWnc9peGPmGeukkdblmjwJTnetzvF/AUXNpS29Nmyie 4PgsAbkmL0PwKCbf+6WRWywRidR1narANINGJHL8MDIgdUwuJsYhD5s10bIsg2dOOxFioOnm kgpWiVLmZSq9bkX+SRyWNL+hDhEbGLnZ5WUOszPXgo9Lo2dCGBr4YkCaxVCCCfgAn8TpgcLQ VW37N75MjEX3kVBGBiiifbQUedKHqMddlUEYLSjpBCNxqF1X5fTuurFrfq8EYcYcQGW5Telh fX1I6md7xt0FDBRAVx8jAvy7Rkt6CeKP7oPNMVfoQ62oMT85JQARAQABzSFUcm95IEZpZ2ll bCA8dHJveUB0cm95ZmlnaWVsLmNvbT7CwY8EEwEKADkCGwMECwkIBwQVCgkIBRYCAwEAAh4F AheAFiEE5HwNzSdo36E4/NzWxnyRgbOJP7AFAmVCwP8CGQEACgkQxnyRgbOJP7DK/A/+L6IY xHhr4ZCz5Mk8s0OHAQTP3ZlAtmjMB+Lg0nwg8hVRzF1O/mCQKaFeKwKgh0I0zZIYucnylG6K KtVoa1ZNrpOCO2Qau7C/j6u7lmZGoEyEf9ePvhpVPcqFXSeehNl/nmaAFuLXTTTvkUubuU2m OEQe1oua/9HQPbd2mlKNjUnj9YmYs9qqF9bcJmT0U2WUg4Jz3DmHQiK175QqJv7fXtIdHzAk BRlJdrslLPOrIDb7WAnXpUQs1bcirKuSFOsyeGn0plh3t0uSm8d3BValRArPMw/h9FldGRXr KycSCIuU/vL94mncXSwIy8ifY4XkcBVvuZ8CbAh3G3iuZ6LLoMsjGmCXkm6Ru9OieC8xmAae 69RYw/zXHoIkW+/nLygEv7+7tMrYTFcUR0RmMvHjiZafnGwHkBCFMojUapcG/EAsSYQzssGP qYLuqIaq2weCYpfNUMDye3rivOKFcO6Aa63lCb1TLy/OVoK0al04WdO+teDJVj88WNyMZu1c SdBYd3lJ9VLSmsBJ0FFksuDyXQqmrN+Uckka+JdKHiADGGaztMHmbJkZ1DZ2jfEh0kJTcCr8 PAXIvTMcgi/BLP3R6u+iHnycypID8pwLIDg3Gg3cLcfeBmCBEAft/Gk5RF0POIL8QAx7IVwu AD4kpM6fkXc6Dq9sl6us38ekm6M7fprOwU0EYqnvVgEQANU4cn+tMmYLMMJA3yeE7JIlY5E+ xZ5qrvNA+UwqTuZGcQH3Th81fsF1qYYiT38fq6GAEImJ19VqVs9f/YGSdkUk1ZA46AwzPuij pFGUm3yL71kCzPblF1zUCzOllc1N7pi3YD+XQr7ggqX/s/MS1uxR9Sgs5coYUT0ygXVOGkSk OQjdQ99B2+BUTos28C2sDfJfCd5ekLCp02EUle527sX8QjyTiTUlu5pvFnCtzO6MWf3loiJb Vi9vA0hQFOnu4jM0TjzIc4vWJpX1oExfFwEsoSVLDQh3CFIoe8wHsRgpIvtWiiRIuaaJawhx ac6mj4yaB2UR/MW8KFpUmqzTgVn8FLt0S0yo1PpleTFT8IsGY8luoyWIaUyNCrjXxrps8yFj HoE54Abb0S6Z15Ko2csG2DR1u4ZtELVsHcF3gZT5q1Nt9BnV8TYi0+vNjVjQ7OODQMOBSIB8 bBEQogtbTxBYvIs57ClYAd0fHssz7fJHaKDbcsZXGWKdiSEQrrfc78tOgmYml997og7SyLg+ YI9X8G4RJiIF9EThRtAKK92i9xktWLLBCl5q5nwRPcObVgy7AiwQBPX1WVR3+Uy6BaeyylPY YIAyM6dHwl4/e5HczR5Nt6pzmnOza8F2JT4blqJd+QVeL+xDtBvzKWLBVZkPJMbwqYS/1MOu 4UdmuNIpABEBAAHCwXYEGAEKACAWIQTkfA3NJ2jfoTj83NbGfJGBs4k/sAUCYqnvVgIbDAAK CRDGfJGBs4k/sAQUD/4xIZxwGDsBc3mf4qnahCEAN3NjyhI/9q2oFGzyN0t9ifh7u7HD5R0F 5WdI2JnOnW3Bjl3YnsMfLg9wHnsT3R1xresf59wXuKQ7UIpqPfMXLZnHtaUP5bmpETvkvybN f0zkekbU27chbmiAOyDB3ApsFQ7lqwvOO0K3+sx94ROsJwb+MDpjGAOewVPk7V0br0twFo2R 5/vtp8cNCg/lKlqWDmJ0fWipxazSzVAMDxn+ci0DB5o5UyHhxc8WgXXLl7t22m7b6kVZ0EKN oEPa7/TvIj1wVDFUFrEMEuJFBMDqZDLdBMZzEsq7O0sHaGifiy0zHRE7Eyfo+9sV0ccSWdeE f5GjoKLtR7MlJ+I9IfHuCl++Gxa+MM8yXfn/tk7vcsGJhewrqqTlvnpMuITCmdTJymgnKS/B jSDDKjgRsZLLzhkE+dVTBZRkHFOGf9rV8+JQRYwqZVIjIEln6EZdfOQIKPll4EY19f9stj7h ptM9jXDTBm4MBxdCdWIRsU19w4TqvitioADjMSZ1MYqQlS6pWQI9tDMJ/mLqKcWrHhar6rwv v/gTpsbePtVR2GkWMjEHE1VS1LKmr+UcWFu3MJIHMd4DFnypp1n1cY+u0emp93JUMDMqa79F G+6Sbeaw5G+/fx8S4hpw63SiA1x8c5PMjKGwx5G4ZZfNwT+mAi6dHA== In-Reply-To: <2T2LBWR63TVNP.3NFUJ8AHKFC01@8pit.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4TZ07Z49y1z9sZH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 3.83 X-Migadu-Queue-Id: 489D043EE8 X-Spam-Score: 3.83 X-Migadu-Scanner: mx11.migadu.com X-TUID: vKHUDMiIbER/ Hi Sören, First off, thank you for the patches! I will have a second look myself today or tomorrow, as I was not familiar with angr and I would love to try it out / play around with it myself. On 2024-02-13 10:53, Sören Tempel wrote: > Sorry about that! I guess because I send 15 emails at once, the MTA > queued some of them and then just didn't send them in the original order > (which it isn't required to). I don't think there is much I can do about > it on my end. I suppose `git-format-patch --numbered` would help? > No worries, I'm just mentioning it for other reviewers/committers, as I don't have commit rights myself. > The first test is skipped because it needs python-pyvex, the second is > skipped because it needs python-angr. The first also indirectly depends > on angr because the VEX converter within ailment needs it. Therefore, > we cannot enable these tests as they would would result in a cyclic > dependency (python-angr <-> python-ailment). I can add a comment. > Yes, I would cover this with a comment regarding the cyclical dependency. In general, I prefer failing tests to be "surgically removed" or clearly commented, since it acts as an entry point for future developers. > The test performs benchmark using time.time() and expects a minimum > timespan to be satisfied [2]. Therefore, it depends on the current load > and the host CPU. Never failed for me, but probably good to disable it? > I've had the same problem with some Go packages. The default test timeout is set to 10 minutes and due to this, I cannot build these packages locally. My laptop used to be considered fast :-) It seems QA passes fine though. I would be in favour of removing benchmark tests, but a second opinion would be good. > P.S: Should I resend the whole patch series with the updates or should > I only resend the patches that changed due to the outlined updates? Also > let me know if I should send a revision immediately or if you want me to > wait for further feedback. > I think it would be good to wait for feedback from others and incorporate everything into a second patch set. Best wishes, Troy