From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 0KPTF4iIIGfkBAEAe85BDQ:P1 (envelope-from ) for ; Tue, 29 Oct 2024 07:02:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 0KPTF4iIIGfkBAEAe85BDQ (envelope-from ) for ; Tue, 29 Oct 2024 08:02:32 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="WidY/rjM"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=D85UC8YV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730185352; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5Bqq1iIOAuQ/MSGu2EwFs7LDgIcFs1ZBgDYUriSsq/A=; b=YtB/gQ1wk0OdKD49XG92pcLa58EQC/ZzXqH/wZjwQkFctmvpLIsWHNwDQywtZNYRCo/WIK 8PPwVrz9/lV/QsIIYL3O6MGjvDFe4SSC3zMrv5BSbYipe7t+H6EvKFN1JYzYL020ANJkb3 FNPUNwzJLiswrE59gd6EKhDPPM+dXWEw2q94Y7+wPR2NJQph+ZsG8vcTZxr6W6k0T4u41L N9fnbNnGqBDIXZFL9DTYUeDg7rgGdihx8AnGBA4Et1R8sxzSPjNRZ+sc9MBZotsaa53/HB mncpYyal4LmHPIEG+4fvMH+e7+UKWba1Rv0+Fj1D3MXCtyMyq27jlsBMQRWm+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="WidY/rjM"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=D85UC8YV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730185352; a=rsa-sha256; cv=none; b=R4SNKeVAwEI0Yj4zD5vZI8ups7+0BjFpK4H1d1/qo7iG6Ovwt6xHu590dcpFjZa3KXsfZU Q5sdnn7AuihOv0mvrEQ0U2ZRUdePz+MDHbyrRjXblsJoZKDYmo8Rj8y7bmOVGLnnejip8e eDwGJ40SfhF73+ECDsCvXoDL8nM950GgaqWi7hq5hPao/TUvxHPsEpSA8bU+RBsw5GG7Uf WU9Dsb0eH1CDYMgxfQmfl1h5G83O5GFtsEdGOHvVMAzZDyXPhRBvepMx07JD1C/fxMn26b dNRu+2eibBj/RRo2SsYGX4ejdEm+XQCkSBmrwfuwf04XksS58QlGIURtkoOyUw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE8488F466 for ; Tue, 29 Oct 2024 08:02:31 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5gF1-00079Z-Pm; Tue, 29 Oct 2024 03:02:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5gEs-00079A-IG for guix-patches@gnu.org; Tue, 29 Oct 2024 03:02:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t5gEs-0004dv-6a for guix-patches@gnu.org; Tue, 29 Oct 2024 03:02:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=5Bqq1iIOAuQ/MSGu2EwFs7LDgIcFs1ZBgDYUriSsq/A=; b=WidY/rjMpsCQe4xzN7jqRQYtDhnLMOMf3pcH1C8a6SXHs2DISgtpL2ieUz1a/ZpvYQej3+rHyj/SP72MJJPvGWe50qOYHP6yVXqF/91fGWo/pGCkcy+gtwWrRudT+qfgLqM/Z48o3Zw6dIPLfZPLNe6tDaU4vc3wu7QjNepfRfgN9CFv9W48Cn8hXe99fsQ1GBe+t0gpRNR4BAOH7thSxtFZJSyT8Z/XV1fR+dFpIL62iaLvaZcseVUyT0tT3KFyBMuT5SQouLYPJSK4uy4IquM4LDVqx+12vFfYPF+HGUBe8ADkwQPgowZMP2HLLVGUef1k+P5hDDNs9nhCC5TI6Q==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t5gEs-0006yW-0o for guix-patches@gnu.org; Tue, 29 Oct 2024 03:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#74054] [PATCH v2 2/3] gnu: plib: Build with -fPIC. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Oct 2024 07:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74054 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , Adam Faiz , 74054@debbugs.gnu.org Received: via spool by 74054-submit@debbugs.gnu.org id=B74054.173018530726789 (code B ref 74054); Tue, 29 Oct 2024 07:02:01 +0000 Received: (at 74054) by debbugs.gnu.org; 29 Oct 2024 07:01:47 +0000 Received: from localhost ([127.0.0.1]:55718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5gEd-0006y1-8x for submit@debbugs.gnu.org; Tue, 29 Oct 2024 03:01:47 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:53305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5gEc-0006xm-3v for 74054@debbugs.gnu.org; Tue, 29 Oct 2024 03:01:46 -0400 Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-4315eeb2601so67447675e9.2 for <74054@debbugs.gnu.org>; Tue, 29 Oct 2024 00:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730185240; x=1730790040; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=5Bqq1iIOAuQ/MSGu2EwFs7LDgIcFs1ZBgDYUriSsq/A=; b=D85UC8YVNkz0ay8NfR5j07zXZKIP+hs0fAEp3jOBZ1bExlsFxSM3b+3xozErEO7kbW B0at8vjGrXvlTEmT7kfSW9RVd0rLPx3QdNNFT9Rk7gnG8CIXsLJJ2LwD0v/NhPATX7w1 Kz+wFAWHmdO9/2cHrocXA7yoJTEi7ms8yvOHwWRrwaFQF0CKEiavRSsJvcN9sXPlgaq+ xNGd1Q6OaxxQoUuioUC3OcvMaQYC3MMaebpXk4SRkoga72XvVTKkNSd0EWnpDE/mQ+X0 o9faCQ/dr4dl+Er0SALpVYLLNpdNoMl9JMVQqzs4EL0Oma53r63I2x0TpIfukyAWtsWr LH6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730185240; x=1730790040; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5Bqq1iIOAuQ/MSGu2EwFs7LDgIcFs1ZBgDYUriSsq/A=; b=aLe96fW868RbQkxa8gHrSIIdeEHt0+FAl5gKXJhC7fPIDbWiOzzRmSMJLj4b1tMYBS sRQ01qrFmywqXfvedYSj7ABdtsq3N+enzusPjXkb4dExtoGB7VHo5NMKyfsKpXD7LhNs yN6radJvUgmM+zl6Pudng/uv5f/tfmUdY8IC/yXtndamdyshz47wadkmqcLpzHu0FqAa aqefIOiJDWka4g1RuYAEBvSKXXpZ9zNU3ySu02cKFWEtXcGUh9g14lUZSfcBU45jkxN2 K+e/F5cf+tvUxS5nBKQzuulWGRF+Ppl4dAgLDjl8/rUDo4a7yO3J8ZZB6BreI+7X9g3o iORQ== X-Gm-Message-State: AOJu0Yy8PP0x04OAhitygJYsunYiiCJKxIvgRItkrMVA9DtfvNUFJrfq XWGII/jtQ9woxm5g1IeR/+DGEhxKYjotA5i6WrBWQ77i+ejmnW+B X-Google-Smtp-Source: AGHT+IGmYVOOBh0T0cclp0jvwDbACZiEXPF6LDriO3NKDvml+h9mTv1ttFxsfjZqRTasW3NkI61SxA== X-Received: by 2002:a05:6000:1942:b0:37d:43d4:88b7 with SMTP id ffacd0b85a97d-38061141a54mr10681824f8f.3.1730185239915; Tue, 29 Oct 2024 00:00:39 -0700 (PDT) Received: from lumine.fritz.box (85-127-114-32.dsl.dynamic.surfer.at. [85.127.114.32]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4319360d318sm133190125e9.47.2024.10.29.00.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 00:00:39 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Tue, 29 Oct 2024 08:00:26 +0100 In-Reply-To: <87v7xb4vwu.fsf@gmail.com> References: <50a1e682b5774829dbc1a9b0e625c69b38fd070a.1730096728.git.maxim.cournoyer@gmail.com> <87v7xb4vwu.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 4.88 X-Spam-Score: 4.88 X-Migadu-Queue-Id: DE8488F466 X-TUID: JF5FuI5hjYe+ Am Dienstag, dem 29.10.2024 um 09:04 +0900 schrieb Maxim Cournoyer: > Hi Liliana, >=20 > Liliana Marie Prikler writes: >=20 > > Am Montag, dem 28.10.2024 um 15:26 +0900 schrieb Maxim Cournoyer: > > > * gnu/packages/game-development.scm (plib) [configure-flags]: New > > > argument. > > That may be a typo =E2=80=93 I think we use the #: part. > > Alternatively you could write [arguments]: Add #:configure-flags. >=20 > I see multiple variants in use.=C2=A0 That's hard for newcomer and bad > consistency, but until someone distills 'The One True Changelog > Format' style to use, I think they are all acceptable.=C2=A0 For example: >=20 > '(plib) [phases]: Add some phase.' is common for example. >=20 > '(plib) [configure-flags]: New argument.' is similar style. >=20 > A more verbose alternative, which is also used could be: >=20 > '(plib) [arguments] : New argument.' >=20 > Thanks for taking a look. I'm fine with dropping the [arguments] part, but IMHO the #: marker should be there, as it marks the thing as a keyword argument (thus also making arguments superfluous =E2=80=93 it's implied). That is, I'd also wr= ite the phases example as #:phases. But I haven't done a survey, so if you want to keep the ChangeLog as- is, by all means do so. Cheers