unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Demis Balbach <db@minikn.xyz>, 53797@debbugs.gnu.org
Subject: [bug#53797] [PATCH] gnu: Add emacs-app-launcher.
Date: Sat, 05 Feb 2022 13:12:57 +0100	[thread overview]
Message-ID: <d970bde33d3c9ce262ca94ea07f004df7ccd6d05.camel@telenet.be> (raw)
In-Reply-To: <20220205112019.31624-1-db@minikn.xyz>

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

Demis Balbach schreef op za 05-02-2022 om 12:20 [+0100]:
> +  (let ((commit "80a9ed37892ee6e21fe44487ed11f66a15e3f440")
> +        (revision "1")
> +        (version "0.1"))

It's the first version in Guix, so revision should be "0."
Also, version "0.1" seems to be incorrect here, since there
aren't any releases at all.  So I'd start at "0.0".

I could be wrong, but I don't think that the auto-updater
(guix refresh -u) understands let-bound versions (let-bound commits and
revisions are ok though), and you're only using the 'version' variable
in a single place, so I'd move it to the 'version' field of the package
record.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2022-02-05 12:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-05 11:20 [bug#53797] [PATCH] gnu: Add emacs-app-launcher Demis Balbach
2022-02-05 12:05 ` Maxime Devos
2022-02-06 10:55   ` Demis Balbach
2022-02-05 12:12 ` Maxime Devos [this message]
2022-02-05 12:14   ` Maxime Devos
2022-02-05 12:13 ` Maxime Devos
2022-02-06 10:58   ` Demis Balbach
2022-02-06 11:39     ` Maxime Devos
2022-02-05 12:16 ` Maxime Devos
2022-02-06 10:59   ` Demis Balbach
2022-02-06 11:40     ` Maxime Devos
2022-02-05 12:20 ` Maxime Devos
2022-02-06 11:01   ` Demis Balbach
2022-02-06 11:44     ` Maxime Devos
2023-09-01 22:35 ` bug#53797: " Vagrant Cascadian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d970bde33d3c9ce262ca94ea07f004df7ccd6d05.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=53797@debbugs.gnu.org \
    --cc=db@minikn.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).