From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id yKzxDEUlVWVSuQAAG6o9tA:P1 (envelope-from ) for ; Wed, 15 Nov 2023 21:08:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yKzxDEUlVWVSuQAAG6o9tA (envelope-from ) for ; Wed, 15 Nov 2023 21:08:37 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 99F1614CE1 for ; Wed, 15 Nov 2023 21:08:36 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=QyivOQNZ; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1700078917; a=rsa-sha256; cv=none; b=nVpgsi96ZB8AcYLJD5NtlBbDXN+GM8FKFyfhrkTdskGHIEMp6g3ki8PwbolsEAYm6R3QWZ MhE1SRswQS3qaNMChGBtob/296BcVFIwvXfx08CIqFpDrES42m0O+OLjakbd29CYUT/FVU p4+ZNfFONpijZ5LCHFH2QMHTF6J2xUMQ3z2MxqINRG8gy1aF6nHBP10ypZ17Z2Djpk6m1+ vRrgJ/uCdF5MNq4G0/6iC+kgvwmo+Di6qV2Mr1wahlTflJNNTYDP02VVvVEtxRYNyCRmh/ AgXfndgPRiGIL/eQ6fcHIBFIDTBM/jj+FiDGqgyZNXJJpTz6F+w64nwqXkc/EA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=QyivOQNZ; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1700078917; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SboDsSdAYe9eZTl/TfxUD6Iv54YiVKAY11vEsM3czhE=; b=GMwgPpP36g57SBWr5GZnMXkzstEaP6uwtufmO7ZGGY8khAcn0EIQEhglif99KuVpcXA0x2 5CTPCkemzGbX+Gm7RLPqzirmn5EBD340WBa+W3y4MAp1HFwdnZ2zz2tyb5lRziaamSeeNj kqklwDWQKfOXvliXy+t4ThFL8dMibLrfKPCcmibHgaKA5x+DTWHMeNtgxZiYmqZFt90W8e oUDKMjw6Qufp8+LbuPzbnIoNxzcSu8jcquXX2uEKvKbKlDB9BVqW928ayvREgQbelQqxEb hjUqdgAzbKXCttWGWzLbix/uMNLBocWYg35KXQY5W8XiEGeqVU+j/SBtIS2+PA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3MBD-000367-QY; Wed, 15 Nov 2023 15:08:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3MB9-00035h-2O for guix-patches@gnu.org; Wed, 15 Nov 2023 15:08:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3MB8-0005jR-P1 for guix-patches@gnu.org; Wed, 15 Nov 2023 15:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3MB7-0002av-Qg for guix-patches@gnu.org; Wed, 15 Nov 2023 15:08:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67134] [PATCH] gnu: Add camelia-girls Resent-From: hrn Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 Nov 2023 20:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67134 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 67134@debbugs.gnu.org Received: via spool by 67134-submit@debbugs.gnu.org id=B67134.17000788509923 (code B ref 67134); Wed, 15 Nov 2023 20:08:01 +0000 Received: (at 67134) by debbugs.gnu.org; 15 Nov 2023 20:07:30 +0000 Received: from localhost ([127.0.0.1]:53877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3MAb-0002Zz-OX for submit@debbugs.gnu.org; Wed, 15 Nov 2023 15:07:30 -0500 Received: from mout02.posteo.de ([185.67.36.66]:46173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3MAZ-0002Zi-Ng for 67134@debbugs.gnu.org; Wed, 15 Nov 2023 15:07:29 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D89EA240103 for <67134@debbugs.gnu.org>; Wed, 15 Nov 2023 21:07:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1700078841; bh=cHq3bI5Wmwu5lYSkhkszhxd0a08GD1FlRnFFmN/1dMU=; h=MIME-Version:Content-Transfer-Encoding:Date:From:To:Cc:Subject: Message-ID:From; b=QyivOQNZHJ38QZ7eiAJxnb38yRo0fxW4ui/wELkyMOO1B5DScUm03P0N/gFEHqRoh FaCj425mF8mFVmwucsaan3Ti5yXd0+bDalgizLq0MelY9Vyxj3+Q3g4GZnL2Qfgu6P px8h/FtbDg4GPnfynsERkIGp07zHheoUsGc5RTto6whB0bVok8QemOGpUKNHiA1pXq k3NRJcbZsUsPKL7DchOdGtC2JlPHZIX/uEVMoEMWwgpRZNUc/FtTeCkeB1KeeMS7qi Iw6F7qNwhRJjs5yhLUX1uIEA/9CoWUdIoNIGsFXsgeyxcxR+YmKcCQrPm7EDyn96uS A6A8rxeNHc2IQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SVvMs1MMfz9rxK; Wed, 15 Nov 2023 21:07:21 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Date: Wed, 15 Nov 2023 20:07:21 +0000 From: hrn In-Reply-To: <715142aa06a75631e8478292298c3cbdbf3bbe28.camel@gmail.com> References: <715142aa06a75631e8478292298c3cbdbf3bbe28.camel@gmail.com> Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 99F1614CE1 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.19 X-Spam-Score: -5.19 X-TUID: JUkFNIvTRXXG Thanks for reviewing! > + (snippet '(begin > Use #~ instead of ': The former also allows you to pull in other > packages, should you ever need to. Ok I'll test. > + `(#:phases (modify-phases %standard-phases > Same as above, prefer (list #:phases #~(...)) Ok will try, I thought it was the other way around. > + (font-path-bi (string-append=20 > (assoc-ref > inputs > + "font- > dejavu") > + =20 > "/share/fonts/truetype/" > + font-name-bi)) > Prefer search-input-file. Ok, sounds better. > + (symlink font-path-bi target-bi)))) > Instead of symlinking, hard-code the file name where it's used? Symlinking avoids changing the source files. Isn't that better? > We have a dedicated procedure for generating .desktop files. Use that. I would have used that if it wasn't for the builder already having=20 created the desktop file. I didn't want to change the builder so I ended up with=20 this solution. In case the builder can do more automatically in the future we can remove=20 the extra code. Or do you want me to overwrite the desktop file created by the builder=20 entirely? > The credits are, as far as I can see, a little unclear about some > included assets =E2=80=93 I only see some Wikimedia links, and that's it= =2E I'd > be happy to be proven wrong, though, we desperately need a package to > make use of renpy-build-system :) I checked the licenses to the best of my best ability from the=20 information in license.txt. The in game credits with more detailed license information can be found=20 in the games/scripts/credits?.txt.