unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#73965] [PATCH] gnu: phonon-backend-vlc: Enable QT6.
@ 2024-10-23 14:13 Sughosha via Guix-patches via
  2024-10-23 14:39 ` Zheng Junjie
  0 siblings, 1 reply; 4+ messages in thread
From: Sughosha via Guix-patches via @ 2024-10-23 14:13 UTC (permalink / raw)
  To: 73965; +Cc: Sughosha

* gnu/packages/kde-frameworks.scm (phonon-backend-vlc): Switch to Qt6.
[arguments]<configure-flags>: Add "-DPHONON_BUILD_QT5=0" and replace
"-DPHONON_BUILD_QT6=OFF" with "-DPHONON_BUILD_QT6=1".
[native-inputs]: Replace qttools-5 with qttools.
[inputs]: Replace qtbase-5 with qtbase.

Change-Id: I45380ca844e987bb27ee67106e35cb60fc0565c3
---
 gnu/packages/kde-frameworks.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 13d4e24726..a14ba1ffb0 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -311,11 +311,12 @@ (define-public phonon-backend-vlc
     (build-system cmake-build-system)
     (arguments
      (list #:configure-flags
-           #~(list "-DPHONON_BUILD_QT6=OFF")))
+           #~(list "-DPHONON_BUILD_QT5=0"
+                    "-DPHONON_BUILD_QT6=1")))
     (native-inputs
-     (list extra-cmake-modules qttools-5))
+     (list extra-cmake-modules qttools))
     (inputs
-     (list phonon qtbase-5 vlc))
+     (list phonon qtbase vlc))
     (home-page "https://community.kde.org/Phonon")
     (synopsis "Phonon backend which uses VLC")
     (description "Phonon makes use of backend libraries to provide sound.

base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#73965] [PATCH] gnu: phonon-backend-vlc: Enable QT6.
  2024-10-23 14:13 [bug#73965] [PATCH] gnu: phonon-backend-vlc: Enable QT6 Sughosha via Guix-patches via
@ 2024-10-23 14:39 ` Zheng Junjie
  2024-10-23 15:15   ` Sughosha via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Zheng Junjie @ 2024-10-23 14:39 UTC (permalink / raw)
  To: 73965; +Cc: sughosha

[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]

Sughosha via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/kde-frameworks.scm (phonon-backend-vlc): Switch to Qt6.
> [arguments]<configure-flags>: Add "-DPHONON_BUILD_QT5=0" and replace
> "-DPHONON_BUILD_QT6=OFF" with "-DPHONON_BUILD_QT6=1".
> [native-inputs]: Replace qttools-5 with qttools.
> [inputs]: Replace qtbase-5 with qtbase.
>
> Change-Id: I45380ca844e987bb27ee67106e35cb60fc0565c3
> ---
>  gnu/packages/kde-frameworks.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 13d4e24726..a14ba1ffb0 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -311,11 +311,12 @@ (define-public phonon-backend-vlc
>      (build-system cmake-build-system)
>      (arguments
>       (list #:configure-flags
> -           #~(list "-DPHONON_BUILD_QT6=OFF")))
> +           #~(list "-DPHONON_BUILD_QT5=0"
> +                    "-DPHONON_BUILD_QT6=1")))
>      (native-inputs
> -     (list extra-cmake-modules qttools-5))
> +     (list extra-cmake-modules qttools))
>      (inputs
> -     (list phonon qtbase-5 vlc))
> +     (list phonon qtbase vlc))
>      (home-page "https://community.kde.org/Phonon")
>      (synopsis "Phonon backend which uses VLC")
>      (description "Phonon makes use of backend libraries to provide sound.
>
> base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1

i think maybe also add a qt5 version? some package use phonon with qt5.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#73965] [PATCH] gnu: phonon-backend-vlc: Enable QT6.
  2024-10-23 14:39 ` Zheng Junjie
@ 2024-10-23 15:15   ` Sughosha via Guix-patches via
  2024-10-23 16:08     ` bug#73965: " Zheng Junjie
  0 siblings, 1 reply; 4+ messages in thread
From: Sughosha via Guix-patches via @ 2024-10-23 15:15 UTC (permalink / raw)
  To: zhengjunjie, 73965

[-- Attachment #1: Type: text/plain, Size: 1860 bytes --]

This is just a VLC backend for phonon, not the phonon itself. Currently this package is used only by dragon and none other, which does not have a qt5 version packaged yet.

On 23 October 2024 8:09:04 pm IST, Zheng Junjie <zhengjunjie@iscas.ac.cn> wrote:
>Sughosha via Guix-patches via <guix-patches@gnu.org> writes:
>
>> * gnu/packages/kde-frameworks.scm (phonon-backend-vlc): Switch to Qt6.
>> [arguments]<configure-flags>: Add "-DPHONON_BUILD_QT5=0" and replace
>> "-DPHONON_BUILD_QT6=OFF" with "-DPHONON_BUILD_QT6=1".
>> [native-inputs]: Replace qttools-5 with qttools.
>> [inputs]: Replace qtbase-5 with qtbase.
>>
>> Change-Id: I45380ca844e987bb27ee67106e35cb60fc0565c3
>> ---
>>  gnu/packages/kde-frameworks.scm | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
>> index 13d4e24726..a14ba1ffb0 100644
>> --- a/gnu/packages/kde-frameworks.scm
>> +++ b/gnu/packages/kde-frameworks.scm
>> @@ -311,11 +311,12 @@ (define-public phonon-backend-vlc
>>      (build-system cmake-build-system)
>>      (arguments
>>       (list #:configure-flags
>> -           #~(list "-DPHONON_BUILD_QT6=OFF")))
>> +           #~(list "-DPHONON_BUILD_QT5=0"
>> +                    "-DPHONON_BUILD_QT6=1")))
>>      (native-inputs
>> -     (list extra-cmake-modules qttools-5))
>> +     (list extra-cmake-modules qttools))
>>      (inputs
>> -     (list phonon qtbase-5 vlc))
>> +     (list phonon qtbase vlc))
>>      (home-page "https://community.kde.org/Phonon")
>>      (synopsis "Phonon backend which uses VLC")
>>      (description "Phonon makes use of backend libraries to provide sound.
>>
>> base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1
>
>i think maybe also add a qt5 version? some package use phonon with qt5.

Sughosha

[-- Attachment #2: Type: text/html, Size: 2377 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#73965: [PATCH] gnu: phonon-backend-vlc: Enable QT6.
  2024-10-23 15:15   ` Sughosha via Guix-patches via
@ 2024-10-23 16:08     ` Zheng Junjie
  0 siblings, 0 replies; 4+ messages in thread
From: Zheng Junjie @ 2024-10-23 16:08 UTC (permalink / raw)
  To: Sughosha via Guix-patches via; +Cc: 73965-done, Sughosha

[-- Attachment #1: Type: text/plain, Size: 2034 bytes --]

Sughosha via Guix-patches via <guix-patches@gnu.org> writes:

> This is just a VLC backend for phonon, not the phonon itself. Currently this package is used only by dragon
> and none other, which does not have a qt5 version packaged yet.

ok, push it, and i use ON/OFF replace 1/0. close.

>
> On 23 October 2024 8:09:04 pm IST, Zheng Junjie <zhengjunjie@iscas.ac.cn> wrote:
>
>  Sughosha via Guix-patches via <guix-patches@gnu.org> writes:
>
>   * gnu/packages/kde-frameworks.scm (phonon-backend-vlc): Switch to Qt6.
>  [arguments]<configure-flags>: Add "-DPHONON_BUILD_QT5=0" and replace
>  "-DPHONON_BUILD_QT6=OFF" with "-DPHONON_BUILD_QT6=1".
>  [native-inputs]: Replace qttools-5 with qttools.
>  [inputs]: Replace qtbase-5 with qtbase.
>
>  Change-Id: I45380ca844e987bb27ee67106e35cb60fc0565c3
> -------------------------------------------------------------------------------------------
>   gnu/packages/kde-frameworks.scm | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
>  diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
>  index 13d4e24726..a14ba1ffb0 100644
>  --- a/gnu/packages/kde-frameworks.scm
>  +++ b/gnu/packages/kde-frameworks.scm
>  @@ -311,11 +311,12 @@ (define-public phonon-backend-vlc
>       (build-system cmake-build-system)
>       (arguments
>        (list #:configure-flags
>  -           #~(list "-DPHONON_BUILD_QT6=OFF")))
>  +           #~(list "-DPHONON_BUILD_QT5=0"
>  +                    "-DPHONON_BUILD_QT6=1")))
>       (native-inputs
>  -     (list extra-cmake-modules qttools-5))
>  +     (list extra-cmake-modules qttools))
>       (inputs
>  -     (list phonon qtbase-5 vlc))
>  +     (list phonon qtbase vlc))
>       (home-page "https://community.kde.org/Phonon")
>       (synopsis "Phonon backend which uses VLC")
>       (description "Phonon makes use of backend libraries to provide sound.
>
>  base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1
>
> i think maybe also add a qt5 version? some package use phonon with qt5.
>
> Sughosha

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-23 16:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-23 14:13 [bug#73965] [PATCH] gnu: phonon-backend-vlc: Enable QT6 Sughosha via Guix-patches via
2024-10-23 14:39 ` Zheng Junjie
2024-10-23 15:15   ` Sughosha via Guix-patches via
2024-10-23 16:08     ` bug#73965: " Zheng Junjie

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).