From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EEs7CknMLGHIbAEAgWs5BA (envelope-from ) for ; Mon, 30 Aug 2021 14:17:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eJnUBUnMLGGPYQAAbx9fmQ (envelope-from ) for ; Mon, 30 Aug 2021 12:17:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6848A60AD for ; Mon, 30 Aug 2021 14:17:12 +0200 (CEST) Received: from localhost ([::1]:34966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKgDv-0006h1-BY for larch@yhetil.org; Mon, 30 Aug 2021 08:17:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKgDn-0006e1-8a for guix-patches@gnu.org; Mon, 30 Aug 2021 08:17:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKgDn-0001zx-1Y for guix-patches@gnu.org; Mon, 30 Aug 2021 08:17:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mKgDm-0001eb-MH for guix-patches@gnu.org; Mon, 30 Aug 2021 08:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50201] [PATCH core-updates-frozen 0/52] Support cross-compilation in glib-or-gtk-build-system and fix cross-compilation errors Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 Aug 2021 12:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50201 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 50201@debbugs.gnu.org Received: via spool by 50201-submit@debbugs.gnu.org id=B50201.16303258206343 (code B ref 50201); Mon, 30 Aug 2021 12:17:02 +0000 Received: (at 50201) by debbugs.gnu.org; 30 Aug 2021 12:17:00 +0000 Received: from localhost ([127.0.0.1]:58353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKgDk-0001eF-3z for submit@debbugs.gnu.org; Mon, 30 Aug 2021 08:17:00 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:43660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKgDh-0001e5-1j for 50201@debbugs.gnu.org; Mon, 30 Aug 2021 08:16:58 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by baptiste.telenet-ops.be with bizsmtp id noGu2500T0mfAB401oGurw; Mon, 30 Aug 2021 14:16:55 +0200 Message-ID: From: Maxime Devos Date: Mon, 30 Aug 2021 14:16:34 +0200 In-Reply-To: <87sfyty9rb.fsf@gnu.org> References: <87sfyty9rb.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-yu+2w0MQKATjDq4U6Phk" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1630325815; bh=TDCMvOf9DPjc/F6EAy4IAkPYtumDEwRuN8jOioCUOQw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=aGSoMjbkXVYEefS4YeG35vJN+F9kgNSdxaixCQgwoob6Lk6dQljmO8v74dY38OV1j nhnbA6ecyabiNqZ/5c7SWfV4E4WL0yer1dUpl3+Hl4IEJ3Pt0qofcdjpSoni76D8L7 pWYR35pEzJXGsA6HuRmXe9oZWcbczKF5kIXWyo8oJ34Oj9xEdnk1Ac1qZF+fT32KTo Bq2pkIxYkiPK57dmIo+f9uqQahwKuuucFUYNSTMXNAHr7eYFVvve4Cfr2mPluyzMqH jGjjGLfFJ0RC3QR3dR3Pu+90Mqk/QnnAL4WksaVnc3yPaetBWeKNsZX3Vi8MP32ws6 3WH8O758dXLCg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630325832; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=TDCMvOf9DPjc/F6EAy4IAkPYtumDEwRuN8jOioCUOQw=; b=FpWgveBhs6kmT0jPYS6k6sxE1ONwk3NISZsoj7RPe/vodJhHAN8O2b60RZHgrBTUGJ594e ZhwEosggYwBsKdd5FfVV9AhZ3H6pIq0O6y2+EiJwPPA/KFRk3Wa34lqRFQif4tdPe+eSIA b7Vf2vhJ/rHxElpB5UAbpV2dtZCHg5WL00d96KjSNtmMkLqyesX++6wtUEWQ6lP9YG9HTG 8oKHopCYvosLA9xjm7x4078iUK6lhKOA9xjBkZCOrbm8Ih+wPi4uGztZXgcJeFYFn3FZ13 N2+0+D01vJzduDDhXzWybtICxD/xkRuoBAx9Wn4Ym006raq0hdjJq+QI3q3akw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630325832; a=rsa-sha256; cv=none; b=oMebsslpjn1dj0eRCbgMOzxzULrAf+ilumgkAB7pyoi886qvuJYy6j8H2n41wevSU8dqgT M09+yDCeO2RtoTrhQDq8CmtQr1gGErtGG7+E7eFtQVaTe27vLhBNvcg0XqlINK8xN3u+Tb BsEdLvEStGVscQtz7DG9stalFVv/kXaBe93f+aZUE4bM4X/lHiNOF06jODak6PUgnnuAHH wVF9UBV+NvcxzRJxDo1k/gkeE7DWwXYbgfr5DMk0TGhQ6VTmB0Q33jaIu9AYXREgCw7Kog TWay0wwZgjLxkhLRz8qMPPs+xKbf1KP2VCI6F3IQRPfTWmJPDT7imt5wNVyFBA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=aGSoMjbk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=aGSoMjbk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6848A60AD X-Spam-Score: -3.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: C6YANhtOYByK --=-yu+2w0MQKATjDq4U6Phk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mathieu Othacehe schreef op za 28-08-2021 om 15:33 [+0200]: > Hello Maxime, >=20 > > It should not cause any rebuilds. You can test with > > ./pre-inst-env guix build gtk+ --target=3Daarch64-linux-gnu. > > There is still some work to be done though: >=20 > Thanks for this series, that a great step forward. I will have a closer > look later, but as a general remark, should we really target the=20 > core-updates-frozen branch?=20 > > Maybe it would make more sense to target the core-updates branch as > there's still some work required to get gtk+ to cross-build. Going by the patch series title: =E2=80=98Support cross-compilation in glib-or-gtk-build-system=E2=80=99, I don't see why this would have to go in core-updates instead of core-updates-frozen, because: (1) no rebuilds, unless I missed something (*) (2) due to (1), it doesn't introduce bugs (3) after this patch series, glib-or-gtk-build-system _does_ support support cross-compilation (*) In one patch, I unconditionally added a glib:bin input. IIRC, it faile= d to build natively previously, but I'd better check again .. For example, cairo, which uses glib-or-gtk-build-system, now cross-compiles for aarch64-linux-gnu. True, ideally gtk+ would cross-compile as well, but cairo being cross-compilable is already useful (e.g., it's a dependency of harfbuzz which is a dependency of qtbase which is a dependenc= y of graphical Qt software.) (**) (**) qtbase (indirectly) depends on perl-file-mimeinfo and 'perl-build-syst= em' doesn't support cross-compilation, so this argument is probably not really convincing ... Maybe texlive-bin would be a better example?(***) (***) The dependency libungif fails to cross-compile/ Also, hacking on master (or core-updates-frozen) is simpler on than on core= -updates, due to more substitutes, and it is more appealing to me because the cross-c= ompilation support would be available earlier to most people than if it the patches we= re based on core-updates. As a general principle, I prefer basing patches on 'master'. That wasn't p= ossible here due to the use of G-exps in glib-or-gtk-build-system, so I based the p= atches on 'core-updates-frozen' instead. That goes a bit against (guix)Submitting Patches though, so I would understand if the patches will = have to be rebased on core-updates: When we decide to start building the =E2=80=98staging=E2=80=99 or =E2=80= =98core-updates=E2=80=99 branches, they will be forked and renamed with the suffix =E2=80=98-frozen=E2=80=99, at which time only bug fixes may be pushed to = the frozen branches. unless =E2=80=98let glib-or-gtk-build-system support cross-compilation=E2= =80=99 counts as a bug fix. To me, this is not all that different from other cross-compilation fixes li= ke "CC=3Dgcc" --> (string-append "CC=3D" (cc-for-target)) or moving inputs bet= ween 'native-inputs' and 'inputs', but YMMV. Greetings, Maxime. --=-yu+2w0MQKATjDq4U6Phk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYSzMIxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7scBAP4hda7fLPnNw/yF9hNrB2+rPwwY K00WbUWs5eSqp5NadwEA1jd9SkLKsRf6Vja09ASxbmyod2/e7lSvyhonH4neXQw= =jpU8 -----END PGP SIGNATURE----- --=-yu+2w0MQKATjDq4U6Phk--