From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id COeyNWUeRmHh9AAAgWs5BA (envelope-from ) for ; Sat, 18 Sep 2021 19:14:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4O4xMWUeRmGQKwAAbx9fmQ (envelope-from ) for ; Sat, 18 Sep 2021 17:14:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EA275A428 for ; Sat, 18 Sep 2021 19:14:12 +0200 (CEST) Received: from localhost ([::1]:51030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRdum-0006Zf-0p for larch@yhetil.org; Sat, 18 Sep 2021 13:14:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRduc-0006X2-H4 for guix-patches@gnu.org; Sat, 18 Sep 2021 13:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRduc-0005Fs-9G for guix-patches@gnu.org; Sat, 18 Sep 2021 13:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRduc-0008Cy-59 for guix-patches@gnu.org; Sat, 18 Sep 2021 13:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49713] [PATCH 1/3] gnu: cereal: Use cmake to build and install the library. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Sep 2021 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49713 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ivan Gankevich , 49713@debbugs.gnu.org Received: via spool by 49713-submit@debbugs.gnu.org id=B49713.163198520731496 (code B ref 49713); Sat, 18 Sep 2021 17:14:02 +0000 Received: (at 49713) by debbugs.gnu.org; 18 Sep 2021 17:13:27 +0000 Received: from localhost ([127.0.0.1]:36770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRdu2-0008Bw-Kq for submit@debbugs.gnu.org; Sat, 18 Sep 2021 13:13:26 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:47092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRdtv-0008Bc-3W for 49713@debbugs.gnu.org; Sat, 18 Sep 2021 13:13:25 -0400 Received: by mail-wr1-f66.google.com with SMTP id x6so20528385wrv.13 for <49713@debbugs.gnu.org>; Sat, 18 Sep 2021 10:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=arAJNM/imIpfKjgmjBRR/Gh34jf66MQJxlAKLEQNEto=; b=T4vFQlP9HQlEdnDMh9VfW8Gz5j9wY6inxXBU0nhZlFwC5W8yQKUEuVOxBxH+2sNmmO 3Zpt004kXh1KrcS6rynbK5454R78Vf/VIfgB/oEdIOravmCxqW9CKVyzeA5GaAAB8h8Q mdyxDH5vk1NRBM5PYyGrvWhDFshcPw8dD3epVs181eLitHQc43hYcZ9zajQ4WvcuNJHd rZjkfTUGO3SnDK9cWi/5UUeZl5VvV1xuM/sfsm94BQcJryuUlhyG9R1ZUwzo+//HTg5c djEiYOM3QRmowZRz55gjMrt6b7iShK1MkBOnHHZGRG8Jz+toD2XKy4h5Sqc49WGC+63e 18Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=arAJNM/imIpfKjgmjBRR/Gh34jf66MQJxlAKLEQNEto=; b=e+EZV91HWuQDxB6gBkMR9404b/tBEOy+4FGLiEFks44r2ybKbC8nfm1CePCreikfLW 58yuP2qBt4wfOYx571EJZxf683391vnlzKPReXxPYO6Y/KrmCGWByoY/+F/Fh5VagOdD gWaU+smrgN75SS+lyDYtb7OxZ8txzv9Pg0MOucjZwyfHOHfEH08IHZPREPhbpbfnxYYk RBsC2n4DeUeagSBCqBqBMEUCnmS75iN8Gmw2hw1EZEzesEHbwn+niIgZIJBMaM5eHXcJ +qKWA6+l0+mCesbz/KrvUKDT9HNEtancNlmzF5Qi/eJ2Y9ahQWd9gDKOk6/29R+OydYK 1YOg== X-Gm-Message-State: AOAM532ApWiU9ZRfzV2/jz807WS/3bLVDaKBZiHh3G0r+spTqYXcuaZq l53hy5Cz/sTUjlf3NZAkFHI= X-Google-Smtp-Source: ABdhPJwQ7FT1aaF6eNgLDhQFlg3TLt++yugrgXdMExXP50ujcYSqMJ3uOXYNDsNhTnHVJe/RnLi6bA== X-Received: by 2002:a5d:688f:: with SMTP id h15mr18709954wru.410.1631985193308; Sat, 18 Sep 2021 10:13:13 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id o8sm12193595wrm.9.2021.09.18.10.13.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Sep 2021 10:13:12 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Sat, 18 Sep 2021 19:13:12 +0200 In-Reply-To: <20210723210037.28150-1-i.gankevich@spbu.ru> References: <20210723210037.28150-1-i.gankevich@spbu.ru> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631985253; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=arAJNM/imIpfKjgmjBRR/Gh34jf66MQJxlAKLEQNEto=; b=HxQqYO4FMjJ9YtikdnDs9aAj7zosuwVpG61JW9y2lU3g1qjnJt6JgKD9J6iEOLiAZe2mVs muS09EEfVv9yNd19BV34ZKInVVb3KK9TjQZB9uTKDcNy2L0uPvF2HaBArcONaJLgrwjVhf JYeu3HhUjKvABaQ/nUCwYhq0tq5khTVRqIMUwHRrEqfzH3J990sAyM0/pNF0Vteqy4UNgb CCRVV17PWf6wyS7Pmoti+QAskwm+BQIaM0QNEKDFFhQD0LpRteUgNYputx4Z4juvLEymvX qRqEh1RyUDvgzsMHn64Dkbr3oJkfHAGgc191J9pfG4b5opIlVFHB4y9Xt3pAPw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631985253; a=rsa-sha256; cv=none; b=PS9emIgJRjvWHh/mDGultdklajYj6R9h++STO7VDhdlJe+R6YE1AIfdKg+xccxe9x7KKw5 1PFjemqFiyO4Gs9LDCXbOo1w4qE3u8dzGJ+v6U7bIpPCnyw+SBzSeEEahM8KxGTIPaqW7o PcSEmvitRNbiR5QPcdPu5agmKpYzGgGR00TzJgBDDoLaAL3N4ajxaDlMLVAX9ttVwRDVKh +3vy+wP+bdbTT09qZbyZdP84swhLc+NYyIyctK+CnfW/gzncX2324JXoe0CplmS3eaVz54 9GSMWlNtvwKOokvOaL/Fc31WLu6EjULWgt+DhogCFFKMd7RyogmYnqlfhwtxOA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=T4vFQlP9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.21 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=T4vFQlP9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EA275A428 X-Spam-Score: 0.21 X-Migadu-Scanner: scn0.migadu.com X-TUID: d7rDEPE+sFOC Hi, Am Samstag, den 24.07.2021, 00:00 +0300 schrieb Ivan Gankevich: > Hello, > > this series of patches adds Prusa Slicer. I had to change "cereal" > package definition to use cmake, otherwise "prusa-slicer" failed > to find the library. Also, I added "libigl" that is a dependency > of "prusa-slicer". > > gnu/packages/serialization.scm (cereal): Use cmake. > > * Replace manual build and installation with standard cmake. > The main reason to do that is to get "cereal-config.cmake" > file that is used to find the library in other projects. > --- There are already two direct dependents of cereal. Do those still build? > > gnu/packages/serialization.scm | 39 ++++++++++++------------------ > ---- > 1 file changed, 13 insertions(+), 26 deletions(-) > > diff --git a/gnu/packages/serialization.scm > b/gnu/packages/serialization.scm > index 8f292ae408..9c34da62af 100644 > --- a/gnu/packages/serialization.scm > +++ b/gnu/packages/serialization.scm > @@ -141,32 +141,19 @@ implement RPC protocols.") > "0hc8wh9dwpc1w1zf5lfss4vg5hmgpblqxbrpp1rggicpx9ar831p")))) > (build-system cmake-build-system) > (arguments > - `(;; The only included tests are portability tests requiring > - ;; cross-compilation and boost. Since we are building cereal > on more > - ;; platforms anyway, there is no compelling reason to build > the tests. > - #:tests? #f > - #:out-of-source? #f > - #:phases > - (modify-phases %standard-phases > - (delete 'configure) > - (replace 'build > - (lambda _ > - (substitute* "doc/doxygen.in" > - (("@CMAKE_CURRENT_BINARY_DIR@") ".") > - (("@CMAKE_CURRENT_SOURCE_DIR@") ".")) > - (with-directory-excursion "doc" > - (invoke "doxygen" "doxygen.in")))) > - ;; There is no "install" target, so we have to provide our > own > - ;; "install" phase. > - (replace 'install > - (lambda* (#:key outputs #:allow-other-keys) > - (let* ((out (assoc-ref outputs "out")) > - (doc (string-append out > "/share/cereal/docs")) > - (include (string-append out "/include/cereal"))) > - (mkdir-p doc) > - (mkdir-p include) > - (copy-recursively "include/cereal" include) > - (copy-recursively "doc/html" doc))))))) > + `(#:configure-flags (list "-DSKIP_PORTABILITY_TEST=ON") > + #:tests? #f Never ever leave #:tests? #f uncommented. > + #:phases (modify-phases %standard-phases > + (add-before 'configure 'skip-sandbox > + (lambda _ > + (substitute* "CMakeLists.txt" > + (("add_subdirectory\\(sandbox\\)") "")))) > + (add-after 'install 'install-doc > + (lambda _ > + (let ((doc (string-append %output > "/share/doc/html"))) > + (invoke "make" "doc") > + (mkdir-p doc) > + (copy-recursively "doc/html" doc))))))) > (native-inputs > `(("doxygen" ,doxygen))) > (home-page "https://uscilab.github.io/cereal/")