From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GOXnFWXinGHwbAAAgWs5BA (envelope-from ) for ; Tue, 23 Nov 2021 13:45:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6MGeEWXinGEAQwAAbx9fmQ (envelope-from ) for ; Tue, 23 Nov 2021 12:45:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B7D8D9B50 for ; Tue, 23 Nov 2021 13:45:24 +0100 (CET) Received: from localhost ([::1]:35822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpVAp-0006ht-RA for larch@yhetil.org; Tue, 23 Nov 2021 07:45:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpVAU-0006g8-4Y for guix-patches@gnu.org; Tue, 23 Nov 2021 07:45:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38666) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpVAT-000216-Lq for guix-patches@gnu.org; Tue, 23 Nov 2021 07:45:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpVAT-0007ye-Jx for guix-patches@gnu.org; Tue, 23 Nov 2021 07:45:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51512] [PATCH v 2]: gnu: Add bash-bcu. Resent-From: david larsson Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 23 Nov 2021 12:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51512 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 51512@debbugs.gnu.org X-Debbugs-Original-Cc: 51512@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163767147230600 (code B ref -1); Tue, 23 Nov 2021 12:45:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Nov 2021 12:44:32 +0000 Received: from localhost ([127.0.0.1]:50212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpV9z-0007xU-Mb for submit@debbugs.gnu.org; Tue, 23 Nov 2021 07:44:32 -0500 Received: from lists.gnu.org ([209.51.188.17]:36718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpV9t-0007xJ-UX for submit@debbugs.gnu.org; Tue, 23 Nov 2021 07:44:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpV9t-00069D-3U for guix-patches@gnu.org; Tue, 23 Nov 2021 07:44:25 -0500 Received: from server0.selfhosted.xyz ([217.64.149.7]:53334) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpV9o-0001t3-Lb for guix-patches@gnu.org; Tue, 23 Nov 2021 07:44:23 -0500 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id 07BA1274CB5B; Tue, 23 Nov 2021 13:44:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1637671453; bh=/8Ez72VJUP/EHtFgIF4KuDLOesVGjYThNJa5VNMl8sI=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=mfI3V+czecfrJiAlOIpvu5d+ZI+QHupGh0Td3OUYCrdyCtOp+qzJpKnJKGLgvaqK5 iZSIndjr+PnQ4jaThTSL4JwuorjR4Sc2NFTS1oirzCBWF0Z4aaZvGjho/nQmTCDghY EuQLm9VLzNs2a8qx6RVrJ55rJwA39WZ2m/qMa6F+NfqFmuzLogAN7imvXnO8BWBY/v ameu875ZzBpMjSAxOjp+uTXrSaD96M+F6oy7n5h3dF8wsx6VBEByyLsVh6miMjERVf K6UsW3dolfoU9UYGVvfQ50LcJbhceAJeV1cRtqEOR7vO61OwKkqmt6E4+WzJSJYp/L TMGA9v8ipH7hA== X-Fuglu-Suspect: 9cdc4eb0f9354a368f9cd87d7924bbbe X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA; Tue, 23 Nov 2021 13:44:07 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 23 Nov 2021 13:44:07 +0100 From: david larsson In-Reply-To: <87y25inbsu.fsf@nckx> References: <3add15b77522d6e9ebd715a19d966666@selfhosted.xyz> <87r1bsqdy8.fsf@nckx> <93d8232c104dc63f46f6b975073b56ca@selfhosted.xyz> <87y25inbsu.fsf@nckx> Message-ID: X-Sender: david.larsson@selfhosted.xyz Received-SPF: pass client-ip=217.64.149.7; envelope-from=david.larsson@selfhosted.xyz; helo=server0.selfhosted.xyz X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.001, PDS_OTHER_BAD_TLD=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637671525; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/8Ez72VJUP/EHtFgIF4KuDLOesVGjYThNJa5VNMl8sI=; b=prMYR70m1govxCeq8zdV3tUaLRxCRy+mHk80xMpB2D2ll0Cl/WMCGYN1umaUc5qhVHRUuY 7iR/Pgh2jUM44O0i7YuyypVm64dZTn/OzWYRD06KaJJTZYjJ3XjFAfpOCybj/+KGWIFrPH G6FRNQuLiPnLp6GY6IM9sdWGUpzUyLSZKUCDUy6VrUpPk8qHBk4SlBbsvGO5Zzk2YXes5c 6IMKT3Mvsn6vqua85KRw8bIk/oM5w17c1K/HQl03M02s3X3OHrLDHYrdwT9R9ttZlETGT/ kitCtRxsfRmALZWJ3vyub9fV26ZZ+DkBkZZiBhOsZP4EqbFrVo8i9jQ7Dx++Iw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637671525; a=rsa-sha256; cv=none; b=nOQxRcnqlIou0y3QUJA6kU4csLQ3F0HiS+VSp4AhVAb7JbjC4t9e7r1QLi0b6CNfpNyx41 1mPY/oiZE6IdrRrQNP/aKsjd20kXYluVzPFRyNen/bPDhtmek4JUgz9eWu3SMalpd3zslt 0FmCCSn41DhSWtCP5tWgX3wlyhA4R20KpgCxHkjNMBEMeX48syQpmdHDNfyf64Udd7sfgS RNiu3rmEsVDuJ9RRKCA4063fUvPsxYi0MAkjuwwlAD5RkzQoElnK/nTtcVkpY7riq2lADD CQoMCm3EpEryIdJcgiKT5Oohyfa+Vd1qmepPR1ifcEId+t3NT1PPLemMT3Qc4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=selfhosted.xyz header.s=dkim header.b=mfI3V+cz; dmarc=fail reason="SPF not aligned (relaxed)" header.from=selfhosted.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=selfhosted.xyz header.s=dkim header.b=mfI3V+cz; dmarc=fail reason="SPF not aligned (relaxed)" header.from=selfhosted.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B7D8D9B50 X-Spam-Score: -2.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: 807vg6nu7JRj > However, you make an excellent point, and this packages's intended > usage means that it will clobber the caller's environment, not just > its own. Yep, it will. Previously I had the dependencies as propagated inputs but I think the current approach with putting them as inputs and creating a wrapper script is better. > If I were to use this package (and I might—it's neat) I would almost > certainly end up using it in a setting where changing PATH at all > would cause unexpected and frustrating ‘bugs’. > > Hmm… Im not sure I follow here.. can you give an example? Maybe some info or warning can be added to the description? Personally, I would be happy to see the current patch you provided committed to master, except I would just update to the very most recent commit again. Thanks for reviewing this! Best regards, David