From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KIRXFbwi1mGGQQEAgWs5BA (envelope-from ) for ; Wed, 05 Jan 2022 23:59:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mLIVDrwi1mHfewEAG6o9tA (envelope-from ) for ; Wed, 05 Jan 2022 23:59:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CD0D9412F3 for ; Wed, 5 Jan 2022 23:59:07 +0100 (CET) Received: from localhost ([::1]:51030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5FFL-00032H-0S for larch@yhetil.org; Wed, 05 Jan 2022 17:59:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5FFG-00031t-RT for guix-patches@gnu.org; Wed, 05 Jan 2022 17:59:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5FFG-0002Vq-Hz for guix-patches@gnu.org; Wed, 05 Jan 2022 17:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5FFG-0001z8-Fr for guix-patches@gnu.org; Wed, 05 Jan 2022 17:59:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v6 05/41] guix: node-build-system: Add 'delete-dependencies' helper function. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Jan 2022 22:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 51838@debbugs.gnu.org Cc: Timothy Sample , Pierre Langlois , Jelle Licht Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.16414235417624 (code B ref 51838); Wed, 05 Jan 2022 22:59:02 +0000 Received: (at 51838) by debbugs.gnu.org; 5 Jan 2022 22:59:01 +0000 Received: from localhost ([127.0.0.1]:39252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5FFF-0001yo-EC for submit@debbugs.gnu.org; Wed, 05 Jan 2022 17:59:01 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:40754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5FF9-0001yT-8D for 51838@debbugs.gnu.org; Wed, 05 Jan 2022 17:58:59 -0500 Received: by mail-wm1-f66.google.com with SMTP id 2-20020a05600c02c200b003470f96e778so67505wmn.5 for <51838@debbugs.gnu.org>; Wed, 05 Jan 2022 14:58:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=7xSeibo/4LsJLe4XbPikfy1tn+HZ7/dG1Hw5n7ueeU8=; b=Z8A0+vuu21Hit//GyAJANfTv4x1zq0P+1QOsH2CAnDyirqLR5R/GELgyACEMMqGU4j LCNDOV5fS5jNcfe0l1BALRVzNR0w6CYuBwYOR+wx/e8BYr1eF5qVe9kjjVwwGklR2M0m yxS3ah902M0fl89LxvMIZZXnOuYxK1GDZjl4d7zguJmAv5dALeB2N2gT0PWBAI9gUQtX j9VshGxDBkwVvYpULkmJThxTa/SpXrw6E4/nhc+L4esK/t/XclbCX7qG5/JYdLIcUqvL /QcnEjyrjTXiUCcxAz3ZCQrSydoyFoaZDD3l9Vo0KlNEmeE/rc66bQXb2NSv74x342pu t0HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=7xSeibo/4LsJLe4XbPikfy1tn+HZ7/dG1Hw5n7ueeU8=; b=FGkVQp8hmhH/bPjQbdWxb9Xslc59UrbCZzqJFIeFiT8upKDUCdn7mxJ+kLHckcmkZh b/3M77ZlAQGkoC+89//KFIUkycmvG+igdJ0MhCJGjP4R0cewVKiWPsy8Jjj2iZaEoK3b I9NSOwrVO8xh4XrQDienjIY72a8TZe2BzQEBc31BEOVV2pCBF+vVr6Q44XuDkxzk97y+ xlU6VziDkBrAKbuwWs24A0kWHyCNbnE8aCiLCR3oTTi76b1S5fbNfYqxzEbZiwEFA+G2 QhtXUg8Wia3JvpQzELSvIh0U/w4xwbVVlkkwdekVjO/5EVe9khJQgtBDXjkgmKblLNGy 5Iuw== X-Gm-Message-State: AOAM531x4hmrsjHVbZwkTJWPFy70IaVmYwuFNjhWzsTodGZb6r+U6dOy U27f61QG7EAWsyWTgmkH01w= X-Google-Smtp-Source: ABdhPJwR6zT3VVGNWsg0uNT1r2uYJNUaHZEDmgY/aR+Jcni5SXrSwk29/nMdqGGTA/qngYVAWCbJ1A== X-Received: by 2002:a05:600c:4f83:: with SMTP id n3mr4570469wmq.129.1641423529282; Wed, 05 Jan 2022 14:58:49 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id h4sm281610wrf.93.2022.01.05.14.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 14:58:48 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Wed, 05 Jan 2022 23:58:47 +0100 In-Reply-To: <1e4755f3697d54b751684210215a1337c101f4ca.camel@gmail.com> References: <082a81964a43ae5f735ad2ca433d0dfe00859c35.camel@gmail.com> <20211230073919.30327-1-philip@philipmcgrath.com> <20211230073919.30327-6-philip@philipmcgrath.com> <7d5dd434d7750123fa32cb623df0463d60d3f82f.camel@gmail.com> <23eaa7e6-c087-d885-924a-192917758bbf@philipmcgrath.com> <5b83ba5e35af7ac956a6d5de41cb98a892863b55.camel@gmail.com> <4e443a9e-e024-d641-14cd-e36ef7cae46d@philipmcgrath.com> <1e4755f3697d54b751684210215a1337c101f4ca.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641423547; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7xSeibo/4LsJLe4XbPikfy1tn+HZ7/dG1Hw5n7ueeU8=; b=fXglVjD6BO94MWxPVK87l0VlIPslhJ5A8MIQhRI1NtHLIycu+SIX2rs/kpsxUK29OB2TVg JkMVxSrDlV6RgMeVYTWg2VxHQ591yPBADS9irU30Fq7c4x9bdKKj/hqblRsGttLMRn08PS GCQWg0U7gTVIhVzeJl5QUwmAaXOnO22ka1P3hOZnwnOpo2X+1SI2ZB6g5NmabSH3DfkdXH qaDRn0TmWbVhbd7Efwtrnh5kMkrXe0RsKHXFIJgL2enDl3ItMMtTuiZaQpz8o7E25GIWtR /LTVPk7lR/IbaknOpzfwSRBiRXf5LjS/S+vm94bL73BdPfcLCaZDk0NSSqF6Pw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641423547; a=rsa-sha256; cv=none; b=gdz9A8gn04aIFXeWaVRKF/zYikTX5zeXA0yQixGFgDQ+gZ4Uc/mnWOHT0N0PLEF2Qf2IXO TiBV1yH5f+G1v4/Et6Ig9HECiO9+L8XT+Q5TfXmOP+Kck155uMeZ3u9SpTm/ZxZm4CXNo3 3RpUQ0yVxDYKvr0gC/eNXOvk+vPkgRdA2wCkKi1P5Ky3sb3BxrRkkKV6seaWGQtAGiBzi5 3x/dgry3tnnnFS2YbWfWaZhd29ND2taVkVHRQFyPRg785ITsjhAmxrzK5vi1bjLzJ/w9Zs eBkxAcSTujNnE1eXNaq03Upb2rqKgPHdBzs9pHFwGYubaV/vV2GtPZEiPNbIWA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Z8A0+vuu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Z8A0+vuu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CD0D9412F3 X-Spam-Score: -2.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: vCKC6d1pTGTS Am Mittwoch, dem 05.01.2022 um 22:04 +0100 schrieb Liliana Marie Prikler: > That's not at all my intention.  I'll write up a checklist as a > follow-up.  We can go over these shortly and I'll have v6 with minor > adjustments land hopefully soon (if it can't be done tomorrow I'll > shoot for Sunday).  Would that be acceptable? Okay, here's my checklist. I'll denote discussion points with numbers and actionable tasks with square brackets. Send me a reply in which you mark either the ones you want to have or the ones you don't (give a short reason for each) and I'll make it work. The entries marked with a forward slash would require an additional round of review to ensure I don't fuck any of this up (pardon my lack of a better term), so it's probably better to open up separate bugs for those if we want to be quick. I feel rather confident about the rest, however. 1. Move alist/json primitives to new file or shrink them in vertical size. Since you raised valid points against moving them, that'd be shrinking them in vertical size. To this end: [ ] Use SRFI-71 wherever applicable. [ ] Implement them in terms of SRFI-1 span. [ ] For the json-side only define json-update* as it appears to be the only one used later on (need confirmation on that one) 2. Reduce Racketisms [ ] Use DEFAULT instead of FAILURE_RESULT. [/] Define json-update* as syntax. 3. Generic style stuff [ ] Move conses inside match. [/] Merge with-atomic-json-file-replacement and json-update into a single syntax (rewrite-json-file). [ ] Simplify delete-dependencies so that we can directly write  (lambda args (delete-dependencies DEPS). [ ] Use identifier-syntax for the empty JSON object (how do we name it?) If I omitted anything and it's simple enough to fit this mold, do add it and I'll see if I can tack it on or we would need to go through another round for that. Sorry this all took so long.