From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: 68656@debbugs.gnu.org
Cc: Josselin Poiret <dev@jpoiret.xyz>,
Leo Famulari <leo@famulari.name>,
Tobias Geerinckx-Rice <me@tobias.gr>, Wilko Meyer <w@wmeyer.eu>
Subject: [bug#68656] [PATCH core-updates 6/7] gnu: lvm2-static: Properly handle eudev dependency in pkg-config.
Date: Mon, 22 Jan 2024 14:36:22 +0100 [thread overview]
Message-ID: <d478510e9c40735ea53cebead0651e4a6baa4ed4.1705762361.git.dev@jpoiret.xyz> (raw)
In-Reply-To: <cover.1705762361.git.dev@jpoiret.xyz>
From: Josselin Poiret <dev@jpoiret.xyz>
* gnu/packages/linux.scm (lvm2-static): Add linking flags for the static eudev
output.
Change-Id: Ic43be600f0569a8ffa69544cbf661f05d82e2084
---
gnu/packages/linux.scm | 39 ++++++++++++++++++++++++---------------
1 file changed, 24 insertions(+), 15 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 2977b8f88e..38a7caf71b 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4596,8 +4596,8 @@ (define-public lvm2-static
(inherit lvm2)
(name "lvm2-static")
- ;; Propagate udev because libdevmapper.a depends on libudev.
- (propagated-inputs `(("udev:static" ,eudev "static")))
+ (inputs `(,@(package-inputs lvm2)
+ ("udev:static" ,eudev "static")))
(arguments
(substitute-keyword-arguments (package-arguments lvm2)
@@ -4611,19 +4611,28 @@ (define-public lvm2-static
;; it until the situation improves.
(delete "--enable-dmeventd" ,flags)))
((#:phases phases)
- `(modify-phases ,phases
- (add-before 'configure 'adjust-Makefile
- (lambda _
- ;; These fixes are related to the upstream libdm->device_mapper
- ;; migration and will hopefully be fixed upstream in due time.
- (substitute* "tools/Makefile.in"
- ;; This variable is empty in a static configuration and causes
- ;; an erroneous GCC command line.
- (("-L\\$\\(interfacebuilddir\\)") "")
- ;; Remove obsolete reference to libdevmapper.a.
- (("-ldevmapper") ""))
- #t))))))
- (synopsis "Logical volume management for Linux (statically linked)")))
+ #~(modify-phases #$phases
+ (add-before 'configure 'adjust-Makefile
+ (lambda _
+ ;; These fixes are related to the upstream libdm->device_mapper
+ ;; migration and will hopefully be fixed upstream in due time.
+ (substitute* "tools/Makefile.in"
+ ;; This variable is empty in a static configuration and causes
+ ;; an erroneous GCC command line.
+ (("-L\\$\\(interfacebuilddir\\)") "")
+ ;; Remove obsolete reference to libdevmapper.a.
+ (("-ldevmapper") ""))
+ #t))
+ (add-after 'install 'adjust-pkgconfig
+ ;; The static eudev is missing its pkg config file, and I am not
+ ;; rebuilding it at this point.
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* (string-append #$output "/lib/pkgconfig/devmapper.pc")
+ (("Requires.private: .*") "")
+ (("Libs.private:")
+ (format #f "Libs.private: -L~a -ludev"
+ (dirname (search-input-file inputs "lib/libudev.a")))))))))))
+ (synopsis "Logical volume management for Linux (statically linked)")))
(define-public thin-provisioning-tools
(package
--
2.41.0
next prev parent reply other threads:[~2024-01-22 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 13:33 [bug#68656] [PATCH core-updates 0/7] Cryptsetup woes Josselin Poiret via Guix-patches via
2024-01-22 13:36 ` [bug#68656] [PATCH core-updates 1/7] gnu: cryptsetup: Update to 2.6.1 Josselin Poiret via Guix-patches via
2024-01-22 13:36 ` [bug#68656] [PATCH core-updates 2/7] gnu: Add libdevmapper-propagated-inputs Josselin Poiret via Guix-patches via
2024-01-22 13:36 ` [bug#68656] [PATCH core-updates 3/7] gnu: Add libcryptsetup-propagated-inputs Josselin Poiret via Guix-patches via
2024-01-22 13:36 ` [bug#68656] [PATCH core-updates 4/7] gnu: volume-key: Add required transitive dependencies Josselin Poiret via Guix-patches via
2024-01-22 13:36 ` [bug#68656] [PATCH core-updates 5/7] gnu: libblockdev: Add libcryptsetup propagated inputs Josselin Poiret via Guix-patches via
2024-01-22 13:36 ` Josselin Poiret via Guix-patches via [this message]
2024-01-22 13:36 ` [bug#68656] [PATCH core-updates 7/7] gnu: cryptsetup-static: Fix static build Josselin Poiret via Guix-patches via
2024-01-24 16:42 ` [bug#68656] [PATCH core-updates 0/7] Cryptsetup woes Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d478510e9c40735ea53cebead0651e4a6baa4ed4.1705762361.git.dev@jpoiret.xyz \
--to=guix-patches@gnu.org \
--cc=68656@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=leo@famulari.name \
--cc=me@tobias.gr \
--cc=w@wmeyer.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).