From: Maxime Devos <maximedevos@telenet.be>
To: daniel.maksymow@tuta.io, 57453 <57453@debbugs.gnu.org>
Subject: [bug#57453] WIP (chrpath)
Date: Mon, 12 Sep 2022 16:22:35 +0200 [thread overview]
Message-ID: <d3da1c4b-1991-68f6-87c8-2f4eb0b074a2@telenet.be> (raw)
In-Reply-To: <NBgj90x--3-2@tuta.io>
[-- Attachment #1.1.1: Type: text/plain, Size: 2454 bytes --]
On 11-09-2022 15:28, daniel.maksymow--- via Guix-patches via wrote:
> Finally I found the time for building this package. I removed those
> generated flags and added
> native-inputs autoconf automake. Looks like there is an error in
> configure.ac file
>
> But during build I get this error:
> ./configure: line 4921: syntax error near unexpected token `$flag,'
> ./configure: line 4921: ` JAPHAR_GREP_CFLAGS($flag, CFLAGS="$CFLAGS
> $flag" )' [...]
>
> Have you idea what can be wrong here?
I included too many files in the list of files to remove.
'acinclude.m4' is fine -- it doesn't appear to be generated, it looks
like source code. Tested with the following definition:
(define-public chrpath
(package
(name "chrpath")
(version "0.16")
(source (origin
(method url-fetch)
(uri (string-append
"https://deb.debian.org/debian/pool/main/c/chrpath/chrpath_"
version ".orig.tar.gz"))
(sha256
(base32
"0yvfq891mcdkf8g18gjjkn2m5rvs8z4z4cl1vwdhx6f2p9a4q3dv"))
(modules '((guix build utils)))
(snippet
;; Remove generated Autotools files -- they are generated
;; and additionally don't support new architectures.
'(for-each delete-file
(find-files "."
"\\b(configure|config\\.sub|config.guess|Makefile\\.in|missing|depcomp|config\\.h\\.in|aclocal\\.m4|install-sh)$")))))
(build-system gnu-build-system)
(native-inputs (list autoconf automake))
(home-page "https://tracker.debian.org/pkg/chrpath")
(synopsis "Tool to edit the rpath of ELF binaries")
(description
"@code{chrpath} allows you to modify the dynamic library load path
(rpath and runpath) of compiled programs and libraries")
(license gpl1+))) ; condition (9) of the GPL 2 (no version is specified)
Also, one additional thing: you are using the '.orig.tar.gz' tarball,
but Debian often patches software. On
https://packages.debian.org/sid/chrpath, there is a also a patch
chrpath_0.16-2.diff.gz , fixing a MIPS-specific bug. Could you add it
go gnu/local.mk, gnu/packages/patches and the 'patches' field (using the
'search-pathes' procedure)?
(MIPS isn't a 'fully supported' system anymore according to (guix)GNU
Distribution, but assuming the patch applies cleanly, might as well make
it a tiny bit more supported.)
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-12 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 10:40 [bug#57453] Add chrpath package damaxi via Guix-patches via
2022-08-28 16:10 ` [bug#57453] Add new package chrpath damaxi via Guix-patches via
2022-08-28 16:33 ` [bug#57453] Add chrpath package Maxime Devos
2022-08-28 19:16 ` [bug#57453] WIP daniel.maksymow--- via Guix-patches via
2022-08-28 22:24 ` Maxime Devos
2022-09-11 13:28 ` daniel.maksymow--- via Guix-patches via
2022-09-12 14:22 ` Maxime Devos [this message]
[not found] ` <NCBSkq3--3-2@tuta.io>
2022-09-17 19:57 ` [bug#57453] WIP (chrpath) Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3da1c4b-1991-68f6-87c8-2f4eb0b074a2@telenet.be \
--to=maximedevos@telenet.be \
--cc=57453@debbugs.gnu.org \
--cc=daniel.maksymow@tuta.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).