From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uHeSONiOfmL2HgAAbAwnHQ (envelope-from ) for ; Fri, 13 May 2022 19:01:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6DmhN9iOfmIeCwEAG6o9tA (envelope-from ) for ; Fri, 13 May 2022 19:01:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 86ECF3B3FC for ; Fri, 13 May 2022 19:01:12 +0200 (CEST) Received: from localhost ([::1]:53046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npYf9-0001L3-1z for larch@yhetil.org; Fri, 13 May 2022 13:01:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npYf0-0001I3-GJ for guix-patches@gnu.org; Fri, 13 May 2022 13:01:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npYf0-0004nr-3K for guix-patches@gnu.org; Fri, 13 May 2022 13:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1npYez-00026j-So for guix-patches@gnu.org; Fri, 13 May 2022 13:01:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54986] [PATCH] gnu: mpd: Add support for socket activation. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 13 May 2022 17:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54986 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54986@debbugs.gnu.org, Maxime Devos Received: via spool by 54986-submit@debbugs.gnu.org id=B54986.16524612528060 (code B ref 54986); Fri, 13 May 2022 17:01:01 +0000 Received: (at 54986) by debbugs.gnu.org; 13 May 2022 17:00:52 +0000 Received: from localhost ([127.0.0.1]:44896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npYep-00025w-Lx for submit@debbugs.gnu.org; Fri, 13 May 2022 13:00:51 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:39812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npYen-00025d-Ls for 54986@debbugs.gnu.org; Fri, 13 May 2022 13:00:50 -0400 Received: by mail-ej1-f65.google.com with SMTP id bv19so17413652ejb.6 for <54986@debbugs.gnu.org>; Fri, 13 May 2022 10:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=JN5U+gAgTD/IH3wmOSQ28ZxIcZOrP1192oQArTCvSF8=; b=Yfj2PtaL8Dx3DJ5F8ewd+NDmTH59LKC1ntHOM/SthglIzFpXFSvGRkNyDom5GFSRFQ 1UIxZ+MXluRwcBbpcJKtZIfuLp5yz6qy7xIjmt1NJQdrXM8Dl/NTUX6s4TZlnPd0BOAT rWFc/sPg1WrB6Bru5jKJNwtgUbF3hnBGPpZX8jOXQU185GFRAqhoXAd32/Sja4slNDzj PWacAJA3wqm18YRzo6H9usC0KsKORvCLVnOGVN0dnUNViR0NQL7u6jYN6Llo7/beAheX YKnPY67jzeK4sjDBwoCxetHnDX590ZP/PHeEEQ5MkWI+3EIzatbzfw4XctqTQB/7W2Qe y8xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=JN5U+gAgTD/IH3wmOSQ28ZxIcZOrP1192oQArTCvSF8=; b=Y9pQqeDEAH+g0bwLxcLkJm3SCK3n0vEcgdk0pbqnQDWHwU9+dknbCNGVrFBUTb92zw 0+77CI4WxuuW48bDV7fbiZ6Eb4+1e/ckf7fNZzMR0iDQt1VZxW3+bnNVr0BYwmEh3O2y aki55Y5lAovGyCOpRepkC/2QE5vCvHlEqcLpHGfF7dHEXOaipF5dw7wC7F9n6d9lmKaR 5/UmH9OyNL8O+wyQ3996BHofX6CcxIxJKmQORQtCmDaKlvZMtkwu39gJblld8VC4dQ4K 4dAl1y5GaimlaQEB6SUx3ROiBThmp7lcyX/c8t1cfRFrnsh5Lmmcnd+wFEr1n/mPDu9y mPlQ== X-Gm-Message-State: AOAM532hC2XdNHlMKtBPrpw/l1ucQ15ZlF4OSBhoiBYDNJnvaLDGD6Cz xQ+pzZ3lVrteL1f+JllBKyc= X-Google-Smtp-Source: ABdhPJwcLmZby5X0YKaxj4Qw4sqaKXHyEA8FwUe3qU+wkq3+gAaWwkoicuu9yQjgXRopevYWzh559w== X-Received: by 2002:a17:906:d9d1:b0:6fd:d8d5:5c9c with SMTP id qk17-20020a170906d9d100b006fdd8d55c9cmr5058426ejb.665.1652461243468; Fri, 13 May 2022 10:00:43 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id u11-20020a50eacb000000b0042617ba6383sm1198062edp.13.2022.05.13.10.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 10:00:42 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Fri, 13 May 2022 19:00:41 +0200 In-Reply-To: <87ee0xfmvb.fsf_-_@gnu.org> References: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@gmail.com> <87y1zqfabs.fsf@gnu.org> <87ee0xfmvb.fsf_-_@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652461272; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JN5U+gAgTD/IH3wmOSQ28ZxIcZOrP1192oQArTCvSF8=; b=FlsWAbj+h70AR3y7JvS8GtqRj3x/kk4OOAf4ayZtTJBrE7GggEnAa2qSF2kPH0BARSLnUA c+TULw0NMRZMpcSYG+ADazIFMBAhKKHRhPmSz4ZGCWZdGmegUtuUpbpDuRWD4PYtLD6+5L +17KkC0DgeoRbf/1oxLLEHCiiELVCL5VPPl1BAU26p+PqSaUqzyF1WBaYcBKPsgYImZMpG kyrS1fYYgoYzC1XepSv3cURsazbCJeD5wwLUxgK5BdCVDrYKJ2mRdnqfsnMWSymXDzRPGf zS4dnVsE5ByiItDgq1eVIHuAi5F7R4w1RpWiZUBANRMYa0ICx0s9rjiVsgvuvA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652461272; a=rsa-sha256; cv=none; b=pKB9iuNohrSs0FOs0AvWSRg57/GVgjEwdwxvD4loI0oAJKGEURiDmZMo/HEi8pivWb4fOP 8aRzScQghlnOSOnCygNScvScpeBrlaOB0xcXSP/0KIkSGRkywICDb1bjFrqkTRw7p5TkZK CpJm+O52MXsOKjmZnHs2AMdd33DDZRBW+7OwZ2JlTQyZKN5GJMcBvrJ4G1D+6QtL/1sSax OaQAnihtKZocx5CoH6eW7xWp0QfW+tCx6aa16zr7wYZLF2fg1JO+0q+RSF/W/Kww23YamX 2c4jcjllJU3MIZ2aFFR35MjoqDpz7iKgrZ9Wj9RtHmW4SH4wKLskOUSE9OMbrQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Yfj2PtaL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Yfj2PtaL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 86ECF3B3FC X-Spam-Score: 5.97 X-Migadu-Scanner: scn1.migadu.com X-TUID: YEF5++YTAujN Am Freitag, dem 13.05.2022 um 17:55 +0200 schrieb Ludovic Courtès: > Hi Liliana, > > What’s the status of this patch series?  Would be nice to have it in! The patch for MPD itself is good to go as far as I'm aware, the patch for the service type is work in progress. This question > Ludovic Courtès skribis: > > The way I see it, service configuration should be oblivious to > > whether it’s started as “forkexec”, systemd, or inetd. has me in a bit of a bind in multiple ways. For one, I don't see a direct translation from MPD's configuration scheme to shepherd's. For another, the distinct semantics between forkexec and lazy loading cause observable differences as in “What the fuck, I only ran mpc status, why is the music now playing?” – this can be avoided if the user knows that shepherd will be lazy-loading mpd and that it might as a result to starting start playing on the first received command. Moreover, I think the patch I added to make endpoint records configurable from Guix could also serve to solve other bugs, e.g. SSH only listening on IPv4 addresses, which would require us to be able to specify whether to listen on IPv4, IPv6 or both through Guix. Long term, I think we should only keep the distinction between forkexec and inetd/systemd for those services where it makes an observable difference, like mpd. For SSH, apart from bugs and perhaps people using old shepherd, I don't think there'd be any reason to keep forkexec beyond a certain point (in a future as distant as you would want it to be). Maxime also raised hygiene concerns that would be comparatively easy to solve. TL;DR: v2 [1/3] is good, [2/3 WIP] and [3/3 WIP] should be kept back for now. Cheers