From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QHHNIS79wGGQPQEAgWs5BA (envelope-from ) for ; Mon, 20 Dec 2021 23:01:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id MHN2HS79wGEOWAAA1q6Kng (envelope-from ) for ; Mon, 20 Dec 2021 22:01:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1570AA076 for ; Mon, 20 Dec 2021 23:01:18 +0100 (CET) Received: from localhost ([::1]:47590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzQia-0007c4-Mj for larch@yhetil.org; Mon, 20 Dec 2021 17:01:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzQiM-0007ag-Uf for guix-patches@gnu.org; Mon, 20 Dec 2021 17:01:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40106) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzQiM-0006Ze-3r for guix-patches@gnu.org; Mon, 20 Dec 2021 17:01:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mzQiM-00086n-2z for guix-patches@gnu.org; Mon, 20 Dec 2021 17:01:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v5 07/45] guix: node-build-system: Add #:absent-dependencies argument. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Dec 2021 22:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timothy Sample , Philip McGrath Cc: 51838@debbugs.gnu.org, Pierre Langlois , Jelle Licht Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.164003761831101 (code B ref 51838); Mon, 20 Dec 2021 22:01:02 +0000 Received: (at 51838) by debbugs.gnu.org; 20 Dec 2021 22:00:18 +0000 Received: from localhost ([127.0.0.1]:51650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzQhe-00085Y-Fz for submit@debbugs.gnu.org; Mon, 20 Dec 2021 17:00:18 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:56054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzQhc-00085J-Cj for 51838@debbugs.gnu.org; Mon, 20 Dec 2021 17:00:17 -0500 Received: by mail-wm1-f65.google.com with SMTP id c66so4074997wma.5 for <51838@debbugs.gnu.org>; Mon, 20 Dec 2021 14:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=OUdsWrmKQ7ArdHkMHwfKsUeQXOnyLagd0tsmsXF1iHE=; b=q1NpvIlU/J2k72jtpxgO5jZfhmxFXknciiJ9V8nOifg7wQu+M+XeiZwOyU+EyJCzgn EypqLwFdIbn4Xd0DZVgfTF3KJtEZnY/LUasCBfwaL0Hl1bsfEchIRaXl59lvjCoHBspc Tu5kCjSepZhD7StEDA91UefmKbdKP3mnfd4qbxMd2xANCsEHmoy4UPppijOwchakRSpI 2nGoflXT9QW8HDLj30fw/FyJ8mDu0M6iMxIELpSb2keVPKgKBEAY3r3W8HQyrIdsyzl5 Y+CRlN/1deHcDuU1KTMoeZyAn32R79gfw0WphvRHiMVAEmYG/DSMkBRRny6QWxujPvF2 Kagw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=OUdsWrmKQ7ArdHkMHwfKsUeQXOnyLagd0tsmsXF1iHE=; b=T/Jh4dBhcBuzOAwVO9oLRlakNPRIidKoMg0c9MPQhZltzwaB+n1hRm0YZZvNgTBpzL QRiULw08lwrtWsLcoNd74ic2O0sSScj6vbW8ixgyb/pESWUN9GH2c0bLcv29j2HflopX 7ORE8YIWqqbjRtgJQQXZcI/EvXZcAjV+Ppq+JFlfZC2tMy3M/T5mrW6T28nMguAnw7Hn RwUidZ5o4zCAsPLC/EJjDKAqerS8aRczy8uAY7kH0BNzXjBLJBJYmnO/RjLzA+EAyQ0/ fhJtYs/arZnTXAbmlAlGMt3S8F5qtrElJX5XMNO2tsFd5iGBSIIauD1mgIPAO8J4Afa3 Z1Kw== X-Gm-Message-State: AOAM5302vwY8VaVKtHAou4p0xb84F6LEOUHOU65EjVE1dy7KidS+f9Pm EZI1qsafQnoTNitgEzT5qzQ= X-Google-Smtp-Source: ABdhPJwXmp/V5Lg+sRbEuX1q2QLZpJeDveuf0VAFrVkSj1BrHzis4BsNwwmvyz8vLtXCR+5R1jIX3w== X-Received: by 2002:a1c:2049:: with SMTP id g70mr21898wmg.185.1640037610456; Mon, 20 Dec 2021 14:00:10 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id b132sm522387wmd.38.2021.12.20.14.00.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 14:00:09 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Mon, 20 Dec 2021 23:00:08 +0100 In-Reply-To: <87r1a7118r.fsf@ngyro.com> References: <20211213060107.129223-1-philip@philipmcgrath.com> <20211217020325.520821-1-philip@philipmcgrath.com> <20211217020325.520821-8-philip@philipmcgrath.com> <87k0g36xp3.fsf@ngyro.com> <871r2a7hme.fsf@ngyro.com> <815f327e36ecd24066179586997947ecd8f31150.camel@gmail.com> <33696592-8a3a-8260-bf27-652cf78727a6@philipmcgrath.com> <2c803ea8f5c5c16c892f5528f63a4c7e98470c5b.camel@gmail.com> <314a0ea4-a851-6642-0a59-d4c61d65c242@philipmcgrath.com> <35164d79ab6ae1c0595d27f023376cf98ab1a39d.camel@gmail.com> <9533cfc8-b822-edc0-67ac-7e2c9aeacb09@philipmcgrath.com> <87r1a7118r.fsf@ngyro.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640037678; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=OUdsWrmKQ7ArdHkMHwfKsUeQXOnyLagd0tsmsXF1iHE=; b=WvhqtPWTNgZf79IUAYVs+ezy9P74ERJHVL8bjlFmwVzeQ2HnESwqOl3Ls72rm2lzwaOoO0 rcB27i5Uoq1YVqFqEOY99ETyB7TGWN8RykYea2yPCdurkVrqtSpUI9V0b2Sfnyi2GKbiPk f6cjmFtVjoLOZhHK/HzyeTZHnqq/pA0qQeTz9V9/ZtCHFH5bAG1oE2qEtdsrdRdxpSKuiB h2l7380MSYc7lrj9w3gZ01RALnSH///93wDZYW6ZyDDxIvQH/8fMs2dvyUWzR9Vu4NOQIV sYYidn6eXnjwQbVlYNiUOUYZzqkBOwBRue2+Yeg9UPw2qEEU+gxm0EyBdr4q/w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640037678; a=rsa-sha256; cv=none; b=fyakK0LnotJZ+qyTy5+MgqKHZLZkJUYF/oMNsvp/y1XbE81JiLJUA5h+izayVDkhTRFFub EzA7HDHam+9zfJmM0nOhhDHECJ0Q5dELrwaWylpx14XDpEz8v4Q141cbaTlfblPiZb9c3m 9777fNr8mTVOrjT+Ap3d4JGZobI8STXE9LwU+YPtAiwByAJgBSy2H3hlx/TBY9XD9rO10O BHwatwhHrxa4DQjwHkHgTChZUsVLHQwsCKZ1PJjMtvUZ3RuignDqhwbLchW29ZfKu2fEbf sHZMe1bfY+Vef5f8JQOwfwQ0PNoi3o7J/7OO5JGk/Jj7NfnNVOQq9rU37nbnIA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=q1NpvIlU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=q1NpvIlU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1570AA076 X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: Sv5LTmuis2Kd Hi Timothy, Am Montag, dem 20.12.2021 um 15:15 -0500 schrieb Timothy Sample: > Hi Philip, > > Philip McGrath writes: > > > If we took your final suggestion above, I think we'd have something > > like this: > > > > ``` > > #:phases > > (modify-phases %standard-phases > >   (add-after 'unpack 'delete-dependencies > >     (make-delete-dependencies-phase '("node-tap")))) > > ``` > > I’m perfectly happy with this if it’s a compromise we all can agree on. > It is exactly what popped into my imagination when I read Liliana’s > suggestion.  I guess the one thing missing is that it would not > necessarily be implemented on top of better “package.json” > manipulation support.  That said, it doesn’t preclude providing that > support if/when the need arises. In my personal opinion, we would write that support first and perhaps the shorthands later. I.e. (add-after 'patch-dependencies 'drop-junk (lambda _ (with-atomic-json-replacement "package.json" (lambda (json) (delete-dependencies json '("node-tap")))))) although delete-dependencies could even be some chain of alist rewriting procedures if we wanted to be super evil. I don't think we would need to generate phases through FP, we can write them as code. > > I don't know what further steps to take to resolve this > > disagreement or how some decision ultimately gets made. > > > > Maybe someone else could weigh in on how to proceed? > > I’m probably not “someone else” enough at this point, but I guess we > can ask the maintainers to weigh in/help facilitate.  We try to move > forward by consensus, and maybe replacing the keyword with a phase- > making procedure will get us there.  Liliana, what do you say?  Have > we found an approach we can agree on?  If not, I think that we’re > probably stuck and will need some fresh voices to move forward. I personally think phase making is out of scope and we need a solid foundation first. That said, if Philip does provide both that foundation and a good reason to have a phase-making procedure, I'm willing to strike a compromise. Cheers