From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6H1PJ91kwGCIGQEAgWs5BA (envelope-from ) for ; Wed, 09 Jun 2021 08:51:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8C5zIt1kwGAZDgAAbx9fmQ (envelope-from ) for ; Wed, 09 Jun 2021 06:51:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0A291D834 for ; Wed, 9 Jun 2021 08:51:08 +0200 (CEST) Received: from localhost ([::1]:60270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqs3P-0007hE-1R for larch@yhetil.org; Wed, 09 Jun 2021 02:51:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqs3K-0007go-Kz for guix-patches@gnu.org; Wed, 09 Jun 2021 02:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48805) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqs3K-00055J-E1 for guix-patches@gnu.org; Wed, 09 Jun 2021 02:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqs3K-0006KH-8s for guix-patches@gnu.org; Wed, 09 Jun 2021 02:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48889] [PATCH 1/4] New package: bird bgp daemon, versions 1 and 2 Resent-From: Ryan Sundberg Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Jun 2021 06:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48889 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 48889@debbugs.gnu.org Received: via spool by 48889-submit@debbugs.gnu.org id=B48889.162322145324300 (code B ref 48889); Wed, 09 Jun 2021 06:51:02 +0000 Received: (at 48889) by debbugs.gnu.org; 9 Jun 2021 06:50:53 +0000 Received: from localhost ([127.0.0.1]:60351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqs33-0006Jj-7h for submit@debbugs.gnu.org; Wed, 09 Jun 2021 02:50:49 -0400 Received: from mail.arctype.co ([138.68.9.245]:33076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqs30-0006JR-Q0 for 48889@debbugs.gnu.org; Wed, 09 Jun 2021 02:50:44 -0400 Received: from authenticated-user (mail.arctype.co [138.68.9.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.arctype.co (Postfix) with ESMTPSA id 84FCA11F07C; Tue, 8 Jun 2021 23:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arctype.co; s=mail; t=1623221436; bh=L75vR3LmRXzmahOwOa9SUR4T+JCNiNCnFLvTH8g+Xr0=; h=Subject:To:References:From:Date:In-Reply-To:From; b=RNFdCA9W7KDucRuilywsXrjPXU4mkMLbtusAQQiJVGlCQlFVCc6i1wvioieseI9WI P2pNyRwPSAwYGR5DqkOG0DjC43D61MkGiNIgFoc1xHH72qNkRnhtrLntrEWNrztM24 yix4xl6fuaT4i42VDDilrnh5LGy+cyCc0bwlWzp9v6xi2RfykxJ0YY7CXY8PIPfBj2 RivfDX9DN2bpQi4qwE17kyfFec3BWksQctyqrlxyFhKUkSMTQDLWIO3xQhf+TXKZTs cgKAbHRKdo1xGmF0VZLCpDY/BtDTfE+Bou3Bs/OoxKzf64K5s+a0VKb/jsXvZCLoTR MJO4LUy0YvD2A== References: <20210606185204.17617-1-ryan@arctype.co> Message-ID: Date: Tue, 8 Jun 2021 23:50:36 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mjpTdtYiODsLcCSXTt5qJoIkrgltp2x9o" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Ryan Sundberg X-ACL-Warn: , Ryan Sundberg via Guix-patches From: Ryan Sundberg via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623221469; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Sh9aHfaMK6DVQZqLgP2u0m+kK52iQ2/bZqaGbFF3WAY=; b=TXXYs6u58DsixJ7X9gPAWbqNu/TYNfxgkukX05/rG7S3saTXivBnpIGNI+SLDsWN8mDx2+ GwLRFXvOj/wNPpcSr+255Cc4mNzBW3P4oPmGdeluMTxThAoMv+UE3EIeU7U51bexkXdiVQ sXnwswYzab19mZ2inaLxLWHgpnBX9SacHmD/o9ZMVIZDSLtdgQfNuKEik+BL62fIavt/Dz oBK83tk2zlc1pldtukU6fw0Hmf8Uoa3uVJ+zSzXuWVLpFmiHVzHO06RP8ZHC2T8eZdo+pe xhklGbbkVnhImGH2lNJs497q2zPjn2XdZ37kVz9+mAvl9s9Ep0VAcVNBt/GZ2Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623221469; a=rsa-sha256; cv=none; b=DmE7qSr2V6vLxCQ5j8Fx8Rfu1cdiN/wqMNsof4VQeRd9jO80DgTJz6kfDQgj21i1KOvIOk jpzMGYqagxjw0XBcEoBIPt55SKqO1c54pkxNPlJiFqPd/Gy2u94wju1wv7TPwqF2180DgF YXpBzoYNmgELvF9hjuLvY32tkjEdqVrkLR4Heix9ZoD8NS7bbql9K/HQ/pJbuYzAJFK5fb Ff/KzzpS8WWi1dWqSo2CADMO1xTCarKHXZR7Yt7tfQDtXKgFcgdn5keTs2tbZgPEDy/+lP S2huNvE6BqMAy/AxnxEoWZpOutpvunMXOIWMlGouxH1agf13yPR9uKm2QVx95w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=arctype.co header.s=mail header.b=RNFdCA9W; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -5.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=arctype.co header.s=mail header.b=RNFdCA9W; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B0A291D834 X-Spam-Score: -5.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: bznILWGhnvoX This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mjpTdtYiODsLcCSXTt5qJoIkrgltp2x9o Content-Type: multipart/mixed; boundary="ac26DVDMEvWkETWu1SRInGBC3PDZHUp58"; protected-headers="v1" From: Ryan Sundberg To: Maxime Devos , 48889@debbugs.gnu.org Message-ID: Subject: Re: [bug#48889] [PATCH 1/4] New package: bird bgp daemon, versions 1 and 2 References: <20210606185204.17617-1-ryan@arctype.co> In-Reply-To: --ac26DVDMEvWkETWu1SRInGBC3PDZHUp58 Content-Type: multipart/mixed; boundary="------------FBCE853F94381F5881803948" Content-Language: en-US This is a multi-part message in MIME format. --------------FBCE853F94381F5881803948 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Maxime, thanks for the good feedback. Please see the revised patch her= e. -- Sincerely, Ryan Sundberg On 6/7/21 2:35 AM, Maxime Devos wrote: > Hi, >=20 > Ryan Sundberg via Guix-patches via schreef op zo 06-06-2021 om 11:52 [-= 0700]: >> Adds the bird BGP daemon to gnu/packages/bird.scm >=20 > See commits (e.g. git log -n9) for how to format commit messages. >=20 >> --- >> gnu/packages/bird.scm | 74 ++++++++++++++++++++++++++++++++++++++++++= + >> 1 file changed, 74 insertions(+) >> create mode 100644 gnu/packages/bird.scm >> >> diff --git a/gnu/packages/bird.scm b/gnu/packages/bird.scm >> new file mode 100644 >> index 0000000000..5fac395906 >> --- /dev/null >> +++ b/gnu/packages/bird.scm >=20 > Maybe gnu/packages/networking.scm, instead of creating a new > module for a single package. >=20 >> + #:phases (modify-phases %standard-phases >> + ; Fix "cc not found" in tools/mergedi= rs >> + (add-after 'bootstrap 'set-cc >> + (lambda _=20 >> + (setenv "CPP" "gcc -E") >> + #t))))) >=20 > This most likely should be ,(string-append (cc-for-target) " -E"), to > make sure cross-compiling works. Also, the more declarative #:make-flag= s > is preferred above imperative setenv. >=20 >> + (inputs >> + `(("autoconf" ,autoconf) >> + ("bison" ,bison) >> + ("flex" ,flex) >=20 > autoconf, bison & flex most likely should be native inputs. >=20 >> + ("ncurses" ,ncurses) >> + ("readline" ,readline))) >> + (home-page "http://bird.network.cz/") >> + (synopsis "BIRD Internet Routing Daemon") >> + (description "The BIRD project aims to develop a dynamic IP routi= ng daemon with full support of all modern routing protocols, easy to use = configuration interface and powerful route filtering language, primarily = targeted on (but not limited to) Linux and other UNIX-like systems and di= stributed under the GNU General Public License.") >> + (license gpl2+))) >=20 > The description line is too long. > ./pre-inst-env guix lint bird@1.6.7 should detect that. >=20 > Greetings, > Maxime. >=20 --------------FBCE853F94381F5881803948 Content-Type: text/x-patch; charset=UTF-8; name="0001-gnu-Add-bird-versions-1.6.7-and-2.0.8.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gnu-Add-bird-versions-1.6.7-and-2.0.8.patch" =46rom 4cff7f7e80dd2e46705675aa14d14d95a7ee9a9d Mon Sep 17 00:00:00 2001 From: Ryan Sundberg Date: Fri, 4 Jun 2021 20:53:11 -0700 Subject: [PATCH 1/5] gnu: Add bird versions 1.6.7 and 2.0.8 * gnu/packages/networking.scm (bird): New variable. {bird-1}: New variable. Signed-off-by: Ryan Sundberg --- gnu/packages/networking.scm | 52 +++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index 462215c0f1..6ab23f4ae3 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -43,6 +43,7 @@ ;;; Copyright =C2=A9 2020 Hamzeh Nasajpour ;;; Copyright =C2=A9 2020 Michael Rohleder ;;; Copyright =C2=A9 2021 Hartmut Goebel +;;; Copyright =C2=A9 2021 Ryan Sundberg ;;; ;;; This file is part of GNU Guix. ;;; @@ -4196,3 +4197,54 @@ IPv6 Internet connectivity - it also works over IP= v4.") ;; version. This exception does not (and cannot) modify any license=20 terms ;; which apply to the Application, with which you must still comply= license:lgpl3))) + +(define-public bird-1 + (package + (name "bird") + (version "1.6.7") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.nic.cz/labs/bird.git") + (commit (string-append "v" version)))) + (sha256 (base32 "0vbjp42c2zqmcrqcwm4g4fq1v93l6rlk0c27i0k08f3v07w= 75cih")))) + (build-system gnu-build-system) + (arguments + `(#:configure-flags '("--enable-ipv6") + #:tests? #f ; No tests defined for bird 1 + #:phases + (modify-phases + %standard-phases + ; Fix "cc not found" in tools/mergedirs + (add-after 'bootstrap 'set-cc + (lambda _ + (setenv "CPP" ,(string-append (cc-for-target) " -= E")) + #t))))) + (inputs + `(("ncurses" ,ncurses) + ("readline" ,readline))) + (native-inputs + `(("autoconf" ,autoconf) + ("bison" ,bison) + ("flex" ,flex))) + (home-page "http://bird.network.cz/") + (synopsis "BIRD Internet Routing Daemon") + (description "The BIRD project aims to develop a dynamic IP routing = daemon +with full support of all modern routing protocols, easy to use configura= tion +interface and powerful route filtering language.") + (license license:gpl2+))) + +(define-public bird + (package + (inherit bird-1) + (version "2.0.8") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.nic.cz/labs/bird.git") + (commit (string-append "v" version)))) + (sha256 (base32 "07mh41hsmkcpf6f6lnygzp6g59jma542pcqdkl54ysiqnjm= i5zz1")))) + (arguments + `(#:configure-flags '("--enable-ipv6"))))) --=20 2.31.1 --------------FBCE853F94381F5881803948-- --ac26DVDMEvWkETWu1SRInGBC3PDZHUp58-- --mjpTdtYiODsLcCSXTt5qJoIkrgltp2x9o Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEyVG5Gm1pvFAzyXC2aiMi+MCr96sFAmDAZLwFAwAAAAAACgkQaiMi+MCr96sa 2ggAkV1M7W98oyDaf80AsVQ5peKsFknqts7iC0VDhlylG97rTIG2+9LsTnGQqAdZcZ27lQ6yQ+lz Am/sy4z9eRZbMoPZl9Loh8MrE1miCIpLFuKaXGJzDLGZMH+JZQiLF35JL0Tg5kYzfutNd6fbTVgP ZJs0i59UClLoXNYqhDMeIKYkH66jUMyWcPoOn10JQ0ysa0QXvc+GBS6ffi2HvkpnTQGas7pTItoS 5zrcHF+gTY8gzDa4w2KU3pa7PEf/u1eupa7RhTWD4j+j827zxN9j2ZRNwEFXBol76f8aPojv5DvH AE3H/HDxVUIZkHQ8+7GeNkjaKCXaOFckYRg8hMVvDA== =2Ahv -----END PGP SIGNATURE----- --mjpTdtYiODsLcCSXTt5qJoIkrgltp2x9o--