Hi Maxim! > I'm afraid commenting on all the small changes I've done to the original > submission would take us through the night; if you don't mind I invite > you to consult the changes now merged into master. No worries! > 1. bctoolbox > > I've reported the issue upstream. > > 2. belr > > I've settled to keep 'tester', which was already used in the module and > which better maps to what this output is (a tester binary to run self tests). > > Here I noticed the code relies on the tester file name to resolve its > resources, so adapted the resource install directory to match. > > 3. belcard > > eudev was here also unnecessary, as well as python. > > 4. ortp > > Added a comment about why we are adding a 'doc' output. > > Here I've found an issue where some CMake variables were not set, > causing the doc to be installed in a 'ortp-' named directory. > > Which simplified moving the doc directory. > > 5: mediastreamer2 > > I moved the check phase after the installation, which allowed not having > to copy the binary or resource files, and reinstated some comments. > > Added a comment of why some tests are not enabled. > > 6. belle-sip > > Python was not needed. > > This is the same trick as done earlier, moving the check phase after the > install phase. > > Java was not needed, nor was antlr3 or libantlr3c. > > 7. liblinphone > > Not much else than copying the groupchat_benchmark 500 KiB command with > the tester, where it belonged according to the build system. > > 8. linphone-desktop > > I've found that only liblinphone resources were necessary to have the > application not crash. > > Removed this unnecessary input. > > Added this for easing the migration for people having linphoneqt in > their profile. Huge thanks! Regards, RG.