From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cG0IH5nM0mPGbAEAbAwnHQ (envelope-from ) for ; Thu, 26 Jan 2023 19:55:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id cOX0HpnM0mPeOgEAauVa8A (envelope-from ) for ; Thu, 26 Jan 2023 19:55:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3D28539BEF for ; Thu, 26 Jan 2023 19:55:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pL7Ld-0006Y2-1h; Thu, 26 Jan 2023 13:51:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pL7Kw-00053x-B4 for guix-patches@gnu.org; Thu, 26 Jan 2023 13:51:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pL7Kw-0002uA-1e for guix-patches@gnu.org; Thu, 26 Jan 2023 13:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pL7Kv-0008OF-P4 for guix-patches@gnu.org; Thu, 26 Jan 2023 13:51:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60192] [PATCH] gnu: Add python-tcod. Resent-From: Adam Kandur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 Jan 2023 18:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60192 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 60192@debbugs.gnu.org Received: via spool by 60192-submit@debbugs.gnu.org id=B60192.167475901932171 (code B ref 60192); Thu, 26 Jan 2023 18:51:01 +0000 Received: (at 60192) by debbugs.gnu.org; 26 Jan 2023 18:50:19 +0000 Received: from localhost ([127.0.0.1]:36175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pL7KF-0008Mn-5F for submit@debbugs.gnu.org; Thu, 26 Jan 2023 13:50:19 -0500 Received: from ms11p00im-qufo17291601.me.com ([17.58.38.45]:35446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pL6PO-0006iz-Ph for 60192@debbugs.gnu.org; Thu, 26 Jan 2023 12:51:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1674755489; bh=OI2UGYQ0e2N3g8fwM8B6XD6gAfslqe14wHQBlyrZJ4Q=; h=To:From:Subject:Date:Message-id:Content-Type:MIME-Version; b=b+kjZMKOkw3olis8b7GBen4kcwovzQR0iA512yWiOJEikFps9Sz6PYL0+VHGWC3YK 9S4ULqfk6Cz5n3YOOKF9CjYy7qzsrLOSj8SGLakqILm+g/yxy2t07gdBSpwU89VEum eOzn44962OfFMU2G/9i52tq85k7ZJDiF6GYKtBLL6QgFnIhr/tEOzZ0n9myKwb1Zin 6hUo7xXZXFo0h2MM/Wo6OMG1whOBOgGDOJUHm8K4AzNSpWT4gVmeVKaKvVFrPYXlgL cojiEeGNLRr7V2RUOFvfCMUUzSxsl9ik4kqmCoVtP4TeVBa39440p4Krk7wvfU0pYK oIp9UdAgZy9/g== Received: from ms11p00im-qufo17291601.me.com (ms11p00im-qufo17291601.me.com [17.58.38.45]) by ms11p00im-qufo17291601.me.com (Postfix) with ESMTPS id B5C013A0838; Thu, 26 Jan 2023 17:51:28 +0000 (UTC) Received: from localhost (ms11p00im-dlb-asmtpoutvip.me.com [10.52.196.131]) by ms11p00im-qufo17291601.me.com (Postfix) with ESMTPA id 9C1623A079B; Thu, 26 Jan 2023 17:51:28 +0000 (UTC) Date: Thu, 26 Jan 2023 17:51:28 -0000 X-Mailer: iCloud MailClientcurrent MailServer2308B104.10000-Famine2308-0-6c2ccbee4fd8 Message-id: Content-Type: multipart/alternative; boundary=Apple-Webmail-42--80faaf0a-f27c-4f44-bdd4-719252c78072 MIME-Version: 1.0 In-Reply-To: <87k019r5ck.fsf@gnu.org> References: <20221218210216.3920-1-manualbot@icloud.com> <87k019r5ck.fsf@gnu.org> X-Proofpoint-ORIG-GUID: Xum8RWK361Bs7bFsrxLUPx_BpWtZnUis X-Proofpoint-GUID: Xum8RWK361Bs7bFsrxLUPx_BpWtZnUis X-Proofpoint-Virus-Version: vendor=fsecure engine=1.1.170-22c6f66c430a71ce266a39bfe25bc2903e8d5c8f:6.0.425, 18.0.816, 17.0.605.474.0000000 definitions=2022-01-18_01:2022-01-14_01, 2022-01-18_01, 2020-01-23_02 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 phishscore=0 clxscore=1011 spamscore=0 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2301260172 X-Mailman-Approved-At: Thu, 26 Jan 2023 13:50:17 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Adam Kandur X-ACL-Warn: , Adam Kandur via Guix-patches From: Adam Kandur via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674759321; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=OI2UGYQ0e2N3g8fwM8B6XD6gAfslqe14wHQBlyrZJ4Q=; b=YebJSHzGTyDrv3JW2dGNZuoYewHILMa8AP4dYeHV960ZjYBs/km5+z0wltF+xpnYvTuz1l uLokA/qFKf7fqnXP9wyzPBOqOhwZy9e5bZVhdgYz/JWV2YID2+59zn3d7azc9T5UBtRrBX CvE4IBYtPpZjolaS5TtjFIoWyHwesKYAbTwXEg8GFhP5bz0Y13JGQ30JQODMfsnFhvzWDm +Ve+zkT/ILC+Mnsy7JIuQo9U0FKUomXwAVhscFsv32Pc5h4RHBDsB/OqSerlDGl2cnh1Ek QpDO+5Ky/LooW4slZSnqTlILcV+5Ei7SSDkpQ8yGcnJrmuuBZ4vEh/tCaQIkdQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=icloud.com header.s=1a1hai header.b=b+kjZMKO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674759321; a=rsa-sha256; cv=none; b=TTKC/l19Pd7+SmTQa7aOI/roy/QzGB0xj5bpcpQWzdilwyMQ28rGMGfW5aJODda7kql/bh XGp0LPXy5gWnu+S3I5auWPqGn0e4aYHTd/v3DeiUd5v6MiBvMmTNq0bai7xN1HIYf6yYTv 2OmZcUU6+jeQ9jSWqBuHp7GNHnOf12SUNK5sbyGdg1XJlJDCJ2bQqmWmiPaRiX0ACIGIVV sZf06PRrkCBubcwuKSTWCCmzr4js838jGCiafudE0+11bjEueRFFA2EU7LMythWYcg21kc XnI6WjNTbmKUqv8C0AP3bLQr7QBwMuJrctPq2rAuWJEC8t4NnY0cOfhjvp0gcw== X-Spam-Score: -2.17 X-Migadu-Spam-Score: -2.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=icloud.com header.s=1a1hai header.b=b+kjZMKO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3D28539BEF X-Migadu-Scanner: scn1.migadu.com X-TUID: sxiruk9sKMpE --Apple-Webmail-42--80faaf0a-f27c-4f44-bdd4-719252c78072 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8; format=flowed Sure, I will fix my patch and will try to build the package with suggested= input (probably next week).On Jan 26, 2023, at 1:51 AM, Ludovic Court=C3=A8= s wrote:Hi,Adam Kandur skribis:* gnu= /packages/game-development.scm (python-tcod): New variable.I suggest the a= ttached changes.However, one comment:+ ;; tests fail for a strange re= ason+ ;; "ERROR docs/conf.py - FileNotFoundError",+ ;; but this = file is in the checkout+ (arguments+ '(#:tests? #f))+ (nat= ive-inputs+ (list sdl2+ python-pcpp+ python-= pycparser+ python-requests+ python-pytest-runner+ = python-pytest-benchmark+ python-pytest-cov))+ = (propagated-inputs+ (list python-numpy+ python-typing-e= xtensions+ python-cffi))+ (home-page "https://github.com/= libtcod/python-tcod")+ (synopsis+ "This library is a Python cff= i port of libtcod")That =E2=80=98FileNotFoundError=E2=80=99, could it be b= ecause libtcod itself is missing?I would expect libtocd to be in =E2=80=98= inputs=E2=80=99 since this package providesbindings to libtcod, no?+ = (description+ "A high-performance Python port of libtcod.+Includes t= he libtcodpy module for backwards compatibility with older projects.")Plea= se improve the synopsis and description as per: https://guix.gnu.org/manua= l/en/html_node/Synopses-and-Descriptions.htmlCould you send an updated pat= ch?Thanks,Ludo=E2=80=99.diff --git a/gnu/packages/game-development.scm b/g= nu/packages/game-development.scmindex 304df3bd75..dd08241080 100644--- a/g= nu/packages/game-development.scm+++ b/gnu/packages/game-development.scm@@ = -2584,11 +2584,12 @@ (define-public python-tcod (package (name "python-tco= d") (version "13.9.1")+ (home-page "https://github.com/libtcod/python= -tcod") (source (origin (method git-fetch) (uri (git-reference- = (url "https://github.com/libtcod/python-tcod")+ (url hom= e-page) (commit commit) (recursive? #true))) (file-name (git-file-name nam= e version))@@ -2613,7 +2614,6 @@ (define-public python-tcod (list python-n= umpy python-typing-extensions python-cffi))- (home-page "https://gith= ub.com/libtcod/python-tcod") (synopsis "This library is a Python cffi port= of libtcod") (description --Apple-Webmail-42--80faaf0a-f27c-4f44-bdd4-719252c78072 Content-Type: multipart/related; type="text/html"; boundary=Apple-Webmail-86--80faaf0a-f27c-4f44-bdd4-719252c78072 --Apple-Webmail-86--80faaf0a-f27c-4f44-bdd4-719252c78072 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8;
Sure, I will fix my patch and will try to build the package with= suggested input (probably next week).

On Jan 26, 2023, at 1:51 AM, Ludovic Court=C3=A8s <ludo= @gnu.org> wrote:


= Hi,

Adam Kandur <manualbot@icloud.com> = skribis:

* gnu/packages/= game-development.scm (python-tcod): New variable.
I suggest the attached changes.

H= owever, one comment:

+ ;; tests fail for a strange reason
+ ;; "ERROR= docs/conf.py - FileNotFoundError",
+ ;; but this file = is in the checkout
+ (arguments
+ '= (#:tests? #f))
+ (native-inputs
+ (= list sdl2
+ python-pcpp
+ = python-pycparser
+ python-requests
=
+ python-pytest-runner
+ python= -pytest-benchmark
+ python-pytest-cov))
+ (propagated-inputs
+ (list python-numpy
+ python-typing-extensions
+ = python-cffi))
+ (synopsis
= + "This library is a Python cffi port of libtcod")

That =E2=80=98FileNotFoundError=E2=80=99, could i= t be because libtcod itself is missing?
I would expect libto= cd to be in =E2=80=98inputs=E2=80=99 since this package provides
=
bindings to libtcod, no?

+ (description
+ "A high-performance P= ython port of libtcod.
+Includes the libtcodpy module for ba= ckwards compatibility with older projects.")
Please improve the synopsis and description as per:
=


Could you send an updated patch?

<= div>Thanks,
Ludo=E2=80=99.
diff --g= it a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm=
index 304df3bd75..dd08241080 100644
--- a/gnu= /packages/game-development.scm
+++ b/gnu/packages/game-devel= opment.scm
@@ -2584,11 +2584,12 @@ (define-public python-tco= d
(package
(name "python-tcod")
(version "13.9.1")
(source
(orig= in
(method git-fetch)
(uri (git-reference
+ (url home-page)
(co= mmit commit)
(recursive? #true)))
(file-name= (git-file-name name version))
@@ -2613,7 +2614,6 @@ (define= -public python-tcod
(list python-numpy
pytho= n-typing-extensions
python-cffi))
(= synopsis
"This library is a Python cffi port of libtcod")
(description
--Apple-Webmail-86--80faaf0a-f27c-4f44-bdd4-719252c78072-- --Apple-Webmail-42--80faaf0a-f27c-4f44-bdd4-719252c78072--