1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
| | Subject: [PATCH] Fix WebKit linkage.
Somehow the whole linkage fails because of the TestRunner's undefined
references. However, I see the very same fixes in openjfx8-devel FreeBSD port,
even though they use gradle to build it.
CMakeFiles/DumpRenderTreeJava.dir/__/TestRunner.cpp.o:TestRunner.cpp:function TestRunner::runUIScript(OpaqueJSContext const*, OpaqueJSString*, OpaqueJSValue const*): error: undefined reference to 'WTF::String::String(unsigned short const*, unsigned int)'
CMakeFiles/DumpRenderTreeJava.dir/__/__/TestRunnerShared/UIScriptContext/UIScriptContext.cpp.o:UIScriptContext.cpp:function WTR::UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback(): error: undefined reference to 'WTF::String::String(unsigned short const*, unsigned int)'
Some related bugs/commits are:
https://github.com/WebKit/webkit/commit/1e46377e47674363131299d54c8557734a99fb5f
https://bugs.webkit.org/show_bug.cgi?id=199625#c24
https://bugs.webkit.org/show_bug.cgi?id=200074
---
.../src/main/native/Source/cmake/WebKitCompilerFlags.cmake | 5 -----
1 file changed, 5 deletions(-)
diff --git a/modules/web/src/main/native/Source/cmake/WebKitCompilerFlags.cmake b/modules/web/src/main/native/Source/cmake/WebKitCompilerFlags.cmake
index 5bcf047..4526ee6 100644
--- a/modules/web/src/main/native/Source/cmake/WebKitCompilerFlags.cmake
+++ b/modules/web/src/main/native/Source/cmake/WebKitCompilerFlags.cmake
@@ -176,11 +176,6 @@ if (NOT MSVC)
string(REGEX MATCHALL "-fsanitize=[^ ]*" ENABLED_COMPILER_SANITIZERS ${CMAKE_CXX_FLAGS})
endif ()
-if (UNIX AND NOT APPLE AND NOT ENABLED_COMPILER_SANITIZERS)
- set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--no-undefined ${CMAKE_SHARED_LINKER_FLAGS}")
-endif ()
-
-
# CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS only matters with GCC >= 4.7.0. Since this
# version, -P does not output empty lines, which currently breaks make_names.pl in
# WebCore. Investigating whether make_names.pl should be changed instead is left as an exercise to
--
2.26.2
|