From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8GIdIYtKLWJFPQEAgWs5BA (envelope-from ) for ; Sun, 13 Mar 2022 02:36:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mKORGYtKLWLudQAAG6o9tA (envelope-from ) for ; Sun, 13 Mar 2022 02:36:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 34E8535486 for ; Sun, 13 Mar 2022 02:36:11 +0100 (CET) Received: from localhost ([::1]:50154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTD9W-0002N4-CH for larch@yhetil.org; Sat, 12 Mar 2022 20:36:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTD9O-0002Ma-4G for guix-patches@gnu.org; Sat, 12 Mar 2022 20:36:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47360) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTD9N-0006nn-Rw for guix-patches@gnu.org; Sat, 12 Mar 2022 20:36:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nTD9N-0007sA-Oz for guix-patches@gnu.org; Sat, 12 Mar 2022 20:36:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54273] [PATCH] gnu: nicotine+: update to 3.2.1. Resent-From: Fatima Toothpaste Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Mar 2022 01:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54273 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54273@debbugs.gnu.org Received: via spool by 54273-submit@debbugs.gnu.org id=B54273.164713531730204 (code B ref 54273); Sun, 13 Mar 2022 01:36:01 +0000 Received: (at 54273) by debbugs.gnu.org; 13 Mar 2022 01:35:17 +0000 Received: from localhost ([127.0.0.1]:41255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTD8f-0007r4-Ci for submit@debbugs.gnu.org; Sat, 12 Mar 2022 20:35:17 -0500 Received: from knopi.disroot.org ([178.21.23.139]:51120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTCoK-0007KG-NX for 54273@debbugs.gnu.org; Sat, 12 Mar 2022 20:14:17 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A405C400C5; Sun, 13 Mar 2022 02:14:15 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 45M_KUB8L8YK; Sun, 13 Mar 2022 02:14:14 +0100 (CET) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1647134054; bh=u3q/dUPHHQjSrSEFUdSvFvaRTN1VPGn9BBLAmq9zTxI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=IPT0F0TjdwefoIUe3aed78ni7E4WGqTL/FZ0IbuxHH0r8WxLVPncCSe/wCaXGGta5 PtYubu+M06V8mOL3tHkq9ChJ5jzx+EYu7RXJgJKRJgF+XNFcvA714D8BINuXxrjLrR bX5RhFIZsb/iv+hd1hISQhvaGZBuw3jxNnUkjneSVAkdDIlifTISj8BlQJJyV2EvtZ yr2aPwTAkIKWRiMnaUeX+c/INfFUNd9jPg2gvV/a36uWYGOZnk84dTO3W2BqKUvKTh NSH+L0zsbB2fFCMKBj49SI/OWX1xbzweRal3IBAnaVZCvvhxFuUFviOui6SZjz4XkO v2le8ukUPl8+g== Date: Sun, 13 Mar 2022 10:14:11 +0900 Mime-Version: 1.0 Content-Language: en-US References: <20220306054551.19383-1-fatimatoothpaste@disroot.org> <87lexgw34t.fsf@gnu.org> In-Reply-To: <87lexgw34t.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Sat, 12 Mar 2022 20:35:16 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Fatima Toothpaste X-ACL-Warn: , Fatima Toothpaste via Guix-patches From: Fatima Toothpaste via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647135371; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hvY4dNDfCyguAXluzc5fLXIUSNYbKC3x4prBr7+qeR4=; b=ZaOxdt3yRU14hlIBq0BmDRFDnYbZwZPRRAhHP8mLpINkckPTLOBS5keWVvJ4NLCUD3/NgD O5Se97ZOMSkIcbtrHgmrFubJ6z3EsnaLW2qnxm3nV17ZyEpvfHgK8AW260+aB4qkS4YLBb neZ909e4Am/GX5T4gIAq+DoPGDAYQROQ85CvqIWNWCEmpZWz09SQDK+blPTQjjaPMVwr/y toRfZj3fP3XvjY+QyqkzlwbIYBTa3XcJOVnWGkuuK6PTUVSmcmMvi85zCfQFP1xZLWPrjQ uYpTAVwlxQYGQ1+OG7sUz5s+KZRVDOPXpfqobH4PAxE0JzJa4QeYAbipH6FVMw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647135371; a=rsa-sha256; cv=none; b=F5gGJz8qZDWyYVhuW2xLaOX3qu6Uj6QwVzNG2r6s2oJvYPkPmvTdj/zI26L7FQgpGgctYw y2jwG1zyl0UCxnpC9jQrS1nkskZ7hlcZ07VbzQp14K9Yt5p1IQI0IpPUCwgpRL28QewbCS e6m1B9vFEn/n5MIYwdbuoikwHsb7C7nm4Rms4ffn/PYcsdWzLk9qyh+e4CNU+nvsRtvQHj f2OySP9BRV+vKWtv0VASmbx/R4rk3oNO5lI/67csDlykdhmOa4Oea/KpXG260ZXuNqdo0X HN482YUtgH4HqTe9Y42jDABuZPTKJngI+yn5DEqgYXaja3/AO6jhI18Q/Z7Irw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=IPT0F0Tj; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.88 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=IPT0F0Tj; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 34E8535486 X-Spam-Score: -3.88 X-Migadu-Scanner: scn0.migadu.com X-TUID: lLLuyuzraqaP Sorry, I fixed what you said, and other messes i made. Thanks for reviewing. On 3/12/22 07:11, Ludovic Courtès wrote: > Hi, > > Fatima Toothpaste skribis: > >> * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1. >> [arguments]: Delete check phase. >> [inputs]: Add bash-minimal. >> [home-page]: Update URL. > [...] > >> + ;;Tests require network connection >> + (delete 'check)))) > Tests should rather be disabled with #:tests? #f. > > However, could you check if we can just skip (or tweak?) the tests that > specifically depend on networking? > > The rest of the patch looks good to me. > > Thanks, > Ludo’.