From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFOly-0002t6-LW for guix-patches@gnu.org; Mon, 29 May 2017 13:48:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFOlu-0005Te-N9 for guix-patches@gnu.org; Mon, 29 May 2017 13:48:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40969) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFOlu-0005TK-C9 for guix-patches@gnu.org; Mon, 29 May 2017 13:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dFOlu-0001HV-5Q for guix-patches@gnu.org; Mon, 29 May 2017 13:48:02 -0400 Subject: bug#27123: fonts: more changes to font-build-system, one follow up commit Resent-Message-ID: Message-Id: MIME-Version: 1.0 From: Arun Isaac Date: Mon, 29 May 2017 23:17:43 +0530 In-reply-to: <20170528205754.53cta22ho7ddmjnd@abyayala> References: <20170528205754.53cta22ho7ddmjnd@abyayala> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 27123@debbugs.gnu.org Thanks for the patches! Patches 1, 3 and 4 LGTM. Patch 2... > * gnu/packages/fonts.scm (font-awesome)[source]: Switch to the source on = github as the previous zip file > is updated in place, resulting in a changed hash sum. This commit message line is too long. On emacs, you can wrap it to the next line with `fill-paragraph'. The contents of the zip archive are updated in place without changing the version number? Is that what you mean by "in place"? Should we treat this as a one-time accident by upstream? Or have they made a habit out of this? IMO, we should forgive them this one time, and if they do this again, then we can move to their github release archive. WDYT? =