unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: ng0 <ng0@pragmatique.xyz>
Cc: 27123@debbugs.gnu.org
Subject: bug#27123: fonts: more changes to font-build-system, one follow up commit
Date: Mon, 29 May 2017 23:17:43 +0530	[thread overview]
Message-ID: <d05c816f.AEEALIAeSwYAAAAAAAAAAAPFwUsAAAACwQwAAAAAAAW9WABZLF7L@mailjet.com> (raw)
In-Reply-To: <20170528205754.53cta22ho7ddmjnd@abyayala>


Thanks for the patches! Patches 1, 3 and 4 LGTM.

Patch 2...

> * gnu/packages/fonts.scm (font-awesome)[source]: Switch to the source on github as the previous zip file
> is updated in place, resulting in a changed hash sum.

This commit message line is too long. On emacs, you can wrap it to the
next line with `fill-paragraph'.

The contents of the zip archive are updated in place without changing
the version number? Is that what you mean by "in place"?

Should we treat this as a one-time accident by upstream? Or have they
made a habit out of this?

IMO, we should forgive them this one time, and if they do this again,
then we can move to their github release archive. WDYT?

  reply	other threads:[~2017-05-29 17:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28 20:57 bug#27123: fonts: more changes to font-build-system, one follow up commit ng0
2017-05-29 17:47 ` Arun Isaac [this message]
     [not found] ` <07bb4605.AEEALIAeSwcAAAAAAAAAAAPFwUoAAAACwQwAAAAAAAW9WABZLF7L@mailjet.com>
2017-05-29 18:28   ` ng0
2017-05-29 18:54     ` Arun Isaac
2017-06-01  9:51 ` Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d05c816f.AEEALIAeSwYAAAAAAAAAAAPFwUsAAAACwQwAAAAAAAW9WABZLF7L@mailjet.com \
    --to=arunisaac@systemreboot.net \
    --cc=27123@debbugs.gnu.org \
    --cc=ng0@pragmatique.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).